From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f46.google.com (mail-oo1-f46.google.com [209.85.161.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 989DF212548 for ; Sun, 1 Feb 2026 19:06:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769972805; cv=none; b=W1UDc/6LIJnyngaL8hhoACoFLAh99RRp1fEoxdMuxCevhUrWxUfncoxuH/dTkUpU5DY6kaFfY4DOyl8paCcMt9diJnQw3dYu1Eox7Lg5NqSCq4DyRQObyoFL2fe41t3Rx7kLU14QB2zhsiUFz47w75f8zJbV2aLdx1JBBhfSgNI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769972805; c=relaxed/simple; bh=FHBCSbc/MBTQbG2EGdkEpIvHeDPYDnFviPtcBWuxs/k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sQGRK9g6nI7lKD5TCt4RRslJFLisYjmCOLPJogtZqc6Q9z9rcoWZkuRR171F9ouSqm22bAaA6v+MQ4fcZuc6Q8+cHrl8HWEGzSJugq5MXaFTjLUVEKoOFbeBT5tOKNuB5zj7lP0Bu5CDuNcb4xepxDFERammmlOwVcrvNSP7lBc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=jjlI6WES; arc=none smtp.client-ip=209.85.161.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="jjlI6WES" Received: by mail-oo1-f46.google.com with SMTP id 006d021491bc7-662f9aeb782so2456112eaf.3 for ; Sun, 01 Feb 2026 11:06:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1769972801; x=1770577601; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3vpjgpzMDJ+JdTfciP67JHeLgUTGZm6k2MW+XRPJY1c=; b=jjlI6WESEC3BRPJEqcyxVPsuP5OPMWIvDx4cPtvODnxI4w6sb3Y/IswHc1KYwnP5o5 XKebPsFrmrFRxhZ8BgPKDKfbqw9zuWRM0EGe0v5mC73+JrZaSilM0ZNB5V+lFsSuFqDn JLEkaxATTfpVy4gNNuof7/bGlk4LqRuDqgYUmhUZeJGMIB6t5EKD8Tb+cS7/HvkHfeOD 8toJqTUYuMQW5A2qhstUX23Hq3nkp/Zueuuw7NF7yG5aoRR0N1Ijn8czfCX5xoN7yjXj MW4+BcvlHbVndaqHrlKSV1fxbYnmp5jUKTjqVt/z4FjDWlYo3vYFnZSzJv4hjCVn7ZCI sIgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769972801; x=1770577601; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3vpjgpzMDJ+JdTfciP67JHeLgUTGZm6k2MW+XRPJY1c=; b=CdkjhSrLi6cpPje6efrUKBqGI22y0TuQ8BpD1ti5FIjbYlJbRRI51cp4pE4TO0Znyo gx13Uu5yXglJs4W/WWZvbxYMec/eRUC7VHKl5SdmeRCDPLL/BWgyUtAHSF034X2L40RC dnHbUFvsS/NYnuEvsc/O8lJ/fKZP1sqNsnrHYGdmMNfe/W1aKV6pRViYtMdFY8ktXnfV MUcPKJ+sqM4pMHPOB/gVY2EjJl4ZLH0g5E+1E/wBARcdQj8nATkcWVef+DV6c/vByQc/ QAjCDf4YEnZNcoRNkZsuArC+EMDJ02QwVVzLcr2b3IgK+9ue7ASyLAsCOToKeChWkaAU LhUg== X-Forwarded-Encrypted: i=1; AJvYcCUx0FUUTNIYLXEoyLgcdOO0h6RlFkklUM9ILo9jIv9jtlQdZMPy++52NA1w1+gMMgC+BvTS8A0Nh3oS0pk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+AGmLdRUhUmbCi/VGVRQLcVZviUlfN5ImDQPlQ4UUf8zQFzmu fzYTx10m/lIT5VFz08QGrIsIs2RpIZeFumeeiyHFu8zD0fmQqh64gvaPKz2uDmE+SMw= X-Gm-Gg: AZuq6aIPnR0sotFXVqJEIptVdnXumNqftf6wkDxkEgRNi/jOqaf0ZUTbVEfTLnZNMv5 GKSVKHiOZruzv7kdcH4eks08zIFBges27QaBZqnuCkpvNyd91+m10Mlhid9YwGHwzgUbE+AXJFO q0dkPvJ+Nm9vSTFdyCX8TEV50HrK18wJ24KosgM5JBivxGEw8gulfp0WxZ5Nf3C13lz7GYpL8GF 8+HLP4krnPPbQ/+v0Cv9MruNwnPKnv81XaqMaPB55YTRJcsSBjJ4ly4XpCDs2iJtCHPlZZvktj/ RQEBFE5peHwfcL37zaWUJY2AMrATx2mBPmU0yqY60PArlDsxH/qLRiwAuJU/pArVc9F10anQv8K fpPaHMDjFkc5i19i7LrJ3PXr0yU9oaP8u4pdrypEV/YnUueexoCnuaPdi3nES1GOibhXSn6BTP+ sIqpNC1L/H4APdp4ELtU1SbVo/kVzE7/oGCmQdAvN/4n2IR/iGDgufXBFwpXtV X-Received: by 2002:a05:6820:623:b0:662:f452:648d with SMTP id 006d021491bc7-6630f01c0e0mr3876565eaf.9.1769972801465; Sun, 01 Feb 2026 11:06:41 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:66ee:10f7:4858:7df6? ([2600:8803:e7e4:500:66ee:10f7:4858:7df6]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-40956cd8290sm10089242fac.0.2026.02.01.11.06.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Feb 2026 11:06:41 -0800 (PST) Message-ID: Date: Sun, 1 Feb 2026 13:06:39 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] iio: core: Add IIO_EV_INFO_SCALE to event info To: Taha Ed-Dafili <0rayn.dev@gmail.com>, jic23@kernel.org Cc: me@brighamcampbell.com, skhan@linuxfoundation.org, linux-kernel-mentees-archive@lists.linuxfoundation.org, rdunlap@infradead.org, nuno.sa@analog.com, andy@kernel.org, corbet@lwn.net, lars@metafoo.de, Michael.Hennerich@analog.com, linux-iio@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260201183320.27023-1-0rayn.dev@gmail.com> <20260201183320.27023-3-0rayn.dev@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260201183320.27023-3-0rayn.dev@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/1/26 12:33 PM, Taha Ed-Dafili wrote: > While implementing event scaling for the ADXL345 to match > the IIO ABI documentation, I noticed that IIO_EV_INFO_SCALE > was missing from the internal enum iio_event_info. > > Add the constant and the "scale" sysfs string > to allow drivers to expose these attributes correctly. I think this could be worded better. The enum member isn't really "missing". Are there actually any users of these attributes that have implemented it manually? Or is this something just in the docs but not actually ever used? I didn't look very hard, but I didn't find any drivers with these attributes. > > Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com> > --- > drivers/iio/industrialio-event.c | 1 + > include/linux/iio/types.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/iio/industrialio-event.c b/drivers/iio/industrialio-event.c > index 06295cfc2da8..5096baf233f0 100644 > --- a/drivers/iio/industrialio-event.c > +++ b/drivers/iio/industrialio-event.c > @@ -256,6 +256,7 @@ static const char * const iio_ev_info_text[] = { > [IIO_EV_INFO_TAP2_MIN_DELAY] = "tap2_min_delay", > [IIO_EV_INFO_RUNNING_PERIOD] = "runningperiod", > [IIO_EV_INFO_RUNNING_COUNT] = "runningcount", > + [IIO_EV_INFO_SCALE] = "scale", > }; > > static enum iio_event_direction iio_ev_attr_dir(struct iio_dev_attr *attr) > diff --git a/include/linux/iio/types.h b/include/linux/iio/types.h > index 34eebad12d2c..4e3099defc1d 100644 > --- a/include/linux/iio/types.h > +++ b/include/linux/iio/types.h > @@ -21,6 +21,7 @@ enum iio_event_info { > IIO_EV_INFO_TAP2_MIN_DELAY, > IIO_EV_INFO_RUNNING_PERIOD, > IIO_EV_INFO_RUNNING_COUNT, > + IIO_EV_INFO_SCALE, > }; > > #define IIO_VAL_INT 1