From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752824AbcKIIyl convert rfc822-to-8bit (ORCPT ); Wed, 9 Nov 2016 03:54:41 -0500 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:49442 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751332AbcKIIyj (ORCPT ); Wed, 9 Nov 2016 03:54:39 -0500 From: Amitkumar Karwar To: Ricky Liang CC: Nishant Sarmukadam , Kalle Valo , "open list:MARVELL MWIFIEX WIRELESS DRIVER" , "open list:NETWORKING DRIVERS" , open list Subject: RE: [PATCH] mwifiex: fix memory leak in mwifiex_save_hidden_ssid_channels() Thread-Topic: [PATCH] mwifiex: fix memory leak in mwifiex_save_hidden_ssid_channels() Thread-Index: AQHSOjqewMb2APfO0k2KUCm6YXIJs6DQWMRw Date: Wed, 9 Nov 2016 08:53:40 +0000 Message-ID: References: <1478662648-70698-1-git-send-email-jcliang@chromium.org> In-Reply-To: <1478662648-70698-1-git-send-email-jcliang@chromium.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.93.176.43] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-09_03:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1611090168 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Ricky Liang [mailto:jcliang@chromium.org] > Sent: Wednesday, November 09, 2016 9:07 AM > Cc: Ricky Liang; Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo; open > list:MARVELL MWIFIEX WIRELESS DRIVER; open list:NETWORKING DRIVERS; open > list > Subject: [PATCH] mwifiex: fix memory leak in > mwifiex_save_hidden_ssid_channels() > > kmemleak reports memory leak in mwifiex_save_hidden_ssid_channels(): > > unreferenced object 0xffffffc0a2914780 (size 192): > comm "ksdioirqd/mmc2", pid 2004, jiffies 4307182506 (age 820.684s) > hex dump (first 32 bytes): > 00 06 47 49 4e 2d 32 67 01 03 c8 60 6c 03 01 40 ..GIN-2g...`l..@ > 07 10 54 57 20 34 04 1e 64 05 24 84 03 24 95 04 ..TW 4..d.$..$.. > backtrace: > [] create_object+0x164/0x2b4 > [] kmemleak_alloc+0x50/0x88 > [] __kmalloc_track_caller+0x1bc/0x264 > [] kmemdup+0x38/0x64 > [] mwifiex_fill_new_bss_desc+0x3c/0x130 [mwifiex] > [] mwifiex_save_curr_bcn+0x4ec/0x640 [mwifiex] > [] > mwifiex_handle_event_ext_scan_report+0x1d4/0x268 [mwifiex] > [] mwifiex_process_sta_event+0x378/0x898 [mwifiex] > [] mwifiex_process_event+0x1a8/0x1e8 [mwifiex] > [] mwifiex_main_process+0x258/0x534 [mwifiex] > [] 0xffffffbffc258858 > [] process_sdio_pending_irqs+0xf8/0x160 > [] sdio_irq_thread+0x9c/0x1a4 > [] kthread+0xf4/0x100 > [] ret_from_fork+0xc/0x50 > [] 0xffffffffffffffff > > Signed-off-by: Ricky Liang > --- > drivers/net/wireless/marvell/mwifiex/scan.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/wireless/marvell/mwifiex/scan.c > b/drivers/net/wireless/marvell/mwifiex/scan.c > index 97c9765..98ce072 100644 > --- a/drivers/net/wireless/marvell/mwifiex/scan.c > +++ b/drivers/net/wireless/marvell/mwifiex/scan.c > @@ -1671,6 +1671,10 @@ static int > mwifiex_save_hidden_ssid_channels(struct mwifiex_private *priv, > } > > done: > + /* beacon_ie buffer was allocated in function > + * mwifiex_fill_new_bss_desc(). Free it now. > + */ > + kfree(bss_desc->beacon_buf); > kfree(bss_desc); > return 0; > } Acked-by: Amitkumar Karwar Regards, Amitkumar