From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
robh@kernel.org, hdegoede@redhat.com, mchehab@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
sakari.ailus@linux.intel.com, hverkuil@xs4all.nl
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, bod@kernel.org
Subject: Re: [PATCH] media: dt-bindings: Add OmniVision OV02C10
Date: Wed, 26 Mar 2025 17:34:32 +0000 [thread overview]
Message-ID: <afae182f-b264-4b57-acd7-2c2cf090e1ad@linaro.org> (raw)
In-Reply-To: <c1959f95-9ee1-4597-b6ec-fbedc8a872db@kernel.org>
On 26/03/2025 17:19, Krzysztof Kozlowski wrote:
> On 26/03/2025 18:09, Bryan O'Donoghue wrote:
>> On 26/03/2025 15:40, Krzysztof Kozlowski wrote:
>>> On 26/03/2025 16:01, Bryan O'Donoghue wrote:
>>>> Add bindings for OVO2C10 a two megapixel 1080p RGB sensor.
>>>>
>>> You already sent this and got some review. What's more, it's exactly the
>>> same as OV02E10, so just put it to that file.
>>>
>>> Best regards,
>>> Krzysztof
>>
>> They aren't exactly the same.
>>
>> The i2c address of the sensors is different 0x10 for one and 0x36 the other.
>>
>> Also different data-rates for each chip.
>
>
> I meant bindings are exactly the same, unless I missed something.
> Devices are similar enough as well.
>
>> Seems simpler to me to have two separate files ?
>
> Not really, more files to maintain, more trivialities to fix if we
> decide to change something in all bindings (e.g. style).
>
> Best regards,
> Krzysztof
Hmm, so we have two in-flight series and one yaml file.
OK, I'll drop this patch and add ov02c10 to the ov02e10 yaml as you suggest.
So long as the yaml file goes in first, the order of application of the
ov02c10/ov02e10 drivers won't matter and can be fixed with a cherry-pick.
---
bod
next prev parent reply other threads:[~2025-03-26 17:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250319145927.70534-1-hdegoede@redhat.com>
2025-03-24 0:09 ` [PATCH 0/1] Add OV02C10 dt yaml description Bryan O'Donoghue
2025-03-24 0:09 ` [PATCH 1/1] media: dt-bindings: Add OmniVision OV02C10 Bryan O'Donoghue
2025-03-24 17:15 ` Rob Herring
2025-03-26 15:01 ` [PATCH] " Bryan O'Donoghue
2025-03-26 15:40 ` Krzysztof Kozlowski
2025-03-26 17:09 ` Bryan O'Donoghue
2025-03-26 17:19 ` Krzysztof Kozlowski
2025-03-26 17:34 ` Bryan O'Donoghue [this message]
2025-03-27 7:09 ` Krzysztof Kozlowski
2025-03-27 15:07 ` Bryan O'Donoghue
2025-03-27 16:06 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afae182f-b264-4b57-acd7-2c2cf090e1ad@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=bod@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=hverkuil@xs4all.nl \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®