From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0654BA45 for ; Mon, 29 Jun 2026 05:36:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782711420; cv=none; b=LFtuD00y66Dw7vRatQcbwn2w2b7J9BksIDzwO823uhncuAg2CusQcf5M6BPNSsO5JqtfFOk3tG+mTCOgH6WjSVSbWS1U6T649zH+rZ1Rdlcg8BpPPxYvD0N8inDEvloeg4UfLYfgH5nQVJ064hn0xZ6Zy+H1gqVMTvL3P0vVHc4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782711420; c=relaxed/simple; bh=T5xDfj4gTS1yOYXj9otH5qZUmbNKwm2UXsV/Ibrt4Go=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=l8r3OsLl7vx1mDxXv8UzfZTVhKvr6skt2sr4xfIcL1mO7e0YRgBNvreMWWhQREfA1vy6gPnd/GoJULLCesavtSjFyyS8/r2Il9TeFLQZwm01/IPccTSiQ8YvvU/mp8IiV2JF5FvU/D6nQJjUmqoB3k9fBpSXXoUm3PPPXNoGzfg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=h4EVGE6C; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=a1CiB3Nj; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="h4EVGE6C"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="a1CiB3Nj" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65T4NlkB1767364 for ; Mon, 29 Jun 2026 05:36:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4+qSzHrPZLIcegIwXCxSbL9utxNx2NUsdPB6ywBdPMY=; b=h4EVGE6CPcygfKJ8 J/ppWPnDwOBiqTIwRNMgaubFk3tCr4lqdG8L5H85zcRFV+s3H2Y4dXfPWRqKzZH+ ygq7yuHDuxKl12II/s9PZTQGAnvsxAvDMSRJ2q/6aNfloFXw64HoZCG0ZDZJ19vk d7TpdkteWu9iWjA+rbalfRH0okiiqoT2A6R4g6NIEMBhrZDTFo1IeJaHVPHROaDM OvbEZZNTWeq7EWvyHZC/AAM9H5OjkxIegBMjQchOEDox7RC7E5SP4hdP7YzYhdpa H/J0vMo/KSfgy9UGExB2XG2aEK9Ok6IMLif4W1H+r2CZ9IyyuDM6eipBTnD2FgVf Zf/oOg== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f270a4qn5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Jun 2026 05:36:59 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c8924f4d0a4so3313642a12.2 for ; Sun, 28 Jun 2026 22:36:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782711418; x=1783316218; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4+qSzHrPZLIcegIwXCxSbL9utxNx2NUsdPB6ywBdPMY=; b=a1CiB3Nj22ItZj6GgzZfHu/47G3nBRR1m/QHaJhyK0YID992+BzE1favQXB4RTkKdf oi8komVNWMNVh3BRWY/g0v524BaIzsIj1dxWX6rHpdZja8JAKHBIhAy4xPgsccv+DnzJ PO6BSkd3QUQZGKkJCbRfX6Qz+xe90aMeb2tk2G2h1KxdVBY7a/surXplTuH4X3no3GTv xJXfBGL5j+BqCDun3xaEFjlPwwVKWiFbxoq4fxZl67svwQfnkSlz3cF4jNrHbIyLLypE 48U+fYEPmPdsGw1Rw0Lw7RxxOjs8CH0CpJ3EpvMOtuSkY0yCarwvNXVFUWzYj1BvRIu8 8NAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782711418; x=1783316218; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4+qSzHrPZLIcegIwXCxSbL9utxNx2NUsdPB6ywBdPMY=; b=aC9HGJw/SurLuq73Eo4gcZg3fdAszU4BL+EoDlkHaT5veKdzlGLLmY79ga2zBqEHiC gE46NhKpuYj4mVfA9TJZL5sxXMMgD1rBj9yPWZ5WCF77bPRX2H9+ZKRI4WjJcy4EXobz NChzx8Oar0vMQ+aMI35aa+wQ99tp4eNu32owGUAi37EUjiMv5c+5tLMAus3GdY9LtbJe HqKXPIcKO6O4FMVA9rVdeaB1ZQMChCdrgK3P4bYUBATupPkt/d49SbAeXqh9Om3/ATYh 5APLmSghuRd9ibDVWkYyRPV2edMV0EVPfAGGTpqxzl+MzNDYr4ovCem+uYPnirIE4Fld bn0Q== X-Forwarded-Encrypted: i=1; AFNElJ+HcEEtbk3opdykY7KND85Pwl0SNamZgLAfa3/bpvu09hIRMSlhfkXl5/IJQJRwXzbC0GhCvkV1q5MQc0g=@vger.kernel.org X-Gm-Message-State: AOJu0YyN13dxA5KtjXNZ13Z0fZx/8DMV1UiYqSRnu9dhhguSIWR2tDnC kEKn8f5YnVj8tBvsfMXsM/75CrAtxgX8I4+p3OyUhWdUoKUiG6tFgNVptYbQCNn/z1LqYICgGll TEgOir8iDdu+bvYu5oyvcp4S2dCtQfxz6AM4vWp3spBAp4PX453YJBmx9F6Q0/IN3O2M= X-Gm-Gg: AfdE7cn3hMIOEPZB+MYCugU/gRQgVrKnrQBY6uVD86+xmRj8VJZW7vXE6wUQo1eFhKa Dfk75Pz/vX0knyeJrBWEKa7Sqq9p1zUWsV2wwxk6FHRNZBwt8MoFgCr+qaYN1qxy4Cf+13cQJsK oiK0dfU2xy7fWm0N1SKjCaGwa9EbqeyjcYcYlXTWkYwPIhNeZjB48Mu2k0gFwJAlm0Iy2R98lh7 8FQYagJCSq3FWEoKJ30oTy412lXR9i1JE8br+qEEiG66HxWkxmTxIMe5n79Rd0RDzgElhGmkfnu VIq57Df0SouhZA7sBLVx79mvgA4oUhS3dWWIU/X1BDkIShKZIdQZBHHME86znLzzXdomXYyOuCs b12yApk8h+cdO62REo0KejC0Qn67UxqCFCtEUSfztRHPS X-Received: by 2002:a05:6a21:9984:b0:3b1:cce5:9140 with SMTP id adf61e73a8af0-3bd4af44f93mr14859453637.33.1782711418505; Sun, 28 Jun 2026 22:36:58 -0700 (PDT) X-Received: by 2002:a05:6a21:9984:b0:3b1:cce5:9140 with SMTP id adf61e73a8af0-3bd4af44f93mr14859429637.33.1782711418079; Sun, 28 Jun 2026 22:36:58 -0700 (PDT) Received: from [10.217.219.87] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c92bc1e0a90sm7143143a12.15.2026.06.28.22.36.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Jun 2026 22:36:57 -0700 (PDT) Message-ID: Date: Mon, 29 Jun 2026 11:06:52 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] spi: qcom-geni: Add property to force GSI mode To: Pengyu Luo , Konrad Dybcio Cc: Dmitry Baryshkov , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260614083424.464132-1-mitltlatltl@gmail.com> <20260614083424.464132-2-mitltlatltl@gmail.com> <3451facc-4a2e-43bf-ba13-944488bce437@oss.qualcomm.com> <14491fd8-f785-4404-878b-5764bb8fd593@oss.qualcomm.com> Content-Language: en-US From: Mukesh Savaliya In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI5MDA0NSBTYWx0ZWRfXw46GGNhJghqa XIFZRvbS7DP3KmylL0tU2Z8mlQ6M0oGTQqP//ajB1FoSsio/DCkXKkyghuNElmfqWfTrbVZmwpC q0onywsNWHjmMY91KbOe1ysHWj2e8yZW4THzhmQmPVo2eBdDvoCUE2xwMZZYuJxdpHR+Scoh+cs r6trxOESCnL8ABsqq//nPeQrEBQsegIdfVW6z9JUkixFuhTanaH/4Zkzau1UcqcG0w9B0Gbh6+2 FYFL6Cpp9Xaq1WCdsTaO3H7WMeoMMKENPH2txPSc6+0O8luhe0cFIVVesE5tzecgg+hMArNYBX9 +N+xG6PgTOOcciYoqP1Zk6pEWGY2yNKudcmN5/oaSYjNXrX6sD9IjjKdlXP40BBgRENGuNwg8Nr FmUEx4oRbnojnpkWpkEWr16ltV/EtGYGcrhK+GDVXrQoN9v1wHXgDhNqBLnDKo7rY1l7tknjxL6 4IlJklaCEtMvFCE9n9g== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI5MDA0NSBTYWx0ZWRfX+0BwIx8P425q QiuAGaY8hfV6NfK6C36Bo5CI0/Df0STP0hcmINIVnu1m+Qcl2sS8wh/0FyJcEPbDyTioSLFsU1o m+AswYm39MV0M1AKop/YYWpSNaWVIHw= X-Proofpoint-GUID: IqT46nhQsEP6Cm9lR8DxoKbLSEJmdvQj X-Proofpoint-ORIG-GUID: IqT46nhQsEP6Cm9lR8DxoKbLSEJmdvQj X-Authority-Analysis: v=2.4 cv=Fe4HAp+6 c=1 sm=1 tr=0 ts=6a42047b cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=-sOukg-g24Gd-ASWQDMA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-29_01,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606290045 On 6/27/2026 10:52 AM, Pengyu Luo wrote: [...] >>>> This hunk is very odd: >>>> >>>> /* >>>> * in case of failure to get gpi dma channel, we can still do the >>>> * FIFO mode, so fallthrough >>>> */ >>>> dev_warn(mas->dev, "FIFO mode disabled, but couldn't get DMA, fall back to FIFO mode\n"); >>>> >>>> In my understanding, GSI DMA mode is always preferable. +Mukesh, do >>>> you have any insights? >>>> >>> GSI mode is preferable but if for some reason it fails, we try to continue with the FIFO mode. Just fallback mechanism. >> >> So, would making GSI the default and FIFO the fallback option >> sound good? >> > > Yes, I have sent v2, please check here > https://lore.kernel.org/linux-arm-msm/20260616122605.668908-1-mitltlatltl@gmail.com > Just Reviewed and Commented on V2. > Best wishes, > Pengyu > >> Konrad >>