From: Paolo Bonzini <pbonzini@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Babu Moger <babu.moger@amd.com>,
tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
hpa@zytor.com, seanjc@google.com, vkuznets@redhat.com,
wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org,
tony.luck@intel.com, peterz@infradead.org,
kyung.min.park@intel.com, wei.huang2@amd.com, jgross@suse.com,
andrew.cooper3@citrix.com, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: Expose Predictive Store Forwarding Disable
Date: Mon, 27 Sep 2021 14:54:08 +0200 [thread overview]
Message-ID: <afc34b38-5596-3571-63e5-55fe82e87f6c@redhat.com> (raw)
In-Reply-To: <YVG46L++WPBAHxQv@zn.tnic>
On 27/09/21 14:28, Borislav Petkov wrote:
> On Mon, Sep 27, 2021 at 02:14:52PM +0200, Paolo Bonzini wrote:
>> Right, not which MSR to write but which value to write. It doesn't know
>> that the PSF disable bit is valid unless the corresponding CPUID bit is set.
>
> There's no need for the separate PSF CPUID bit yet. We have decided for
> now to not control PSF separately but disable it through SSB. Please
> follow this thread:
There are other guests than Linux. This patch is just telling userspace
that KVM knows what the PSFD bit is. It is also possible to expose the
bit in KVM without having any #define in cpufeatures.h or without the
kernel using it. For example KVM had been exposing FSGSBASE long before
Linux supported it.
That said, the patch is incomplete because it should also add the new
CPUID bit to guest_has_spec_ctrl_msr (what KVM *really* cares about is
not the individual bits, only whether SPEC_CTRL exists at all).
Paolo
next prev parent reply other threads:[~2021-09-27 12:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <163244601049.30292.5855870305350227855.stgit@bmoger-ubuntu>
2021-09-27 10:59 ` Borislav Petkov
2021-09-27 11:13 ` Paolo Bonzini
2021-09-27 12:06 ` Borislav Petkov
2021-09-27 12:14 ` Paolo Bonzini
2021-09-27 12:28 ` Borislav Petkov
2021-09-27 12:54 ` Paolo Bonzini [this message]
2021-09-27 13:38 ` Borislav Petkov
2021-09-27 15:47 ` Babu Moger
2021-09-27 15:48 ` Borislav Petkov
2021-09-28 16:04 ` Paolo Bonzini
2021-09-29 20:27 ` Babu Moger
2021-09-30 13:41 ` Paolo Bonzini
2021-09-30 14:12 ` Babu Moger
2022-08-23 21:26 ` Jim Mattson
2022-08-24 17:13 ` Paolo Bonzini
2022-08-24 17:16 ` Jim Mattson
2022-08-26 10:10 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afc34b38-5596-3571-63e5-55fe82e87f6c@redhat.com \
--to=pbonzini@redhat.com \
--cc=andrew.cooper3@citrix.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=kyung.min.park@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=wei.huang2@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®