From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 619E72BE636 for ; Thu, 31 Jul 2025 11:33:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753961605; cv=none; b=mc3h02c+PSJ80BX20TdwHbOhxIsGrknmgXT1Knk5THI+aK+q52YAWaI+21hQssMkty0I7s9uGEO05xYxNNH0rt9GEtEJbuA57Ri5D5jUgT2WwpTUp0tXAxsNi1ba65+83T1IhyBSKnsZMdYIpsBR4pW4nT7zcjI1bVNsK36gsUE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753961605; c=relaxed/simple; bh=MVHoymTtrUj1FNtzHDj+G/R7m5ic/21SYiflzC29O+U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WNxbF/9ctlsM3F9hWNXmJFn55ryjCdduPa0xFch7b1/PtVAX9eSetC02/kqBrsEWkY8D6ZrZduk52dDl3T8UmHxf8SY86DySJj7fk0wQ6bpwiQuQc9eG1riqtF21lyhDvofXDDA8Iptpe1rzqcT8/875DhuoKxyd1KTvYh/WkpM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KVl0ingj; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KVl0ingj" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56V9fI9L024197 for ; Thu, 31 Jul 2025 11:33:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hiQCVI4PmZedCkpDHfOr5gWtV6DX2AHcDyhpGCv1hLE=; b=KVl0ingjacySND2Z KL76fBWAL7VJFK/s9lqPRtADqB+ZRAn0MCAXW7yT8GNr4dBhD2TPxsgNYxlEPB34 YwSceVonh6V61GfPWxVUqcSv2tc283lXq3F3n9d6r+eZtKK+fokcCF0eHI9nn1AX DFo7UQvLJKRd73+R2mKczq0/6aEJSMt+25Kay0BJMML67BPVwxbdNQsvatSrLxo0 noo3zY3LSflY3jjF65Krrt4bglKWM/8A0Xe/ymdAjvhRpAnfn0J1etskDsWhPXS+ bzos5i9sHiNZW8QtZcwCzHaaAIcRxXvN0lvZPamMZjpWtBQNS1FIYXI9PhIN/s9m 38TbUQ== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 484qda7fyk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 31 Jul 2025 11:33:22 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7dfd0470485so20026185a.1 for ; Thu, 31 Jul 2025 04:33:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753961601; x=1754566401; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hiQCVI4PmZedCkpDHfOr5gWtV6DX2AHcDyhpGCv1hLE=; b=hHEEjU5ghOKHC+lWz30JsBBqjIUrXCCfJioMUFA0sIeFPi3RaXG5V8XQJLcJBWW3iP e+OJpluSyZLnmJekGvX/4IvOMLbFvAILrrg8/2zO73G8Yq5BYO7O3Z43H3cH9drGB6nW URDYKqEGyFPvGHcEpXM+YhtiyDhBhYJFfn3ZyTpD07NiFdulppi/qKwWs6H2YavCG4pq SFduJ4xmM+dsgW6nOsa5v09JSyrATEpNYQYyWObGm/hE/ea6wNfoDWslLvpCOrjkNkDi WAOTVA6Tg4Q2g799CTAWaiX8VdyYG1s2v5EMuDV8euThFrDZ1XCoZm0p2epTD9ya+k8s Lzsg== X-Forwarded-Encrypted: i=1; AJvYcCX2uHxqvd3Gdam8KIyTxPJ5FdgBVRTPI43XDxTNlAN0NFuBQvEZhl0woKE2zscF6GOQFDayOXKD6JafVyg=@vger.kernel.org X-Gm-Message-State: AOJu0Yw24yEJvW9JcEjUHcFZnEotztIwhCS7JImLsCk/ZdgPsG1XHO86 CkDH7NUZhI4a+6m/T2lguAKdrWyQHGII463J/bsnEOBo3u/lDApENUf3mNMd95pzpO8DQEeZnyK 5SuU21yam/XWIqo+0WDiInJaRnQk1iNwdvzNrxB+VKcmfPjfBFq5+65w85C5uQRPw8Aw= X-Gm-Gg: ASbGncsY5FMossXpqwHMoBPIrpdMMjKdv7qkPT2hu/jcqLngLyuHgxQwMTH6x67nxU7 f4gMDqHSVfR/hmhnowIJSklzaTYNt94oKzrERC+DNKV/nkLvZaH1SSsHsAY+Fnp98TZbglVaSCW 30gyQ5n7Sy26MO6aYokblRYKMjEe09FmjDHQRWqTaNUt/aDkxibWKq/TmDmIEjc9fTWL/HpcIJu GqhZCQZ36oVx7CkXBc3LkFe8+UW6lFmQU/mMDtBwKto0K9q8LLjfR80gGNQ7dNoWg8u1wwx2wp4 LPUkVMzzX9eElcwJL2qC8CfUDr9kKZP1GHscH9lnP+PAwIJkxwnvd0R4pgVyD1voDKB9dpqyYLU mtAcoN/eBHVwM0aFuCQ== X-Received: by 2002:a05:620a:c55:b0:7e3:30e6:1fd9 with SMTP id af79cd13be357-7e66f3579famr401347985a.11.1753961601242; Thu, 31 Jul 2025 04:33:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF9SW+3agSd3nX7M2jAwPZf0SuoF4AQlimzli/JD2ZQjueM2pww1iKLHn5i3E3E7+3YegsRmw== X-Received: by 2002:a05:620a:c55:b0:7e3:30e6:1fd9 with SMTP id af79cd13be357-7e66f3579famr401344585a.11.1753961600785; Thu, 31 Jul 2025 04:33:20 -0700 (PDT) Received: from [192.168.43.16] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-615a9115562sm982681a12.59.2025.07.31.04.33.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Jul 2025 04:33:20 -0700 (PDT) Message-ID: Date: Thu, 31 Jul 2025 13:33:17 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/4] arm64: dts: qcom: Add base HAMOA-IOT-EVK board To: Yingying Tang , Yijie Yang , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Shuai Zhang , quic_miaoqing@quicinc.com, quic_zhichen@quicinc.com References: <20250729-hamoa_initial-v3-0-806e092789dc@oss.qualcomm.com> <20250729-hamoa_initial-v3-4-806e092789dc@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: oHy_mFLQICimGohAqoX-T1o1SGgCoSyK X-Authority-Analysis: v=2.4 cv=Pfv/hjhd c=1 sm=1 tr=0 ts=688b5482 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=WymS4dw2S599D73gK6YA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-GUID: oHy_mFLQICimGohAqoX-T1o1SGgCoSyK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzMxMDA3OCBTYWx0ZWRfX40DYQbCfEv+5 f7SFViIupKxEXTTWGV+Hz9EGz3iTkvSgx8+FzDTZm1RVdTnazAOW6/1aIM103hR3fjm/WissKJB 2+mKBi5PjPnQ0xKRtmfL6Pfvx5vabqge+HY5R0TjJVqkNDgI3ooAAbd+zxVJQqfrLz5gyNgfaJM SO8KatWMMRtl0wS8BW45bkMNZbizvu5inKRHT1kQfltfZWQXREQIjkC2xvj/osGvu0ZEev+/K/l PNWx4idv5rw0abxUAw+mxUI/LQse9Xiyb28bYF30f1CF5Qk1m+ZF1yNEL4vHddhVaS2NvxEd3NF AM+U5axROo66XKY+ih4Fo0fIyN+psm5/+Zk7IjrK872b9RhJD8VjczW7sNr2hcipZWR5IMtvF0I Lti1GCdnVUU1u34xnO5VNNSwlKYjHyesKQVO59EwSUigQMNH380/nwnkrVD3V9xq1D5/3nC7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-31_02,2025-07-31_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 clxscore=1015 adultscore=0 priorityscore=1501 mlxscore=0 spamscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507310078 On 7/29/25 11:39 AM, Yingying Tang wrote: > > > On 7/29/2025 4:37 PM, Konrad Dybcio wrote: >> On 7/29/25 7:51 AM, Yijie Yang wrote: >>> >>> >>> On 2025-07-29 09:32, Yijie Yang wrote: >>>> The HAMOA-IOT-EVK is an evaluation platform for IoT products, composed of >>>> the Hamoa IoT SoM and a carrier board. Together, they form a complete >>>> embedded system capable of booting to UART. >>>> >>>> This change enables and overlays the following peripherals on the carrier >>>> board: >>>> - UART >>>> - On-board regulators >>>> - USB Type-C mux >>>> - Pinctrl >>>> - Embedded USB (EUSB) repeaters >>>> - NVMe >>>> - pmic-glink >>>> - USB DisplayPorts >>>> >>>> Written with contributions from Shuai Zhang (added Bluetooth) and Yongxing >>>> Mou (added USB DisplayPorts). >>>> >>>> Signed-off-by: Yijie Yang >>>> --- >> >> [...]>> + vreg_wcn_3p3: regulator-wcn-3p3 { >>>> + compatible = "regulator-fixed"; >>>> + >>>> + regulator-name = "VREG_WCN_3P3"; >>>> + regulator-min-microvolt = <3300000>; >>>> + regulator-max-microvolt = <3300000>; >>>> + >>>> + gpio = <&tlmm 214 GPIO_ACTIVE_HIGH>; >>>> + enable-active-high; >>>> + >>>> + pinctrl-0 = <&wcn_sw_en>; >>>> + pinctrl-names = "default"; >>>> + >>>> + regulator-boot-on; >>> >>> It should be set to 'regulator-always-on'. >> >> Are you sure? Turning off Wi-Fi sounds like a valid usecase.. > > Hi Konard, It is m.2 interface on Hamoa. The PCIe power of m.2 should be always on. > > Even on QCOM's B2B interface, we are unable to dynamically control the power of PCIe devices on upstream kernel. > The PCIe specification does not support dynamic power control between the PCIe device and the RC. > PCIe power should be always on here. I see, I was confused by the name Konrad