From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0A90222596 for ; Thu, 5 Dec 2024 17:11:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733418714; cv=none; b=nlyM5oVkAWeTxe263juQHE5d1OeBjVt1atG0PHGvByHrQ2Ih1sOayo+elYYeI5FNO2rFL7dVaio6RzCEXGQ3JboMR0CwwTYbBOLz40556RlBo3D/B59y6N3Z0GWKi5MALqSWbK93YbjSZpc0kojcX5RP3aquif8TkJqciJ5gL/w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733418714; c=relaxed/simple; bh=dCs69MV7Zl13hYC0C6jT1S77qqNojSyJoi8ckLIfCco=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Fn20LLvYKEXn1cLelzOCQ+h3jUfxm032hKNbW8+nIzbzZAZgnhNF1YMj38p2JSrJpnDqCMOlTltBpIT/CZ+xcNYs8N/Wu95gwWegcfkLVu2uv98UTWVAm78HcaZgV3FxJo7rkeSBqF6Ws5wiBXkeT6QTpfx+T0RQshQKE9cCFu8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HnDIWsCH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HnDIWsCH" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4B5Boa4H029231 for ; Thu, 5 Dec 2024 17:11:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= iISSlmHBhud/xihnWsovVA8IVHWDvju+1GFNeF5yZcs=; b=HnDIWsCHk8Mj4dMC zBkODNviAiZQbWf/PfJO1Iw2IbgvjJjiBH+cUbz/Bmn84/BBo9HtmhbFo5WVBe7Y 1aumpqeZ4eCBZ/QektCuk4X3LYCUeP8FxaOZ+2EmMHwd8XKNd+SDuOnzExwS/BvG xLX2hUBSsLUnrppLn+kG7owiCdEP0ATBpcxnCryfGYpd0nnTPXXWjbzfDiyqoTV4 Ka4+L4FQBbn5ztUvshlSq7af30qG+70nyreIYLoDB+KZVUX3exoGVp4cB+tvqBE7 aMnPOplEigw5zTBM08hkclodM0IJ/iOx6AumlIHXIV3vU0gRzDrF3KCUqNnJwpsb iuRD9g== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43bbnj0wjq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 05 Dec 2024 17:11:51 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4668f02aeebso2651081cf.1 for ; Thu, 05 Dec 2024 09:11:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733418710; x=1734023510; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iISSlmHBhud/xihnWsovVA8IVHWDvju+1GFNeF5yZcs=; b=nMi12UMPxZFW0KjnLnR8VV4q5q4HYFO2aAnCgKzTehqIZTblBqpws4oqrn7uLgrQvp x7vlWI5s0O3AwSKE6n/yG63qsGDMtC6ZRep1GPtxd/0x42erDKn+LQ6PtMZgJDYd/VUp R94xSQU0XSDjWBXvspu3IA/UILTkeXmE5ZXmn7on0pG9VlvsBqVbRilBz4QN7Djuk/c4 B8t/7/QUJTx9K0j251hZ4zMRpW+gNpzd3dAcu91U1YfAJjUGw7WloVxlB+ja8eRC84B9 ZemcQOZZnQZRJLm/wmdTVsaYJtWqvrQj9QnzasfC1PmppnaA71RG6q2KYRP1+zlfmPGS IliQ== X-Forwarded-Encrypted: i=1; AJvYcCWAJ4CNF1l5mpNhmX1Od5YHVGuVJLbXNwPjllPCiBzoslYT4kCXiDaWzIjxNoikOOijRHHF/ktcoLmxSAg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6KKk6i5PI5fsgoWrdPSDQRMGPcKySpCsXRXmbQ0wedRLKWEuL hoVxFLpOFsT4QHwrskx8Wf2o6vzY2XzzzatThLTdMGGuAALA5tUloKnIWz/gsmXGSiU6MG7joPP TiaTX99Kc/RODafVidtxKLAyCHIaP7gr74+DKt/A/9IPGarQev9FKITxdttxpM48= X-Gm-Gg: ASbGncu7hlSlPViaPhkTarr27YUU1ACuJw2C4jQEgwPs7dKBiACH8LDmZV6mw+MtRJf 7CqTeyY+m/njVybpEqMf93WE9xQJT86eKanB9ZzyS5hJSUh68DjgA88jBmV80GqkruLL/Kgfp6R vUCYosS57ZdLkQXhjkDWim4aF0I7fk4RRNMaDB3rHp3xg4IA7pBotztY5HRxNcbUkkzCw3121xi u+OdfckWgsx8pxzb4VOs8xN5xBmPnoXqGpLKb5Xy5nnITQDo0SlLdrItLgFe/0eDSBKFCYyEvjX HYMdYwemBSh3Ad2L+IiDFLNBToheOzU= X-Received: by 2002:ac8:5f07:0:b0:461:6599:b9a with SMTP id d75a77b69052e-4670c3742e7mr76002751cf.11.1733418710628; Thu, 05 Dec 2024 09:11:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IFAbHnaeccAVKfK59GB3HmCo3D97/mpGW0tfexIEEgnv0fxEIWEHBsUs05bec3U+1U+fCbf7g== X-Received: by 2002:ac8:5f07:0:b0:461:6599:b9a with SMTP id d75a77b69052e-4670c3742e7mr76002491cf.11.1733418710144; Thu, 05 Dec 2024 09:11:50 -0800 (PST) Received: from [192.168.212.120] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa625e4eed9sm118085566b.2.2024.12.05.09.11.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Dec 2024 09:11:49 -0800 (PST) Message-ID: Date: Thu, 5 Dec 2024 18:11:47 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: qcom: x1e80100-crd: Drop duplicate DMIC supplies To: Stephan Gerhold , Krzysztof Kozlowski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Conor Dooley , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Johan Hovold References: <20241203-x1e80100-va-mic-bias-v1-0-0dfd4d9b492c@linaro.org> <20241203-x1e80100-va-mic-bias-v1-2-0dfd4d9b492c@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: t9C821c68t2vAh8nzcWq1-FY7DxRWvJJ X-Proofpoint-ORIG-GUID: t9C821c68t2vAh8nzcWq1-FY7DxRWvJJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 clxscore=1015 priorityscore=1501 mlxscore=0 phishscore=0 impostorscore=0 malwarescore=0 mlxlogscore=999 lowpriorityscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412050125 On 4.12.2024 9:33 AM, Stephan Gerhold wrote: > On Wed, Dec 04, 2024 at 08:20:15AM +0100, Krzysztof Kozlowski wrote: >> On 03/12/2024 18:44, Stephan Gerhold wrote: >>> The WCD938x codec provides two controls for each of the MIC_BIASn outputs: >>> >>> - "MIC BIASn" enables an internal regulator to generate the output >>> with a configurable voltage (qcom,micbiasN-microvolt). >>> >>> - "VA MIC BIASn" enables "pull-up mode" that bypasses the internal >>> regulator and directly outputs fixed 1.8V from the VDD_PX pin. >>> This is intended for low-power VA (voice activation) use cases. >>> >>> The audio-routing setup for the X1E80100 CRD currently specifies both >>> as power supplies for the DMICs, but only one of them can be active >>> at the same time. In practice, only the internal regulator is used >>> with the current setup because the driver prefers it over pull-up mode. >>> >>> Make this more clear by dropping the redundant routes to the pull-up >>> "VA MIC BIASn" supply. There is no functional difference except that we >>> skip briefly switching to pull-up mode when shutting down the microphone. >>> >>> Fixes: 4442a67eedc1 ("arm64: dts: qcom: x1e80100-crd: add sound card") >> >> If there is no functional difference and this is just redundant, then >> there is nothing to fix, so drop the tag. But the point is that users >> might want the low-power VA. You claim they don't want... sure, I am >> fine with that but there is nothing to fix in such case. >> > > The fix here is that two mutually exclusive power supplies for the DMIC > are specified in the device tree. You can only have one of them active > at the same time. The Linux driver handles that gracefully, but the > device tree is still wrong and IMO deserves a fixes tag. > > The functional difference is that we skip briefly switching to pull-up > mode when shutting down the microphone. Users won't notice that, but > it's not the intended behavior. > > I don't claim that users don't want to switch to the low-power pull-up > mode (VA MIC BIASn). However, we would need a different mechanism to > give them the option to switch at runtime. "audio-routing" just > specifies static routes, so the current description does not allow > switching between the two modes either. Is there no existing mechanism to alter this at runtime? Konrad