From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D939B254AF4 for ; Fri, 2 May 2025 13:54:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746194069; cv=none; b=t6nv88MK5xPPURwDcSVaotV7FBk40OcSXsfMsL7JQwthac4c7nmrhtSpyE6K8xhvXC1sx83Kb/IJdvE1rKPSfeucN5tRE9VCt9WTqyLHi0KTMzv+/sr3Ptci6Ncby5KVaWn6w9OxvAFoOzVWcsvgfvxg80TcBSfwUfXHNH7SgDE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746194069; c=relaxed/simple; bh=SbYvC/lGbKbVig/CuUnTBRTVK/wus5dwp1Hyif8wsEI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OCzW5tsDcJyXLxmO9ksmy0nMQnqAo0Ubq09h78KWXiwy62sYR1+zHrOUi7e76/qxyFLg/czhTkUQyM3g5syaT7abMG4epbq8FAmTozLBVtuwMbykTmZCoet/LaPWXgx0hqWJA52s/N2BUuEmfSIjhqfLYGV2f9eLTK2zC+M5NaI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XFbdDlW2; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XFbdDlW2" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 542DDlU5015185 for ; Fri, 2 May 2025 13:54:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yL9EoiyJnIJjcu+Ek4UoLm4TG9MKg3HqDNyWMAzlopo=; b=XFbdDlW2SNdvnijb SwJirOH4EhzEbnVzh94ePCGcYcLocIt6Blc4KWIkBqpseH7PBGBoHs8VBXDA2sdQ 4AzG67qLT2mERYPYG8VYctHIJQ7ImJ5ir98vClgJ5sE7UB+jhbeVkQykxS1tBvXa 56YGcBqASyd5fKM3AT4wbP3UsXKWApBFVdkbiiTcypeDZdrWlY/DB2EN3dGijGPJ qOW2In0WlOzw9IwwitrSlU4KSvkEzj3fuDRqG/evdbkATXC7IeIMko+3MYd6Kqb/ d4qWpfjzy8ZVfUZmwAFwnZP5xQ0cu1xNeBXccBevlGhpCBoRpGiSk2bOhCM5VLuW ErD+aw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46b6u4ghcg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 02 May 2025 13:54:27 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7c5841ae28eso48296085a.1 for ; Fri, 02 May 2025 06:54:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746194066; x=1746798866; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yL9EoiyJnIJjcu+Ek4UoLm4TG9MKg3HqDNyWMAzlopo=; b=CiS3oV0xPq75X/bXUyWrlXzon+J8YOpy3bL12I1vf13N+6kWxcEq0ljnqorgXWSzC/ 981hQRco6xuewcxFXO+1gtQB8lT6ZcH6f3a9OpJZ2cOd8iyAL051eiX4P5xxz8gprHn7 7K4IbyxmgovUfEYVA7HacnSyIiQvU0L+gc2FLB1mvi9bO1z/b1+a6Xr+RWbcOSWCRDdO 0ErIKVEQCZvGdaw0FlwK1WqWtlXWFue/R2aqj4xgUouVryur5TeMRfQayeBOdv+Cz7MB Z2beR8Vmry8R3lZZ5Eu+rlPQel4jSgdg8vIbKweWrwKr+WBk/qifVr4zfVyDJeMi9Xba 9zUQ== X-Forwarded-Encrypted: i=1; AJvYcCWwrcfYfpnWz4rLqCeDeXbHyL7iLKQqLaWsnkAlfNxQzacv85J4b7zLfHQj2vbocQV1nr9dZtPeqx/P5Jc=@vger.kernel.org X-Gm-Message-State: AOJu0YwMlCA/scHHk0dpraM3pgUf6dx6aZakxoti7OvgtHmlSyGbZdXH JS0Y5jmAEUg/qfiT/UylkCAfkJ9pBetLEJO1DT8EZDVUWppTf7hYGfTnGgFi7dF8HGszXfNTbGK w406wS8M5t+IRZ2r5RkHqLOWyKsizObkdk+W1TAaLrvekWa+nC6BQnBfpnA+jRHA= X-Gm-Gg: ASbGncsQx0/I8oj95v+x3NCZbTohRZZ+pCEYWZEu8bSHiOtLp+Hsf2oiFqCouOKzAgR zYGbOVp0ks9XS+Iv1Qkf0/we0ha/mxdCk7LYcyAD4bieNAk9ogFuOur7ypXbdFDAGsJn+LDfaa8 dz5OwjJcZF6GARWNNuQ35IuQf1lX2BN+Sv3runBgIvXutjoz0ArxvAQc9ngiM3gY7IgD0i1DKeS S4vYcy0mSz49khRNG2wz22XQBTb4vMVHN0dr7RgQj9Yo1XIs0W5rg4O37icidSlMkvKaewaFPAO KxU05ldxFRq/gsxchX0BQKEC/hEp2pac2RytO71XY0z6xW7RWgbRNyH5A1juaei9B04= X-Received: by 2002:a05:620a:4447:b0:7c3:d752:f256 with SMTP id af79cd13be357-7cad5b4f0f8mr152976685a.7.1746194065716; Fri, 02 May 2025 06:54:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGwqDIQDynRQ/WTGlGryiob37MpltRCrA//d1qVHrqR2ToFyr62qtJV46XmvMEp/ixzQsjp0w== X-Received: by 2002:a05:620a:4447:b0:7c3:d752:f256 with SMTP id af79cd13be357-7cad5b4f0f8mr152974685a.7.1746194065289; Fri, 02 May 2025 06:54:25 -0700 (PDT) Received: from [192.168.65.113] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5fa777c8b1dsm1262238a12.18.2025.05.02.06.54.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 May 2025 06:54:23 -0700 (PDT) Message-ID: Date: Fri, 2 May 2025 15:54:21 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 05/23] media: iris: Prevent HFI queue writes when core is in deinit state To: Bryan O'Donoghue , Dikshita Agarwal , Vikash Garodia , Abhinav Kumar , Mauro Carvalho Chehab , Stefan Schmidt , Hans Verkuil , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Dmitry Baryshkov , Neil Armstrong , Nicolas Dufresne , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, 20250417-topic-sm8x50-iris-v10-v7-0-f020cb1d0e98@linaro.org, 20250424-qcs8300_iris-v5-0-f118f505c300@quicinc.com, stable@vger.kernel.org References: <20250502-qcom-iris-hevc-vp9-v3-0-552158a10a7d@quicinc.com> <20250502-qcom-iris-hevc-vp9-v3-5-552158a10a7d@quicinc.com> <250cdec3-1437-4c45-aab1-0428218b9437@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <250cdec3-1437-4c45-aab1-0428218b9437@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: yxkhBIIM3ydDOwnW102SPRY_nyR_wE8H X-Authority-Analysis: v=2.4 cv=Yaq95xRf c=1 sm=1 tr=0 ts=6814ce93 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=AWkmbyHJa9485OIXA2sA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=zgiPjhLxNE0A:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTAyMDExMCBTYWx0ZWRfXzWVqTF0Ghc14 fQthtKeXNACAd9aGWnoerwoZK+YFeiaiwbEni4wsHYrBNU4sN/c+VS0wim0NVhsvds/pAm9xvIs MZYJ1/gJVvOV+iQkuKOWpa6qoNXV5360FBLOcDQkrpTbRmh3bugD5FvXy+pbVykMCqmYriGCNp/ oNg/LR7qVTlq9Q/yrNASL9NEk5RHBFuwfXNeJM+015o9qawgwleX2QWhKkLUsDXHIPtNFwaXrUH r4aNA9vhG7zGz7EnxL11Ek/Arje3QqSeRn/kTkUhPGKI05akLLEJ1pPJhaiUrxMNVyVIuUg8gXM 7+S1LaWnz57xQjhZP5VKrQK30rd/iYA2JZCgy4yVCMGE5X0EZrbqYC1niE5iO1BlGFVUyJp8cu9 8m7+OthQ9p8AwSOhLueWb+xw9CrhSZlFGO1dgpXcqrTrzRwqQ50gvx2TP7IebEslXqkeRS/Z X-Proofpoint-GUID: yxkhBIIM3ydDOwnW102SPRY_nyR_wE8H X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-02_02,2025-04-30_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 clxscore=1015 suspectscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 adultscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2505020110 On 5/2/25 2:22 PM, Bryan O'Donoghue wrote: > On 01/05/2025 20:13, Dikshita Agarwal wrote: >> -    if (core->state == IRIS_CORE_ERROR) >> +    if (core->state == IRIS_CORE_ERROR || core->state == IRIS_CORE_DEINIT) >>           return -EINVAL; > > Instead of checking for 2/3 of the states why not just check for the 1/3 ? > > enum iris_core_state { >         IRIS_CORE_DEINIT, >         IRIS_CORE_INIT, >         IRIS_CORE_ERROR, > }; > > if (core->state != IRIS_CORE_INIT) >     return -EINVAL; > > Cleaner and more explicit - declaring the state you must be in, as opposed to a list of states you should not be in. Being explicit in state machines helps maintainability - if we get e.g. IRIS_CORE_LIGHT_SLEEP down the line, this could easily fail Konrad