From: Pavel Skripkin <paskripkin@gmail.com>
To: cgel.zte@gmail.com, phil@philpotter.co.uk
Cc: Larry.Finger@lwfinger.net, straube.linux@gmail.com,
linux@roeck-us.net, martin@kaiser.cx, dan.carpenter@oracle.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Changcheng Deng <deng.changcheng@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] staging: r8188eu: remove unneeded variable
Date: Fri, 12 Nov 2021 19:31:04 +0300 [thread overview]
Message-ID: <afe0a4bb-c6fe-8eeb-6077-dde7839537e9@gmail.com> (raw)
In-Reply-To: <20211112131830.11418-1-deng.changcheng@zte.com.cn>
On 11/12/21 16:18, cgel.zte@gmail.com wrote:
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>
> Fix the following coccicheck review:
> ./drivers/staging/r8188eu/core/rtw_ap.c: 1094: 5-8: Unneeded variable
>
> Remove unneeded variable used to store return value.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
> ---
> drivers/staging/r8188eu/core/rtw_ap.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_ap.c b/drivers/staging/r8188eu/core/rtw_ap.c
> index c78feeb9c862..d103a92ee2f1 100644
> --- a/drivers/staging/r8188eu/core/rtw_ap.c
> +++ b/drivers/staging/r8188eu/core/rtw_ap.c
> @@ -1091,7 +1091,6 @@ u8 ap_free_sta(struct adapter *padapter, struct sta_info *psta,
> int rtw_sta_flush(struct adapter *padapter)
> {
> struct list_head *phead, *plist;
> - int ret = 0;
None of the existing callers check the return value of this function.
Make it void, please.
With regards,
Pavel Skripkin
next prev parent reply other threads:[~2021-11-12 16:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 13:18 cgel.zte
2021-11-12 16:31 ` Pavel Skripkin [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-11-10 12:22 cgel.zte
2021-11-13 11:14 ` Greg KH
2021-11-09 11:53 cgel.zte
2021-11-09 12:09 ` Pavel Skripkin
2021-11-09 12:18 ` Dan Carpenter
2021-11-09 12:23 ` Pavel Skripkin
2021-11-10 8:12 ` Greg KH
2021-11-02 7:32 cgel.zte
2021-11-02 8:23 ` Pavel Skripkin
2021-11-05 13:41 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afe0a4bb-c6fe-8eeb-6077-dde7839537e9@gmail.com \
--to=paskripkin@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=cgel.zte@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=deng.changcheng@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux@roeck-us.net \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome