From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0F86C433E0 for ; Thu, 11 Feb 2021 11:08:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8630A64E2D for ; Thu, 11 Feb 2021 11:08:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231491AbhBKLIG (ORCPT ); Thu, 11 Feb 2021 06:08:06 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:47097 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229923AbhBKKvw (ORCPT ); Thu, 11 Feb 2021 05:51:52 -0500 Received: from 1.general.cking.uk.vpn ([10.172.193.212]) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lA9Yg-0000EO-CF; Thu, 11 Feb 2021 10:50:50 +0000 Subject: Re: [PATCH][next] media: i2c: imx334: Fix a read of the uninitialized variable ret To: Dan Carpenter , Sakari Ailus Cc: "Paul J . Murphy" , Daniele Alessandrelli , Mauro Carvalho Chehab , Martina Krasteva , Gjorgji Rosikopulos , linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210210190752.146631-1-colin.king@canonical.com> <20210210210303.GE3@paasikivi.fi.intel.com> <20210211104148.GE2696@kadam> From: Colin Ian King Message-ID: Date: Thu, 11 Feb 2021 10:50:49 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210211104148.GE2696@kadam> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/02/2021 10:41, Dan Carpenter wrote: > On Wed, Feb 10, 2021 at 11:03:03PM +0200, Sakari Ailus wrote: >> Hi Colin, >> >> On Wed, Feb 10, 2021 at 07:07:52PM +0000, Colin King wrote: >>> From: Colin Ian King >>> >>> Currently there is a dev_err error message that is printing the >>> error status in variable ret (that has not been set) instead of >>> the correct error status from imx334->reset_gpio. Fix this. >>> >>> Addresses-Coverity: ("Uninitialized scalar variable") >>> Fixes: 9746b11715c3 ("media: i2c: Add imx334 camera sensor driver") >>> >>> Signed-off-by: Colin Ian King >>> --- >>> drivers/media/i2c/imx334.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c >>> index 07e31bc2ef18..f8b1caf26c9b 100644 >>> --- a/drivers/media/i2c/imx334.c >>> +++ b/drivers/media/i2c/imx334.c >>> @@ -790,7 +790,8 @@ static int imx334_parse_hw_config(struct imx334 *imx334) >>> imx334->reset_gpio = devm_gpiod_get_optional(imx334->dev, "reset", >>> GPIOD_OUT_LOW); >>> if (IS_ERR(imx334->reset_gpio)) { >>> - dev_err(imx334->dev, "failed to get reset gpio %d", ret); >>> + dev_err(imx334->dev, "failed to get reset gpio %ld", >>> + IS_ERR_VALUE(imx334->reset_gpio)); > > IS_ERR_VALUE() isn't right. It would always print 1 here. It should > just be PTR_ERR(). > > IS_ERR_VALUE() is like IS_ERR() but for when you're storing memory > addresses in an unsigned long variable. get_unmapped_area(), for > example, returns unsigned longs. > > regards, > dan carpenter > Thanks, that was a brown paper bug mistake for sure :-/ Colin