From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA7612F616B for ; Wed, 24 Jun 2026 15:27:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782314843; cv=none; b=bqD3V+5ylhOe46NV09HZ8yD3FgNJKc2uOLDRW/MR45MopdryDWBiWMq1w60Pgkm3JSheH7TDv+1ZGb/szjqfv3ktzZOSd8EziKcNtTBBAwEneAEWBW3BNAUjkd2HtF5ptZm0H/ZXnpR6AiAy2rdCK3pJxdnHe63uudUNiE1C9l8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782314843; c=relaxed/simple; bh=zQlht0IsyQB1oNhNfYXgYgQbV1Y7rokfYO480Nk79qY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KLEZBsohyrzVCDzIdIpI/zSxhV8x38FaOTuytkfY52NTwybI9jGw73WDhQuUZcbMSHb4qq+ja58z8XdyN06kk7s9V1+/Bb+Lb7SNTBl7SfvnQFq2DAEtlF5pC71KFDnxF7/Z52LwioxgaNH1If3ucI+W+sBqMNghmj2dCgyb9ww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=TVI+Qcdp; arc=none smtp.client-ip=209.85.160.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="TVI+Qcdp" Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-43b7e186a0cso590706fac.0 for ; Wed, 24 Jun 2026 08:27:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1782314840; x=1782919640; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Fjq8lD80zO6HiyYMuWH6+pjiwlUb52f+5tf0ovQAwVM=; b=TVI+QcdpMI3gzRx7l3JLLLB5sQGg3piLry+GcCTA5BxoD+KBsB3tPvy4HxUpIHxhqK wSlAcvWsHnGKXG03VwM4A5aFP9xiyo+lB2WtFA6yWUS87wNocMowf3EOtiBHwEHcBHdu U2Ir1u4g1w02xirvTNygo+DjlkTI3RSntD7iIes520e35AS00NKB8jtqaccxMrAm+Y8X gC2OQ+gVV1inlg+5U/bPqKBT9KplfjhNOzBOLXjuW16lJdctd0mBgSppV3/9rbPARJh9 H1x4/mi5msywP21t3cglyP/VQjWp+BAVJ4ytVvH+f2VApXP1bAMRz64HIOrf5h/UAlZm iiXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782314840; x=1782919640; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Fjq8lD80zO6HiyYMuWH6+pjiwlUb52f+5tf0ovQAwVM=; b=AvQrbNkmsl7WawxsbZLMoPPoWQ1Fiv+/TI8xUk0k2hJ4aebtbutcEhexoT+bntFmZl Uo4KrAGgpM9jQMCs6Yh6s1d4Qqoz0TD+988we7AoCQ6U9piy1afaRyFQOZyvdN0UCEj5 IMxbBlb8oIsgXv1ZlxjLzslXNbb86JacGxeTGzZXjkZ16+P+Xi/OpkJQZvW1BI2nQRdX 7XPRrKUEVQJh3+CdvGRv/dPt32yDsWEEklTVxsGZms7OwUGK8LN3zXNab89Bo62VNCv3 0u/SUCfsuCdClFM2eWcIvLlUb6zdvlboYtPhWRF1XqlX/vaZhQc6dvMMpkDnw8646W7k US1Q== X-Forwarded-Encrypted: i=1; AFNElJ9jWN754bqdIubLSS2bEv7y+EJBH8RYmyam/B2UNKpVZj890uyXrP82PFU8Ljh2niVVfuwyrnDV3Q5GZ9M=@vger.kernel.org X-Gm-Message-State: AOJu0YxO4+bJ2A+B4MljALlsWQLQi0j26XZva8idX1e/qUV/bKgO6s67 ITUW7i9DQ//7AiXQ0nk/E0SPSF767nzgPu80QcozBci91iJLhY+dIJvhglmyJ9Garxo= X-Gm-Gg: AfdE7cl0FInIWxs3wZY1hIAVfvs99lK9k0EcXDdPRq2JPO+gQeLXJNto4zXkYMc8jju yWUktv//TY7Fr1bGvxETTB6sTlmGbdtmXjxXt6ar+FvJLt5hz3ngfbplQyhzaKdQGZphbp7eJDV ivAx8wm3kOUbZahkDslAk1xBFCY9Zf73vw4q//S9IeW/iqruKweqxTehJVxw4HVg3M7DnZ19hb5 OflLh0iqtYiz3QoYPTuhpMdifodIhysMlwU49pbWKTVAxJ6eBdIp9IBoy3iQB7LYpnjkafDsP6/ t2NSGMfGMZp0PCuiZx38H9qEaD81qKrffHDUc4KDCWyU0ptpGTjjMipy5z57WMJnaqtI0HIprBL MS5E1QtT1e1LPZE4L68aBnNIKZG2BoCPFiABrbTOu4ndPkYqNo0n1jljcbZmjXuB0z8P/m6rjbC c+SiD4PZ6bdizwZtbkmHyGY6FQ0pYC+WMD0+7v52iuuVrYWIX9LQpPHHA3bp2oOc4= X-Received: by 2002:a05:6871:7991:b0:42c:4c8:4a5a with SMTP id 586e51a60fabf-447dce9b4a5mr2572915fac.28.1782314840687; Wed, 24 Jun 2026 08:27:20 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:68dc:b788:b3ac:e34e? ([2600:8803:e7e4:500:68dc:b788:b3ac:e34e]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4472ec6065esm10933021fac.4.2026.06.24.08.27.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jun 2026 08:27:20 -0700 (PDT) Message-ID: Date: Wed, 24 Jun 2026 10:27:19 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] iio: dac: dac8163: Add driver for DAC8163 To: Lukas , Andy Shevchenko Cc: Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org References: <20260623-dac8163-work-v1-0-5b508158faa0@gmx.net> <20260623-dac8163-work-v1-1-5b508158faa0@gmx.net> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/24/26 9:47 AM, Lukas wrote: > Thanks a lot for all the comments. > > On Tue, Jun 23, 2026 at 10:39:23PM +0300, Andy Shevchenko wrote: > >>> + dev_dbg(dev, "%s: val=%d val2=%d\n", __func__, val, val2); Trimming down the reply is good, but in this case, it would have been helpful to leave a bit more context. I usually keep the full function in a reply to have enough context if it isn't too long. >> >> No. Is it RFC? PoC? Or production-ready? If not the latter, come when it will >> be production-ready. >> > > I will remove the debug print. I tried my best to make this driver production-ready. > I saw that other drivers also have similar debug messages so i didnt This one jumped out to both of us as odd because of the __func__ and the fact that it is in a very common operation (raw write). Usually debug is for catching odd things that happen, not normal things. > remove it after my first tests and thought it is ok to leave it in > there. My intention was to try to apply the suggestions and comments i > get and send a second revision. Do you think thats the right way? Yes, you are doing it right. For a new driver like this, it is best to wait about a week before submitting the next revision to give ample time for review. Your replies so far where you think a suggestion was wrong or have asked for clarification are spot on as to what we expect for the review process.