From: Dan Carpenter <dan.carpenter@linaro.org>
To: Michal Simek <michal.simek@amd.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] clocksource/drivers/timer-cadence-ttc: fix a signedness bug in probe()
Date: Tue, 6 Jun 2023 12:39:24 +0300 [thread overview]
Message-ID: <afedc49d-7a6b-40ea-acee-744d92718f3e@kadam.mountain> (raw)
In-Reply-To: <0cc62a35-8dcc-01ad-8db1-e9a1ee2f4e4b@amd.com>
On Tue, Jun 06, 2023 at 11:26:20AM +0200, Michal Simek wrote:
>
>
> On 6/6/23 10:15, Dan Carpenter wrote:
> > Make the "irq" variable signed so the error handling can work.
>
> urq_of_parse_and_map returns unsigned type.
>
Ugh... You're right. This is one of those return zero on error IRQ
functions.
> include/linux/of_irq.h:118:extern unsigned int irq_of_parse_and_map(struct
> device_node *node, int index);
>
> instead of this condition should be fixed to
>
> irq = irq_of_parse_and_map(timer, 1);
> if (!irq) {
> ...
>
Sure. I can resend.
regards,
dan carpenter
prev parent reply other threads:[~2023-06-06 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 8:15 Dan Carpenter
2023-06-06 9:26 ` Michal Simek
2023-06-06 9:39 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afedc49d-7a6b-40ea-acee-744d92718f3e@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®