From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752803AbdB1NdP (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Feb 2017 08:33:15 -0500
Received: from mx1.redhat.com ([209.132.183.28]:43038 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752620AbdB1NdM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Feb 2017 08:33:12 -0500
Subject: Re: [PATCH v2] mfd: Add Cherrytrail WhiskeyCove PMIC driver
To: Andy Shevchenko <andy.shevchenko@gmail.com>
References: <20170227213853.8750-1-hdegoede@redhat.com>
 <CAHp75Vecem11Fp58+u9dWkA4OJG0UzZakGxzy6YtNpawDsMkGg@mail.gmail.com>
Cc: Andy Shevchenko <andy@infradead.org>, Lee Jones <lee.jones@linaro.org>,
        Takashi Iwai <tiwai@suse.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Bin Gao <bin.gao@intel.com>,
        Felipe Balbi <felipe.balbi@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
From: Hans de Goede <hdegoede@redhat.com>
Message-ID: <aff1cc24-819e-0936-2e5f-cdfd452220f0@redhat.com>
Date: Tue, 28 Feb 2017 14:23:38 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <CAHp75Vecem11Fp58+u9dWkA4OJG0UzZakGxzy6YtNpawDsMkGg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 28 Feb 2017 13:23:43 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 27-02-17 23:06, Andy Shevchenko wrote:
> On Mon, Feb 27, 2017 at 11:38 PM, Hans de Goede <hdegoede@redhat.com> wrote:
>> Add mfd driver for Intel CHT WhiskeyCove PMIC, based on various non
>> upstreamed CHT WhiskeyCove PMIC patches. For now this just adds a minimal
>> version which implements just enough to get ACPI PMIC opregion support to
>> work, so that suspend/resume will work on machines with this PMIC.
>>
>> Cc: Bin Gao <bin.gao@intel.com>
>> Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
>> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> Changes in v2:
>
> You were too fast. Please, give a time for reviewers to do their job.
>
> So, please address comments per v2 first.
>
>> -Since this uses plain mfd and not the intel_soc_pmic stuff give it
>>  its own Kconfig and allow this to be built as a module
>
>> -Add missing #include <acpi/acpi_bus.h>
>
> Do we need it explicitly included?

I was trying to fix a kbuild bot error with this
(Takashi has it on a topic-branch), but it only made it
worse. so I'm dropping this again for v3, instead adding
"depends on ACPI" to the Kconfig for this, which will
hopefully really fix the kbuild bot errors.

Regards,

Hans