From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f177.google.com (mail-dy1-f177.google.com [74.125.82.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB23230215A for ; Thu, 11 Jun 2026 05:07:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781154461; cv=none; b=KRmjnEZ3bbhrsyDQuLtvLx/xFg3qHGF+WZCmApJoGFOAAL236N9/QJKfq/anzkJ0kHcFv7kacZleyYmylnyt+Kd4pFyfMeoCI7E1AbU/KlZvytbP4lhqOt/sUvVuBnLN7r50rWt1b5+MpfMXo/05GeaWhdm+aldoRkL3t3qVWd4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781154461; c=relaxed/simple; bh=RpCJqOkiv1DLPrXO2op820j5d34x1aL3ItTtqyK2uIM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Rq4O+Tmx9KzZBArwVwfzKX3BMQqmmN9CqfTII7tnNPJyCxi+OY67EMmDBAXu6NTT1dbLWU59oBUjXP0mlmd4zLAEOFUM+DHy8N3F+1mBKhf85Z0Tw7ugaZKru/GxonIfbjdCX7th21zx7haGmwnSHbjTPY908MsrN89kYkziP2A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Iy8JRuwF; arc=none smtp.client-ip=74.125.82.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Iy8JRuwF" Received: by mail-dy1-f177.google.com with SMTP id 5a478bee46e88-304ddfcf72cso8069070eec.0 for ; Wed, 10 Jun 2026 22:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781154456; x=1781759256; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=k8/LBM2ge9TbM3J9QaUuiG08J7fVuFMBLdE+TcGBJNo=; b=Iy8JRuwFqsg8yTOS7vqP4Gl+ND4fTjbd3T6KMRl+RGnFrIx1EWT8jmZtUVpYSspr2g J+0HYgNjk+VQonCSi0HW0NhXmurSWoHMRYvLKtzND7e5AaL8mpGIgQG1dj4ZsqEbnX5i AeekVfZ6TmQFvKkUGcON58vC9TOv/NpcrtuPiF2dWvpPxn2nR+nHhGYLMs+2X+YfHSuY VO18pFcgBdnp/yMItLJgeGnzAqHpWBrTSxQT7FJCgeQYmRgP7QvRR91gUGrjKNtzwtXX Dn9CFoxFePPUTMyHCRezSuc297WWqEhE4SI+E73KexYCUGdUygV8CG3hpb1Z8RVrADcL Gshw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781154456; x=1781759256; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=k8/LBM2ge9TbM3J9QaUuiG08J7fVuFMBLdE+TcGBJNo=; b=QeZrbEMaPA9xH8yNkBcRDrRXXsos7Ldyro3/1QB32tB/w+MCEV04A3bOI11UTe13xI nfTaFARtTGlVatBWtlFn+PmP19vbPFxZEWvErHHxRt+t8wramRfRP3v8MiF/uEykeBe9 7V/jvGOG2ktza/Zra/rAD9mcH7va/CbtLmYckEoeFYPifLF6OrNCVWjSX4Oh7+sg0h0l QdNf1YNrdqydDWf3o2gm8bN/YMPNOdf3yFvCiQGmWDnVaQt+DrR9kv0BO7IVnGgZMd7J y7TWi5T1hxyEjae3emMgE0BHNAgpbw5heiEDDXb3CLDgmTQZlRHdPwsoV9RLQbSww/pm eEUg== X-Forwarded-Encrypted: i=1; AFNElJ/fA77bjUTFMs5hqr/8Cv6sxJDtmoHtdsDyBHF7V55vFBKaIPRgPRMorw+GSzssFdtixdfCh2BpililfrI=@vger.kernel.org X-Gm-Message-State: AOJu0YzLn5lTaIbBKQVlH/bmEqM5u1acNCPDkaevLEawAZM76X06zUTr 964tkqYoeF5GCY3ce5Fj0CzE50zCrfhEvhX4YE1jj9SR5+T7b6Q7zTA8 X-Gm-Gg: Acq92OHeRRAs7PZ2cYICMJIUipIFYBUoT9qxrWtuzlmPFeFfW2S7oelDQvwcQFnyss3 9ibEpk2dpFGUpEDvQU8EC1cl1cLIYnUYoidnCeOz8CZm49mfBsQFut2mbIbJLSp8DtUPCYzTKtQ nNZzMsJ1h107UqJpuW3G2ht/R0Xx2Lm2SKVJNKkMopVf4/f7hrAmT70jxqfPk9lbzHQaZsREjgf RKoFD/6UfvTWk4jwwiB3VIGYs6lXwRRRTaTupcDBpKJB946IGvB3mklkw8vp7JKZ6Swhajx9qX9 rL5nDNtjJHSEMjtgpypPlZU1wkBekYi/RaOUrfaGNzFywbbZFMy0nKuQa7gESMIDJTLuM7SfSsD cUazB7KHnWIx1Ex7Bxl2GSMXnfI6DpBCVp+MR52U1oJzIb9ULZEW5hdtwo3XjAhJPLN1NJ74e/m RpXKFzRdzpmh4mlhOEaI8KmmQ8/OV/2q2MJ8oityL/BOV8vbQ= X-Received: by 2002:a05:693c:83d4:20b0:304:e6f8:7cc6 with SMTP id 5a478bee46e88-30804a0efeamr564147eec.19.1781154455677; Wed, 10 Jun 2026 22:07:35 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30806c48b52sm736666eec.12.2026.06.10.22.07.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 22:07:35 -0700 (PDT) Sender: Guenter Roeck Date: Wed, 10 Jun 2026 22:07:34 -0700 From: Guenter Roeck To: Pei Xiao Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, cryolitia@uniontech.com Subject: Re: [PATCH v2] hwmon: (gpd-fan) Reject EC PWM value 0 as invalid Message-ID: References: <1c2ffa0d832ae3a74f6d4ffa7cc7b7e6cced69e3.1781138459.git.xiaopei01@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1c2ffa0d832ae3a74f6d4ffa7cc7b7e6cced69e3.1781138459.git.xiaopei01@kylinos.cn> On Thu, Jun 11, 2026 at 08:44:14AM +0800, Pei Xiao wrote: > The EC firmware is expected to return values in [1, pwm_max]. A read of 0 > is illegal and would cause underflow in the conversion formula. Explicitly > check for 0 and return -EIO. > > Signed-off-by: Pei Xiao Applied. Thanks, Guenter