From: James Clark <james.clark@linaro.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Howard Chu <howardchu95@gmail.com>,
Athira Jajeev <atrajeev@linux.vnet.ibm.com>,
Michael Petlan <mpetlan@redhat.com>,
Veronika Molnarova <vmolnaro@redhat.com>,
Dapeng Mi <dapeng1.mi@linux.intel.com>,
Thomas Richter <tmricht@linux.ibm.com>,
Ilya Leoshkevich <iii@linux.ibm.com>,
Colin Ian King <colin.i.king@gmail.com>,
Weilin Wang <weilin.wang@intel.com>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v1 5/8] perf test: Tag parallel failing shell tests with "(exclusive)"
Date: Fri, 11 Oct 2024 11:29:34 +0100 [thread overview]
Message-ID: <affbe9b6-4d27-47d7-8767-9531f92b3d32@linaro.org> (raw)
In-Reply-To: <c32f8c46-3895-49e0-a837-98859345039b@linaro.org>
On 11/10/2024 11:01 am, James Clark wrote:
>
>
> On 11/10/2024 8:35 am, Ian Rogers wrote:
>> Some shell tests compete for resources and so can't run with other
>> tests, tag such tests. The "(exclusive)" stems from shared/exclusive
>> to describe how the tests run as if holding a lock.
>>
>> Signed-off-by: Ian Rogers <irogers@google.com>
>> ---
>> tools/perf/tests/shell/perftool-testsuite_report.sh | 2 +-
>> tools/perf/tests/shell/record.sh | 2 +-
>> tools/perf/tests/shell/record_lbr.sh | 2 +-
>> tools/perf/tests/shell/record_offcpu.sh | 2 +-
>> tools/perf/tests/shell/stat_all_pmu.sh | 2 +-
>> tools/perf/tests/shell/test_intel_pt.sh | 2 +-
>> tools/perf/tests/shell/test_stat_intel_tpebs.sh | 2 +-
>> 7 files changed, 7 insertions(+), 7 deletions(-)
>>
>
> The following ones would also need to be marked as exclusive, not sure
> if you can include those here or you want me to send a patch:
>
> tools/perf/tests/shell/coresight/asm_pure_loop.sh
> tools/perf/tests/shell/coresight/memcpy_thread_16k_10.sh
> tools/perf/tests/shell/coresight/thread_loop_check_tid_10.sh
> tools/perf/tests/shell/coresight/thread_loop_check_tid_2.sh
> tools/perf/tests/shell/coresight/unroll_loop_thread_10.sh
> tools/perf/tests/shell/test_arm_coresight.sh
> tools/perf/tests/shell/test_arm_coresight_disasm.sh
> tools/perf/tests/shell/test_arm_spe.sh
>
> In theory all tests using probes would also need to be exclusive because
> they install and delete probes globally. In practice I don't think I saw
> any failures, whether that's just luck or because of some skips I'm not
> sure.
>
> And this one fails consistently in parallel mode on Arm:
>
> 22: Number of exit events of a simple workload
> : FAILED!
>
> But it's a C test so I assume there isn't an exclusive mechanism to skip
> it? It doesn't look like it should be affected though, so maybe we could
> leave it failing as a real bug.
>
Oh I see it says in the cover letter it can be set for C tests. But can
that be done through all the existing TEST_CASE() etc macros?
next prev parent reply other threads:[~2024-10-11 10:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 7:35 [PATCH v1 0/8] Run tests in parallel showing number of tests running Ian Rogers
2024-10-11 7:35 ` [PATCH v1 1/8] tools subcmd: Add non-waitpid check_if_command_finished() Ian Rogers
2024-10-11 7:35 ` [PATCH v1 2/8] perf test: Display number of remaining tests Ian Rogers
2024-10-11 7:35 ` [PATCH v1 3/8] perf test: Reduce scope of parallel variable Ian Rogers
2024-10-11 7:35 ` [PATCH v1 4/8] perf test: Avoid list test blocking on writing to stdout Ian Rogers
2024-10-11 7:35 ` [PATCH v1 5/8] perf test: Tag parallel failing shell tests with "(exclusive)" Ian Rogers
2024-10-11 10:01 ` James Clark
2024-10-11 10:29 ` James Clark [this message]
2024-10-11 16:52 ` Ian Rogers
2024-10-11 7:35 ` [PATCH v1 6/8] perf test: Add a signal handler around running a test Ian Rogers
2024-10-11 7:35 ` [PATCH v1 7/8] perf test: Run parallel tests in two passes Ian Rogers
2024-10-11 7:35 ` [PATCH v1 8/8] perf test: Make parallel testing the default Ian Rogers
2024-10-11 10:03 ` [PATCH v1 0/8] Run tests in parallel showing number of tests running James Clark
2024-10-11 16:26 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=affbe9b6-4d27-47d7-8767-9531f92b3d32@linaro.org \
--to=james.clark@linaro.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=colin.i.king@gmail.com \
--cc=dapeng1.mi@linux.intel.com \
--cc=howardchu95@gmail.com \
--cc=iii@linux.ibm.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tmricht@linux.ibm.com \
--cc=vmolnaro@redhat.com \
--cc=weilin.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®