From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97C4B1990C9 for ; Mon, 6 Jan 2025 07:09:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736147384; cv=none; b=U5h0UW7JeltBSvh/9lo874I8bGTuDsPI0qmcr+RneJX75La3tSxI9q4GcNw8k8MX590W0luWoOCgTbQ3q5XYdJA8p+52qPgHwoWuJu8wC6r36J+iLg/lvw0BOi5KK6OO1iTdUBOttLw+jf24+/STC+MqV/A8jvuhklTCbUlBIlI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736147384; c=relaxed/simple; bh=ztlXVC7yO7hJz6FC0eG6OR5kDNx4yBqxg+5Cteup9nU=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=oUnCGUfeN/ayAk3Xdv3j/nz3Ju9o1/nJgtZw6dPKtNmlgLzHfx4bCT/J1i5SmWsWBlD8yyjOV3A0BfkgdVFi9KCW4uzyiacoMSox3Afki1gihsAWciTRe3q1JlEvLSuonh+5+5lMnNiU7JQslsMIXrh1REBDScA1UjDiNxPE9HQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=P5Xbm9a0; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="P5Xbm9a0" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-43626213fffso87066055e9.1 for ; Sun, 05 Jan 2025 23:09:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736147380; x=1736752180; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=2WnamjGhXvBMgL8bchnikXP7xxUqq1nXsMC1Inb9MrU=; b=P5Xbm9a01SN6zEzyriClk/GsJe8vci19GSpNalaZ078jMGJaYM6/6RqkSPPxUW73D/ moQq0XmXrIaTnASmpOdV+AogXX0xaxeFhKzeizgvxsDfvc69vWfFZWcOLxhwLRQeV9sH RvYTf7x2MRf3ZA2aeXg2Y9DN0j4/6AGseQFcU5Wrpi+BGLemfXCHIGhDgaEgLZ5JGEcR CMt3Por92DL7KTeyzd3Q0NN1xVXVtqg5DqAVmleEVnel/UGdf3of0vmBuTGPxeu7vPTg 99wgNT4dxYTwAKf64Otb1vahWRFEeFmbiCylzTTrRuf5nElXh/BfWK3UKtdyDDWPV1GI kFWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736147380; x=1736752180; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2WnamjGhXvBMgL8bchnikXP7xxUqq1nXsMC1Inb9MrU=; b=vRE56Z0CzCIWJN6SSPXGgx+l8vhzO2tsWAk3JjC7qpFjJvuA9xkH0WTQL22ZFULfoB ysjV/krxCNH7kRQhH8Gdys7Su2mW4LQxVqYLXATtI8ZQkSGyZzvNe8XrKp2HeCYJcXCk KIHs/Jrd8L+W9pwfhECG6CFUuqgP8js5bcbNBD1LXN3ylYBUh+9xJVcgvXEUkGztPQNZ 4OWdtkuNPSJHvl3NWleYEnJMuh7tKLakJl0TfitIfPefrgCBxvHbUGVweYuzfpuecbM1 Fl/ofuVEdPRScRzosjtFuJhtqXTNxtoQVx8WFnPEjBcNKJ218p2gbg1rRaTOANCQ0Tix leXw== X-Forwarded-Encrypted: i=1; AJvYcCUX0JciIILdt4U1yFklKNdXALJ3PFX0k3mmyhQUgpqmv3ZRFfq7usnaUCHO3J4NkWVTIyPFKYchyCCSGvg=@vger.kernel.org X-Gm-Message-State: AOJu0YxviEBmNvoMEJZsblyujgz+UzwKCKVLlG/xHrkdjnob+4ZRdjTc F7OhyO9gfC0y/wSx45olfEpakMo2AMWAV+B8U9qh6GyTEzXpF7lWj6KYbatNt5lh0cGqb/mPzHJ l X-Gm-Gg: ASbGnctuuEKFmvLxF3Zn8b5S03PRCn7NKZrYmnIZLmef4eDihiQC1GUaipqLGu2GtR6 qKFm1sLOPsBr85d3KppWr+07hK/G4DRzVKshlqMKQ5m22g2rQL54514wWuGBDcWC5dn6PmDF6Tk hqoMZN1DAp1Upi/eOiqygSY4qecGMfde6k9AZ0m2zdOkuIYUCu1SUvZe8c3/gokOpq2HMGqprsg kp+PGHcJuMO3gXXIoAnCCsLppjL9WZxymKmgOO6EUZeYDXlWbHX3D4z7YbIkA== X-Google-Smtp-Source: AGHT+IEGyL0miqJbyxWnjUMeL4aDYo1IwQVWlwe6GF4LurZRepayXVomG0o84ovgMFTmNmQj/TLf6g== X-Received: by 2002:a05:6000:2a5:b0:386:3d27:b4f0 with SMTP id ffacd0b85a97d-38a1a221da1mr49526089f8f.14.1736147379663; Sun, 05 Jan 2025 23:09:39 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c8472casm47923323f8f.45.2025.01.05.23.09.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jan 2025 23:09:39 -0800 (PST) Date: Mon, 6 Jan 2025 10:09:35 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Dave Penkler Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org Subject: drivers/staging/gpib/agilent_82357a/agilent_82357a.c:1381 agilent_82357a_attach() warn: inconsistent returns 'global &agilent_82357a_hotplug_lock'. Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 8faabc041a001140564f718dabe37753e88b37fa commit: 165e8cc3cfec9ef51f3376b0d49b115294f34f3b staging: gpib: Add KBUILD files for GPIB drivers config: i386-randconfig-141-20241220 (https://download.01.org/0day-ci/archive/20241221/202412210143.WJhYzXfD-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202412210143.WJhYzXfD-lkp@intel.com/ smatch warnings: drivers/staging/gpib/agilent_82357a/agilent_82357a.c:1381 agilent_82357a_attach() warn: inconsistent returns 'global &agilent_82357a_hotplug_lock'. vim +1381 drivers/staging/gpib/agilent_82357a/agilent_82357a.c 4c41fe886a56c5b Dave Penkler 2024-09-18 1306 static int agilent_82357a_attach(gpib_board_t *board, const gpib_board_config_t *config) 4c41fe886a56c5b Dave Penkler 2024-09-18 1307 { 4c41fe886a56c5b Dave Penkler 2024-09-18 1308 int retval; 4c41fe886a56c5b Dave Penkler 2024-09-18 1309 int i; 4c41fe886a56c5b Dave Penkler 2024-09-18 1310 unsigned int product_id; 4c41fe886a56c5b Dave Penkler 2024-09-18 1311 struct agilent_82357a_priv *a_priv; 4c41fe886a56c5b Dave Penkler 2024-09-18 1312 struct usb_device *usb_dev; 4c41fe886a56c5b Dave Penkler 2024-09-18 1313 4c41fe886a56c5b Dave Penkler 2024-09-18 1314 if (mutex_lock_interruptible(&agilent_82357a_hotplug_lock)) 4c41fe886a56c5b Dave Penkler 2024-09-18 1315 return -ERESTARTSYS; 4c41fe886a56c5b Dave Penkler 2024-09-18 1316 4c41fe886a56c5b Dave Penkler 2024-09-18 1317 retval = agilent_82357a_allocate_private(board); 4c41fe886a56c5b Dave Penkler 2024-09-18 1318 if (retval < 0) { 4c41fe886a56c5b Dave Penkler 2024-09-18 1319 mutex_unlock(&agilent_82357a_hotplug_lock); 4c41fe886a56c5b Dave Penkler 2024-09-18 1320 return retval; 4c41fe886a56c5b Dave Penkler 2024-09-18 1321 } 4c41fe886a56c5b Dave Penkler 2024-09-18 1322 a_priv = board->private_data; 4c41fe886a56c5b Dave Penkler 2024-09-18 1323 for (i = 0; i < MAX_NUM_82357A_INTERFACES; ++i) { 4c41fe886a56c5b Dave Penkler 2024-09-18 1324 if (agilent_82357a_driver_interfaces[i] && 4c41fe886a56c5b Dave Penkler 2024-09-18 1325 !usb_get_intfdata(agilent_82357a_driver_interfaces[i]) && 4c41fe886a56c5b Dave Penkler 2024-09-18 1326 agilent_82357a_device_match(agilent_82357a_driver_interfaces[i], config)) { 4c41fe886a56c5b Dave Penkler 2024-09-18 1327 a_priv->bus_interface = agilent_82357a_driver_interfaces[i]; 4c41fe886a56c5b Dave Penkler 2024-09-18 1328 usb_set_intfdata(agilent_82357a_driver_interfaces[i], board); 4c41fe886a56c5b Dave Penkler 2024-09-18 1329 usb_dev = interface_to_usbdev(a_priv->bus_interface); 4c41fe886a56c5b Dave Penkler 2024-09-18 1330 dev_info(&usb_dev->dev, 4c41fe886a56c5b Dave Penkler 2024-09-18 1331 "bus %d dev num %d attached to gpib minor %d, agilent usb interface %i\n", 4c41fe886a56c5b Dave Penkler 2024-09-18 1332 usb_dev->bus->busnum, usb_dev->devnum, board->minor, i); 4c41fe886a56c5b Dave Penkler 2024-09-18 1333 break; 4c41fe886a56c5b Dave Penkler 2024-09-18 1334 } 4c41fe886a56c5b Dave Penkler 2024-09-18 1335 } 4c41fe886a56c5b Dave Penkler 2024-09-18 1336 if (i == MAX_NUM_82357A_INTERFACES) { 4c41fe886a56c5b Dave Penkler 2024-09-18 1337 mutex_unlock(&agilent_82357a_hotplug_lock); 4c41fe886a56c5b Dave Penkler 2024-09-18 1338 pr_err("No Agilent 82357 gpib adapters found, have you loaded its firmware?\n"); 4c41fe886a56c5b Dave Penkler 2024-09-18 1339 return -ENODEV; 4c41fe886a56c5b Dave Penkler 2024-09-18 1340 } 4c41fe886a56c5b Dave Penkler 2024-09-18 1341 product_id = le16_to_cpu(interface_to_usbdev(a_priv->bus_interface)->descriptor.idProduct); 4c41fe886a56c5b Dave Penkler 2024-09-18 1342 switch (product_id) { 4c41fe886a56c5b Dave Penkler 2024-09-18 1343 case USB_DEVICE_ID_AGILENT_82357A: 4c41fe886a56c5b Dave Penkler 2024-09-18 1344 a_priv->bulk_out_endpoint = AGILENT_82357A_BULK_OUT_ENDPOINT; 4c41fe886a56c5b Dave Penkler 2024-09-18 1345 a_priv->interrupt_in_endpoint = AGILENT_82357A_INTERRUPT_IN_ENDPOINT; 4c41fe886a56c5b Dave Penkler 2024-09-18 1346 break; 4c41fe886a56c5b Dave Penkler 2024-09-18 1347 case USB_DEVICE_ID_AGILENT_82357B: 4c41fe886a56c5b Dave Penkler 2024-09-18 1348 a_priv->bulk_out_endpoint = AGILENT_82357B_BULK_OUT_ENDPOINT; 4c41fe886a56c5b Dave Penkler 2024-09-18 1349 a_priv->interrupt_in_endpoint = AGILENT_82357B_INTERRUPT_IN_ENDPOINT; 4c41fe886a56c5b Dave Penkler 2024-09-18 1350 break; 4c41fe886a56c5b Dave Penkler 2024-09-18 1351 default: 4c41fe886a56c5b Dave Penkler 2024-09-18 1352 pr_err("bug, unhandled product_id in switch?\n"); mutex_unlock(&agilent_82357a_hotplug_lock); before returning. 4c41fe886a56c5b Dave Penkler 2024-09-18 1353 return -EIO; 4c41fe886a56c5b Dave Penkler 2024-09-18 1354 } 4c41fe886a56c5b Dave Penkler 2024-09-18 1355 #ifdef RESET_USB_CONFIG 4c41fe886a56c5b Dave Penkler 2024-09-18 1356 retval = agilent_82357a_reset_usb_configuration(board); 4c41fe886a56c5b Dave Penkler 2024-09-18 1357 if (retval < 0) { 4c41fe886a56c5b Dave Penkler 2024-09-18 1358 mutex_unlock(&agilent_82357a_hotplug_lock); 4c41fe886a56c5b Dave Penkler 2024-09-18 1359 return retval; 4c41fe886a56c5b Dave Penkler 2024-09-18 1360 } 4c41fe886a56c5b Dave Penkler 2024-09-18 1361 #endif 4c41fe886a56c5b Dave Penkler 2024-09-18 1362 retval = agilent_82357a_setup_urbs(board); 4c41fe886a56c5b Dave Penkler 2024-09-18 1363 if (retval < 0) { 4c41fe886a56c5b Dave Penkler 2024-09-18 1364 mutex_unlock(&agilent_82357a_hotplug_lock); 4c41fe886a56c5b Dave Penkler 2024-09-18 1365 return retval; 4c41fe886a56c5b Dave Penkler 2024-09-18 1366 } 4c41fe886a56c5b Dave Penkler 2024-09-18 1367 4c41fe886a56c5b Dave Penkler 2024-09-18 1368 timer_setup(&a_priv->bulk_timer, agilent_82357a_timeout_handler, 0); 4c41fe886a56c5b Dave Penkler 2024-09-18 1369 4c41fe886a56c5b Dave Penkler 2024-09-18 1370 board->t1_nano_sec = 800; 4c41fe886a56c5b Dave Penkler 2024-09-18 1371 4c41fe886a56c5b Dave Penkler 2024-09-18 1372 retval = agilent_82357a_init(board); 4c41fe886a56c5b Dave Penkler 2024-09-18 1373 4c41fe886a56c5b Dave Penkler 2024-09-18 1374 if (retval < 0) { 4c41fe886a56c5b Dave Penkler 2024-09-18 1375 mutex_unlock(&agilent_82357a_hotplug_lock); 4c41fe886a56c5b Dave Penkler 2024-09-18 1376 return retval; 4c41fe886a56c5b Dave Penkler 2024-09-18 1377 } 4c41fe886a56c5b Dave Penkler 2024-09-18 1378 4c41fe886a56c5b Dave Penkler 2024-09-18 1379 pr_info("%s: attached\n", __func__); 4c41fe886a56c5b Dave Penkler 2024-09-18 1380 mutex_unlock(&agilent_82357a_hotplug_lock); 4c41fe886a56c5b Dave Penkler 2024-09-18 @1381 return retval; 4c41fe886a56c5b Dave Penkler 2024-09-18 1382 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki