From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751552AbdBXBg1 (ORCPT ); Thu, 23 Feb 2017 20:36:27 -0500 Received: from smtp.domeneshop.no ([194.63.252.55]:54968 "EHLO smtp.domeneshop.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751242AbdBXBg0 (ORCPT ); Thu, 23 Feb 2017 20:36:26 -0500 Subject: Re: [PATCH 0/3] drm/tinydrm: Fix compiler warnings To: dri-devel@lists.freedesktop.org References: <20170223132957.2839-1-noralf@tronnes.org> Cc: linux-kernel@vger.kernel.org, Dave Airlie From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Message-ID: Date: Fri, 24 Feb 2017 02:36:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20170223132957.2839-1-noralf@tronnes.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I see that I forgot cc'ing Dave Airlie on this, and I just realised that the backlight problem isn't just a warning, but it actually causes a build failure if backlight is built as a module. I missed this in my hurry to get this out the door, sorry. Den 23.02.2017 14.29, skrev Noralf Trønnes: > Dave pulled tinydrm yesterday which triggered some compiler warnings: > > Dave Airlie: > drivers/gpu/drm/tinydrm/mipi-dbi.c: In function ‘mipi_dbi_debugfs_command_write’: > drivers/gpu/drm/tinydrm/mipi-dbi.c:905:8: warning: ‘cmd’ may be used uninitialized in this function [-Wmaybe-uninitialized] > ret = mipi_dbi_command_buf(mipi, cmd, parameters, i); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > I didn't see this on gcc 4.8, but it showed up when I used gcc 6.2. > > kbuild test robot: > [drm:drm-next 1199/1208] drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c:198:26: error: redefinition of 'tinydrm_of_find_backlight' > > kbuild test robot: > drivers/gpu/drm/tinydrm/mipi-dbi.c: In function 'mipi_dbi_typec1_command': >>> drivers/gpu/drm/tinydrm/mipi-dbi.c:65:20: warning: field width specifier '*' expects argument of type 'int', but argument 5 has type 'size_t {aka long unsigned int}' [-Wformat=] > DRM_DEBUG_DRIVER("cmd=%02x, par=%*ph\n", cmd, len, data); \ > ^ > include/drm/drmP.h:228:40: note: in definition of macro 'DRM_DEBUG_DRIVER' > drm_printk(KERN_DEBUG, DRM_UT_DRIVER, fmt, ##__VA_ARGS__) > ^~~ >>> drivers/gpu/drm/tinydrm/mipi-dbi.c:671:2: note: in expansion of macro 'MIPI_DBI_DEBUG_COMMAND' > MIPI_DBI_DEBUG_COMMAND(cmd, parameters, num); > ^~~~~~~~~~~~~~~~~~~~~~ > > Noralf. > > > Noralf Trønnes (3): > drm/tinydrm: mipi-dbi: Silence: ‘cmd’ may be used uninitialized > drm/tinydrm: mipi-dbi: Fix field width specifier warning > drm/tinydrm: helpers: Properly fix backlight dependency > > drivers/gpu/drm/tinydrm/mipi-dbi.c | 6 +++--- > include/drm/tinydrm/tinydrm-helpers.h | 19 ------------------- > 2 files changed, 3 insertions(+), 22 deletions(-) > > -- > 2.10.2 >