From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3438466B5B for ; Wed, 6 May 2026 13:54:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778075649; cv=none; b=Lejv0YmwAWqU/s4KxixG0YJSvFhJTqUjnr+bq/Czu2wbwubNYbmwFNkevvW7dKiSkNg0GsOjDaH26ztfAmMxoSp9oVFH2OgGhsm6qxNxMoAzcbLr6OmE4aF/IeVTglljJuTWnXf5xvCsS6TnujUqWtoTowWxv4Syj3eCEi0KjrA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778075649; c=relaxed/simple; bh=6KlB82Gzxw6Ep4hdvTnTO13cUo4z1IlE435VWxqkbhM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e6gz/JH9zvRROlUqh9e3gfF3rEb8RR6nylVX0zVoBga3wD+TwXT+hYfSX/euw5xWsa12WeqPgXCve/oEokiCNGYmImOHDKf1GHImI0gm/7VBZW20sLBGXyFrU7ioEqcxEqNjRQ3wk4X56TtsSFO9lqCVyhP4KR3GW+4X+XBNIoQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=AmC1CSPt; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="AmC1CSPt" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-48a7fe4f40bso69778655e9.0 for ; Wed, 06 May 2026 06:54:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1778075643; x=1778680443; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6KlB82Gzxw6Ep4hdvTnTO13cUo4z1IlE435VWxqkbhM=; b=AmC1CSPtD90l14uOt/dZlSzXuFtzGtRWgvFplLurCwwjAVxJquPNO/vF6nxFvcXfN/ LQSeKVJX5FCRgKX5EGUpi6uemWTBtN69d1arDcoqA23j5iOnahrLtMaJpgHc3B4rRBqB rhaMwMWxO1Vt5KYUFZdq7an9sdYYxoqnwIBh3QlSYvZ5XL3n05psuvqO9stkwbdaxkwp eziocMkxqfwZHH6vUYOKHWQvmQwhAYJif1imJ++9Amdg11Me3fI4VcQS+lg34gvCJ+8H ZAl5S+2GQ8Vt1LKQghlf4oavfmtI961bu9j37Fc4u6x5HpgJMXXa3ANFKAk/mzf77LI9 ui/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778075643; x=1778680443; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6KlB82Gzxw6Ep4hdvTnTO13cUo4z1IlE435VWxqkbhM=; b=CpfdApucANAMgMx3XMlEDIjOWzkZiqE4rrG9mPK03fofqW8R04B9C/qvYEDKPN6D2/ CZCBvG1oAPcHlx8+yB0um2pzCxfIxO8wGoBlXnHW6G5ufwwLw8O/XNxiW/f5RW6woYeU lsf5yPFI7tanLQKVaS91nqiubUxc/heiUUjSCtmHMC+AQ1wq8k8MWQqiez4BYVXOMciO UCljluUpYA01O9Dtc8Fq3Y+9JWBp+vmtq/L+WTaxfs6HsjJkrZJRqpKdNoZ1P+5Odf9c uzB9tdEVq0yzC/XqDHzG6ofFG5EBaK3zO6X3mB+vHYqd5+peTnQZPMtYwma45JpM1YzN qLxg== X-Forwarded-Encrypted: i=1; AFNElJ/c2QFWxYqYF/nNezChL2RMh4MNHvd0H6uFzZCSd5e/UAqm+P9uwTJYX+NvWwxuwnk8BkQMJQmH0hZP8sc=@vger.kernel.org X-Gm-Message-State: AOJu0Yxsj7Ir7J+bawaYuiThLbBm87hpQlASlKc8hND7p5G1Q+Q1uFGb NdVUOPZ1Ibfohmp2vLGjZ3L0vSrD4w5bQyEFSF56rm6/aNQyC68Ac9TEgU2Q0u1XmbI= X-Gm-Gg: AeBDiesszAnYaOlTOVjZWAwfbDcUF5iWEwQFoPVG1Y4tPLGW3SB2PxOK5klfhUVhQUT aE+2k1P5FB25YjUL0Y+A/Yxj0ce2qFGJoGm6yc0bnmtxTqknOZNAhyAIepAGL+NOs+NapCXp9Oa 2lyVg44M7lhriOk++/hcZ7ZH0P6OTu2LBPKEv+ws//YygGFTRoiEyIu0qV6ZVlSNyogKwEzfxSD sVbBQ0BVKm6ICCvHtXKl1yjz1xx1i3a+HgFkrwFO+Hk/jUVRQyC6DVXNDCGENxj0qzyEkgk9+8d vN9dim6to4q+GFe1hczI4nWE7wGYH1GG7GHlLhrNdIFJ1eoFdgVY6n8Ad0U0KUdtnfeX1gAYryk 6w2HxTiYQizJbdT6b8fKULFyCNBopkZS93um7f38fg4xUIOyO0huXKQSV+MOsEXV57VCjFjYUGL +ZZ6CJJQk+j3fZnlA4Qj4ylTGZvfcnNeyHmZ3WXldbIO8PWnmloUglU4YC1NE= X-Received: by 2002:a05:600c:c082:b0:489:6c22:e081 with SMTP id 5b1f17b1804b1-48e51dd3a1bmr46595295e9.0.1778075643420; Wed, 06 May 2026 06:54:03 -0700 (PDT) Received: from localhost.localdomain (nat2.prg.suse.com. [195.250.132.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e530b19adsm17343205e9.3.2026.05.06.06.54.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 06:54:02 -0700 (PDT) Date: Wed, 6 May 2026 15:53:59 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Thadeu Lima de Souza Cascardo Cc: Tejun Heo , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Jonathan Corbet , Shuah Khan , Maarten Lankhorst , Maxime Ripard , Natalie Vock , Tvrtko Ursulin , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org, kernel-dev@igalia.com Subject: Re: [PATCH 0/2] cgroup/dmem: introduce a peak file Message-ID: References: <20260506-dmem_peak-v1-0-8d803eb3449c@igalia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="reykr6qmcqnxtkqn" Content-Disposition: inline In-Reply-To: <20260506-dmem_peak-v1-0-8d803eb3449c@igalia.com> --reykr6qmcqnxtkqn Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH 0/2] cgroup/dmem: introduce a peak file MIME-Version: 1.0 Hello Thadeu. On Wed, May 06, 2026 at 08:58:23AM -0300, Thadeu Lima de Souza Cascardo wrote: > Just like we have memory.peak, introduce a dmem.peak, which uses the > page_counter support for that. >=20 > It can be written to in order to reset the peak, but different from > memory.peak, which expects any write, dmem.peak expects the region name to > be written to it. That region peak is the one that is reset. >=20 > That requires ofp_peak to carry a pointer to the pool that was reset. (It'd be nicer to have generic data in that generic structure, at least some void *priv. But see below.) > Writing a different region name will reset the different region and make > the original region peak get back to its non-reset value. I'm slightly confused by this fds x pool matricity when there's only a single slot in cgroup_file_ctx::cgroup_of_peak. The intended use case is that users should maintain one fd per pool and not mix it up? This stanza would better fit to cgroup-v2.rst proper than the commit message. Or make it simpler and start with non-resettable peak file (like memory.peak had started too) and see how it fares. WDYT? Thanks, Michal --reykr6qmcqnxtkqn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJEEABYKADkWIQRCE24Fn/AcRjnLivR+PQLnlNv4CAUCaftH6xsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMiwyLDIACgkQfj0C55Tb+AgWBgEA78n1QkHtqLX1e7j+HqA5 /0hULtuyP0LvN9r2E3h2FskA/0/p9uNIv1XoJqaVguIXjyHW7Kp9SnAM0puHxrMQ TzMA =pFLa -----END PGP SIGNATURE----- --reykr6qmcqnxtkqn--