From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D405E3F1647 for ; Wed, 6 May 2026 14:34:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778078075; cv=none; b=IAJQ3IjQxNqEBL5q5arSkyvWHxwS0FzkFJmIzuqimHa3w0WUdG497OUnCYLzcXDGJ+iRcIq7IDEWQaSzUD4VGDgzMhTp0E7jY8MZejk99ZpQkmKvbx3+KpBhUHIvfVL41AoA/0dEpQVGIgkEGIMQXveuuubMCVIavZcP00OTw8M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778078075; c=relaxed/simple; bh=pk0SQXMIBv323itTlK6HI/JmGOOs4oiVdYUA/gYIil0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YDknRv9sin6a3XGVM6vNlXUDEuBoAr+9rbFbIaB8fbS31o/Fq0r6B//zDMmdioJCBEgxlxDG6J8pSE7i9RNDX7IOiYSJ/DXTV8mselosJgmjcMvOoluaDGBFBz/HmAQB+8JRznnd1yMNifeIGgeLr1PzGhOicUAvPipOBhgDTgE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HJjcLYIl; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=e3aFkl/o; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HJjcLYIl"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="e3aFkl/o" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778078072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WcZHEpBYmvivsHWsr27bIi5qRmMv5umj0vIx0hIYymo=; b=HJjcLYIlR++1xLi0Gt6zUULZhFAwn1INymoqgsYbVNZkCgs7baHK0/V+kxUAlEtQP3zbB1 73MN1ey7OOc6q57RcUnS4xkCRblI4OTbdTAMt1WZIMhOYf6lovbQ0ZGJSP+zMeC7OAHuI/ U649JOalgV/ff+K4V6uGLqoK5cgWrrc= Received: from mail-yx1-f70.google.com (mail-yx1-f70.google.com [74.125.224.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-261-iiDDiu7EOaWjy88A1_lXHw-1; Wed, 06 May 2026 10:34:31 -0400 X-MC-Unique: iiDDiu7EOaWjy88A1_lXHw-1 X-Mimecast-MFC-AGG-ID: iiDDiu7EOaWjy88A1_lXHw_1778078071 Received: by mail-yx1-f70.google.com with SMTP id 956f58d0204a3-652ddb428beso12591233d50.2 for ; Wed, 06 May 2026 07:34:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778078071; x=1778682871; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=WcZHEpBYmvivsHWsr27bIi5qRmMv5umj0vIx0hIYymo=; b=e3aFkl/oG839JZehdYHQ3RHqBzLCbMYoH5x2o6MyH5hmJGv+TYsYNc4lTL3feydZLF 8+uSyuH3uwUPO0UyGPwy8eWYJ2oUGzR0gXFd7NoBgCEvHLVoPLHjD/RlF0Ct+LBsJDBy jMAZftaic/ruH9Xjr73KB73Mjixtmhp4RRWzGeA/G4xTpWPzEaB2Jjd9e+6AW6TkytjG ZkyqmIoTP1KO2++ZbF7LsFLQzgjW+XJI1pDKS5ubbuv4qgW7ZfJVAoNx6cxUfnjBtHc5 /HW237rpRCLPf6ewpGP1BWz+yVHSdkwpgs5LNN8nmUvfLkwppMJkWRAdVM+vnL2EBn2F vOTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778078071; x=1778682871; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WcZHEpBYmvivsHWsr27bIi5qRmMv5umj0vIx0hIYymo=; b=CRsXnmjSJQHMS+WQKq/BOkyZDbZ3/KFkWRgwX8FfpNrEMWbTLKhqhbx7JJJTsUYT3E Zext1BYqhIr0j1vHiN8TLr53exwVRpbxwlU8gIPzocIJPB508Y0npo436FjrVCd+624w dmv9wYG9DV2WqzYxa/zbYsN/AAaHU9eORMLjUvE1IblpRKAHweL3h85Mg0ElQ8NQ2+nM dJk5lYOZMLrPKbkPCEvxl24OfqmyULaEZ5ImotN3SZ8P4DQqH/st/KG+djk8DDaWDbzX CFXHSdeQeCgSZSvOyu6luejmfQcckabnQsgz9wve8jk17DkBWDBQZAEvqxafNMAp206y HC6A== X-Forwarded-Encrypted: i=1; AFNElJ8SqehiqrAE8Bj+DTU557Yc959x8Gp5j5TrxUx3F6Dr9MhWV39AF3+P+eOVHD6KrgxEfyA60XdWeyhGHlA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5DWt3XZPPq/TKD8hZdO8twyoTYcSJtFT3Gp3km/UutkZbIJXi jMpGdPIBwcI8V17WKq8lP62hTs2/kjmbwcgx67Agld91ZYC+dwsOtK5jzJdoIHhF948d07HpcCE PHkwfoZVYe9ZRdbBx+2Xw8I2n4Rgp7SrZ2gDxkt3KUQmzOol+ofPogPjYOyAS2cKtIg== X-Gm-Gg: AeBDietdW7gDDrg7X3ynCZFvGRgvqjg6VBm42KH0PboYvJP6YTkycwQL8fdKSFhxP/Y k+iPndYKislq4vOb5lfVmAo0yZZ/G6RmeK+DbzecAH3lXOX8XH4VyzaZc7AP5cvkSwynqI/wJl9 ENl8gFnPu9FUNul9VdLbCvLCh3qnHm4/8P0QS8VCHLd6oCvc7mYssvUPdD54qElasa7Q4XXbMqv GvXrYTAXbp4SUe8T2doqAshUHxDgP8cFqw/1YcpINzXNlMIfArB+w1orrjyyVItIPKpDrvmEUyf /WL0efgzKpDeI2mdVPpAD8MLb8Te1AB4LytEtDkkKU34AbpVtKzCG3hv+5tBDi0fTVHV08/gSdp CD0TH0l1uSSet0BgcrL+9rmNnkmwtsR+4UvafESbuAPVKIy8iAdV8WKTjh/yWelkZPZU= X-Received: by 2002:a05:690c:4b87:b0:79f:7972:f89a with SMTP id 00721157ae682-7bdf5e7fc11mr45199907b3.28.1778078070959; Wed, 06 May 2026 07:34:30 -0700 (PDT) X-Received: by 2002:a05:690c:4b87:b0:79f:7972:f89a with SMTP id 00721157ae682-7bdf5e7fc11mr45199337b3.28.1778078070442; Wed, 06 May 2026 07:34:30 -0700 (PDT) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b5391e344fsm201219216d6.12.2026.05.06.07.34.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 07:34:29 -0700 (PDT) Date: Wed, 6 May 2026 10:34:27 -0400 From: Brian Masney To: Krzysztof Kozlowski Cc: Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Tudor Ambarus , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v3 10/15] clk: samsung: acpm: use clk_determine_rate_noop() Message-ID: References: <20260505-clk-determine-rate-noop-v3-0-f3f829fbacdf@redhat.com> <20260505-clk-determine-rate-noop-v3-10-f3f829fbacdf@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.3.1 (2026-03-20) Hi Krzysztof, On Wed, May 06, 2026 at 03:47:33PM +0200, Krzysztof Kozlowski wrote: > On 06/05/2026 02:49, Brian Masney wrote: > > Drop the driver-specific empty determine_rate() function and use the new > > shared clk_determine_rate_noop() helper. > >
> This is a friendly reminder during the review process. > > It looks like you received a tag and forgot to add it. > > ... > > If a tag was not added on purpose, please state in the patch changelog > or cover letter why and what changed. >
> > Last part is important. Sorry I didn't mention that I dropped the existing tags on the cover letter. I felt that it changed enough in this version that I didn't feel comfortable preserving the existing tags. The overall change is very simple, but I didn't want to misrepresent the new work was reviewed by folks. Brian