From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE23829994B for ; Fri, 22 May 2026 01:53:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779414839; cv=none; b=sMZ0iGFRS9XiCRkIv01+10JU1sL/LSTOBJlqfIlBgqo2CaShyy6EMJHP9d+Xy6P0xfBG3MXc2hs6bO9F81+nf4PVCnhSfgAtuIBJ68JOoeozf3ISUau1qDEQpMOvI8mBjGrNNjmmBFUYq50s8t2R0tms8YHJ4JvtdJz8QhE8Cd4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779414839; c=relaxed/simple; bh=HVgnvceNEKk0s8v4dbVy+vGP+OYmTv6oSZm5F/qvmhc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jspJGGLeh+yZV93NWgpSvqUvR6cATn8FCWxm9qMnCXkiab9WAzArIRNtUYoA7hDs6AWCEmd1Ixc82xVHOE5V0pCEr31j4/JK3eF3tMSmEwUQNveP8iRHD7oKjywsj4QodlrRjRE2D67fbC92yYTVfQ5A5w4xgEsmBGDxCHXCwpM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Cy1QI1gI; arc=none smtp.client-ip=209.85.160.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Cy1QI1gI" Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-51306c9f2a8so79882301cf.1 for ; Thu, 21 May 2026 18:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779414836; x=1780019636; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0gw9SBzb8I9Zov+lx6aM52ecIi9qtL1D16HuqASE3kU=; b=Cy1QI1gIyBaUvBuDVizgM6KBlMVXOF3fw/xxWIu8SmIS2bpy8zibnqd40ve5JbWIDm nNhtNFZLMAQgpV2wvj2GxKR469nR1mi7MVY7z4CzPYyW/C0Mf/Khyloj/I1hnJiu6w+N KGMm0xTI+hBrffLjdJ3M/Kbbd64qh3iEzsm6zjp8kHNDYWj/X8N1moViTwF5FJ5TWpKX fkxGCeO/fV15WD8EUx+pN3ALhi7+bh4JHoQCxfX93ldL3ZpWVj9638IzM50eazjY/A+m J/T3wAay/b2gyjqQ6npNKarhvnHFV3mWHuDz7tV6rJaBEwdCWMWSPvOG9Wrb/qGQ2jiB cqAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779414836; x=1780019636; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0gw9SBzb8I9Zov+lx6aM52ecIi9qtL1D16HuqASE3kU=; b=XoGI9nely24hyvCpBBuQVGeQSRYtpGj4UG5neu52J3B+MsW6OrRwzeO2ofuWZ9c/zI hSu7QBFksYkzIAeMIP1ukba0Jm39HmiYAmlemK2fwf1pg8mPS4HsahwWvd2PbxMauu6a IGCWLHCEJcemrUOH/CnFUzFDWkZGNUNcFHCWfkxDGqxabz9vwUi9v14zJHTGup52Emv+ 2NR7UP06amg3u7/3NwXfOV15dDciK2X7Zq57V4VBfVvi5rFO86i2z5D1NLZkxLVX57VC yvZGMvFTQGG5gbCjAvtJz29AKDEEH4gTX1qJi6ZN7sFHpV5pRgZE8mz/1j6YIxl61T2K bWDQ== X-Forwarded-Encrypted: i=1; AFNElJ8ITkSK8njBGprKHTWwU4KpuydCSvMbIDbtqV0YUlVbmj3GZKbVCitsEszT4BlvX3ZvdFdmwOngRdEeq9g=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+esKUephN3d+jJ8FHMS14GWsIYbx8yN6iKV8G9WcqGoMczVKZ oMN4skj5M9upEFBviwn9Q1AKevEjuYHeJfwzIWkyVnoD94EanTfkzpNmWtiQMeQg X-Gm-Gg: Acq92OGnnZDJ11XcYPymk4yHWSWwL7tFTo5c8eoh+tIB0LcvpYeZuKQ1v20bkiUpjYP 0uKc6bMDWvHSwCr3FE46L+JKN16qmwVDioGwmwu8Enmyq3oUfCTtSZDy9DaPV7B8aefHoT1EnRi E5KScLZLEx1UG6fPj9hnDlFSEJEAbFrtiV7K6mn+pSKqEWMchS683ognxTp1kefngckR56yjyVM H+bnlRF5h7RCW0zBqFnCRc4hJCW/MTizDdHzE6do/mXkX4qvME+5bUAR/7cXv8NHa5NJ4DN/Zd2 JNT7tuwO+bBb5344V6yqQUkcA5ijK3L2Of6a2PonQqV4iMLzba80CJ4x1m3M5FyxA/EfASCyTJZ +fdx4EEVouh6lSbuOxTlBK3U6mNwz8rEmVIpaj4gYKy+CanlmMCRT71dd/ifchR+qB3R6bvbtHj OxOf/wmrKVpI/1v4lMyNYnftQukKOlo7LZUqzy56R5ks/Ztu6bzL9eacbfL/FQf8lIt/a+0rpc/ Kvmr74oTxo6WySKQcbX X-Received: by 2002:a05:622a:5a9a:b0:50d:9b07:9c44 with SMTP id d75a77b69052e-516d459c83emr25573561cf.39.1779414835747; Thu, 21 May 2026 18:53:55 -0700 (PDT) Received: from fedora ([172.245.82.59]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-516d8b25c69sm1304651cf.11.2026.05.21.18.53.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 18:53:55 -0700 (PDT) Date: Fri, 22 May 2026 09:53:49 +0800 From: Ming Lei To: Caleb Sander Mateos Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7.2 0/2] ublk: enable UBLK_F_SHMEM_ZC on zone appends Message-ID: References: <20260520203654.1413640-1-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260520203654.1413640-1-csander@purestorage.com> On Wed, May 20, 2026 at 02:36:52PM -0600, Caleb Sander Mateos wrote: > Commit 4d4a512a1f87 ("ublk: add PFN-based buffer matching in I/O path") > added support to ublk_setup_iod() for matching request buffers against > registered UBLK_F_SHMEM_ZC buffers, but missed adding it to > ublk_setup_iod_zoned() for zoned requests. ublk_setup_iod_zoned() > duplicates the code for initializing struct ublksrv_io_desc, making it > easy to forget to keep them in sync. Move the common code to a helper > function ublk_init_iod(). This allows zone appends to leverage the > shared memory zero copy optimization. > > This series is based on "ublk: optimize ublk_rq_has_data()" [1] > > [1]: https://lore.kernel.org/linux-block/20260513211846.1956810-1-csander@purestorage.com/ Looks fine, it just allows the optimization for zone append. Reviewed-by: Ming Lei Thanks, Ming