From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10B793537FF for ; Wed, 20 May 2026 08:46:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779266805; cv=none; b=eePgFldSHEQtwDgkTZnwx2WcB+rfBFg0/8bMYbNA+Y6jys+Do8DbGM+kznsJds55gflEkIo/KcP+6vKbd57+9hdUh4NmuTfPH7Dm+CPAsYhC4w3xVOtWaqntOzm/VpTHlgnCCMsGNaWg2lRRq/nFPRKc0IlNCQcoM3mxAIVYC2w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779266805; c=relaxed/simple; bh=EuNb7c+M5izNWaIX3sDUu+oSgbsnPpwC3h9wiA6CPGY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=E7oSho4ntA+VGqkyWYMq+crpUhqphGmbYYQ4lIF0VJfeUlz/0lVT913X1o94r7rOn1nqMMaMPAwliNyfpAiOienjDHHfaA9tK8Wqt2oAjSX5+fW1KifZWxme0BVcSNkt5YeDlSx+T/CpV6J22E4EpQir/kWlx7NT1U4FJy6greU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=WJdF61jH; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="WJdF61jH" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-43d7e23defbso2511254f8f.0 for ; Wed, 20 May 2026 01:46:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1779266800; x=1779871600; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=U53nOZsze2BOUUWxn8xrqWn0udiJAimX6PJ2o0xVGTg=; b=WJdF61jHG2kyvi6q/MrZRQrtCPML/KMtNakZx1H93IhZ8YGI6Eti3U6XPurZjnnR9T YRe2g3iMBF6VuhXQohMGttOO162iPe0pEiacJZnXNGDfcnBJNLE+RZ4SEdWgwiXuNmZH H0uGPS1Jpsl/mBwFpsML7G7dUAGycqyjC7YK9S4fSfGAc9xNNSTRdbjLIDNRtQ3RC+7D h9vXDlhL6Dh7DwXmPtg2+1ugJmkzj6v+lhVV+FoCbjwHo3MjSQOa9CkWLLky4DLJL7Hy mdTTRAnCzhdVHMvwSGsm7T0r5SLHkJc/sGVZGyOvXeEguvh8GktAIaGqUP/CwXJPwaor m7MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779266800; x=1779871600; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U53nOZsze2BOUUWxn8xrqWn0udiJAimX6PJ2o0xVGTg=; b=hRG4lbUiSdYZV5i7qjchmcTMQsxJ7Z/FCzBMATi4A9tMt3208bxZYUpC1a/M2AoX8V yvqFpQdlVMkc6BCqJXiQpuymkasUNMrxa2HtPbfwd4coecQ8eIvjAbAlRbriD+yPrq+v jkWNH18HQV38M7N9FHondVDeQ19zwIJgO5Kxm2+usH9YzcUGrd3QWwZlsig0DRG0lc8a Zf/8FjLSxq0wpFJieOM0Oe/qG+ha50cPX/ExNuNT9tG4DH8ldXrM4dl6B2K3roftFNlD w9WRrETSK/vC0jGrZ4uyF9APQHdSBVsNUaX1J0rKOrUgkqjihUfyE/ivng970rKS4kYk I+qQ== X-Forwarded-Encrypted: i=1; AFNElJ/IalD8RNu6cK+CLkuyUsFJv0M5pN3CdNJGkWy+xk65Uk55Dp0494iSbNjVjWvA805t+vwVx2jYHxyvkYU=@vger.kernel.org X-Gm-Message-State: AOJu0YzGZX2vbcGsZXNnTfbqZP8981Q43vSY/Pkk7WE2Hor8fsQqxbOY eBNLN0H0OuiTs43YHogSfrG8LxhV+bSV25ZFPmLfgrbcHGhdlnsYxq39s4lnncpc6VQ= X-Gm-Gg: Acq92OH40GDG28vYjnYgvSf09SOJIA7Oj8EHlpcjBBNPavV2cOhfyd3BKU3QrKTwVmZ 0uvAu2x2/Ivw/JYIudsta9C/aAogk3rMILSFzeRIhcqI0qOtI+LtsfrMvCBUxG+pbHqH55/OZ+C 3EXLlWjaVd1qrwGma7i7G9tiKVSUGPVdsx5u9GfYuKDtgVYn6rhggojjcRC0dX/Pk4KgYkuow/N 3eIfkN+4tSoNSxZLH+AVb8BuSGksGiTr94iY9kPfjWkMdSNeQOaq5qbziYaJlEk6UOzCYu6fOaM 2Y/4iTsHUVIFu6+bjZyRtWY4M2A/SrewALKyZIA8EnAsKszGmfea0xJniLyqPLfCh8js3isWRZ1 DadXWN1s60X7xXnW/Nho8IYxaZWfpJN/uj1LPuI0Yh73RIHFD7Qcb2TZD67ubSunrrHVwB6Mj3f Cb6PeaKagULUyhdp6hWQAkM9co7j/0UrkAkIdj7j6rPEMbhdIbm9SqA7jfhDBo6wJR+E+W5Pyr9 w1qR8nYeMKfw5k= X-Received: by 2002:a5d:5d82:0:b0:439:c299:4d8f with SMTP id ffacd0b85a97d-45e5c5cbe4bmr36382479f8f.17.1779266800378; Wed, 20 May 2026 01:46:40 -0700 (PDT) Received: from localhost (p200300f65f47db04a02ef40d8e5825ac.dip0.t-ipconnect.de. [2003:f6:5f47:db04:a02e:f40d:8e58:25ac]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-45da0a19b1dsm51573666f8f.17.2026.05.20.01.46.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 01:46:39 -0700 (PDT) Date: Wed, 20 May 2026 10:46:38 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Helge Deller Cc: Benjamin Herrenschmidt , Russell King , Andres Salomon , Antonino Daplas , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-geode@lists.infradead.org, Markus Schneider-Pargmann Subject: Re: [PATCH] fbdev: Consistently define pci_device_ids using named initializers Message-ID: References: <20260430111637.211336-2-u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4j765bpqgzr2splh" Content-Disposition: inline In-Reply-To: <20260430111637.211336-2-u.kleine-koenig@baylibre.com> --4j765bpqgzr2splh Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] fbdev: Consistently define pci_device_ids using named initializers MIME-Version: 1.0 Hello, On Thu, Apr 30, 2026 at 01:16:36PM +0200, Uwe Kleine-K=F6nig (The Capable H= ub) wrote: > diff --git a/drivers/video/fbdev/matrox/matroxfb_base.c b/drivers/video/f= bdev/matrox/matroxfb_base.c > index e1a4bc7c2318..22774eb1b14c 100644 > --- a/drivers/video/fbdev/matrox/matroxfb_base.c > +++ b/drivers/video/fbdev/matrox/matroxfb_base.c > @@ -1642,7 +1642,7 @@ static int initMatrox2(struct matrox_fb_info *minfo= , struct board *b) > int err; > =20 > static const struct pci_device_id intel_82437[] =3D { > - { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82437) }, > + { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_82437) }, > { }, > }; > =20 after further sharpening my tooling there is an additional change that IMHO should be done here: - { }, + { } and ... > diff --git a/drivers/video/fbdev/pvr2fb.c b/drivers/video/fbdev/pvr2fb.c > index 3f6384e631b1..06aefad75f46 100644 > --- a/drivers/video/fbdev/pvr2fb.c > +++ b/drivers/video/fbdev/pvr2fb.c > @@ -993,9 +993,8 @@ static void pvr2fb_pci_remove(struct pci_dev *pdev) > } > =20 > static const struct pci_device_id pvr2fb_pci_tbl[] =3D { > - { PCI_VENDOR_ID_NEC, PCI_DEVICE_ID_NEC_NEON250, > - PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, > - { 0, }, > + { PCI_VDEVICE(NEC, PCI_DEVICE_ID_NEC_NEON250), }, > + { }, > }; > =20 > MODULE_DEVICE_TABLE(pci, pvr2fb_pci_tbl); =2E.. here: - { PCI_VDEVICE(NEC, PCI_DEVICE_ID_NEC_NEON250), }, + { PCI_VDEVICE(NEC, PCI_DEVICE_ID_NEC_NEON250) }, - { }, + { } Would you mind squashing that into the patch you already applied, maybe adding: While touching all these arrays, unify usage of whitespace and comma in a few drivers. to the commit log? I can also send a v2 of the patch with these changes included if that's easier for you. Otherwise I will put sending these modifications separately on my todo list. Best regards Uwe --4j765bpqgzr2splh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmoNdOsACgkQj4D7WH0S /k7n3AgAmiu0dkGSmVN5iwDMsbx9u5oGpxoTfYsBdf+ieZ5EzDYhZzjAd5M4GNMS dajrNSdkatRRbEZFE3PYDscIkW69PVck72sxOJdTDyAVSPf2hgi3mbElPpXW5ZEl V5s0iKhXHTafmLPl+5cAsDOdMG19WulP1A3QfTepuM0kOEAKsQ4UwUV4AWlpBgH6 GMiJdyUX4viX+gD8zOIgyKPCjqvBa8CMPkgQORFA1fuD+eEbv1Iw1b0xDr/AinyG 8Jfn/ZzaAAnTJje43x8rP+Q5hw6uVI6bBHTrhypMFQ0C9ofIZBsv2BUyQ8Hp5i85 TX3Z+lJoWmwknV9WI68+rtnMMOgSCg== =on22 -----END PGP SIGNATURE----- --4j765bpqgzr2splh--