From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCA623A1E89; Wed, 20 May 2026 14:38:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779287928; cv=none; b=f7GsbCegybDzWaRLmYR4vAxq8WdvFBO++hH04WuUWPaSKfDL6/K/wSeoWslms3wn29JTLy4Gi0aV/fawWquiiuSL/GTH05pwLqWA2hCTArr1QYhWQXTrGsPlVXdoCROjN74ROHDyDpDP6Gn+z0yRD63/bLZ/VIQ4uVczFKtmQBA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779287928; c=relaxed/simple; bh=ukoyQfq7g1hpMtCyw5u9ai3GNHoVnJ7n5AxVyFUzhD0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TpZcCgse8iBBlMZsq1XhVxKWf1ot686S+PGEqb1Jq+TEtDlnb7xiBL790An8iNkXZRtqjTMPlj3wlbLWfj2VpmmhFLKSauvYOquaQhQCzmJQLHYAzdrZZ6mvi4Az3krRWeIYJkh48sse26XHnpWlq3I4vhIsqTIAAO9uSD8DMGs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZVAaTIQm; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZVAaTIQm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 738601F000E9; Wed, 20 May 2026 14:38:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779287927; bh=cFQg2HXOXIJxjdbmsh5WLkj0lQEstvpGp0sk1kVRALY=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=ZVAaTIQmqmlxmVokXJCzztqFuvS1cTjcObkB/I6v4xhGx+0/Ag+0i7DJ6pybXz+Zj gkvBz5ot8q87u3C3VqbOAQeMpdLnW7A+HIZa8J86NK5azUhUyQAHIGv0ocBYmtR0Xe FYeVnZxs7quFzzpRSo1MgiLCLDbzKtViVfL6VFSv+AAzei2D6w6modToW16IlOPNmq 7HO/oQRP2/NkBput86yoiM1sRrhF3/2jDQWKQPkjh8LNK/9kTuz2mFUA5vS4CAGDSn 26u5St4E4c6o6GSjTCaqcdokzR9Yh0bIYVkte1qn0vKqYc60g6o/aW9dW1CdNJz1E+ yplu0TQJw+bVg== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wPi4L-00000002vvc-1Z5H; Wed, 20 May 2026 16:38:45 +0200 Date: Wed, 20 May 2026 16:38:45 +0200 From: Johan Hovold To: Zhang Cen Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, zerocling0077@gmail.com, 2045gemini@gmail.com Subject: Re: [PATCH v2] USB: serial: belkin_sa: validate interrupt status length Message-ID: References: <20260519111150.3583363-1-rollkingzzc@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260519111150.3583363-1-rollkingzzc@gmail.com> On Tue, May 19, 2026 at 07:11:50PM +0800, Zhang Cen wrote: > The Belkin interrupt callback treats interrupt data as a four-byte > status report and reads LSR/MSR fields at offsets 2 and 3. The > interrupt-in buffer length is derived from endpoint wMaxPacketSize, and > short interrupt transfers may complete successfully with a smaller > actual_length. > > Check the completed interrupt packet length before parsing status > fields so short interrupt endpoints and short successful packets are > ignored instead of causing out-of-bounds or stale status-byte reads. > > KASAN report as below: > > BUG: KASAN: slab-out-of-bounds in belkin_sa_read_int_callback() > Read of size 1 > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Assisted-by: Codex:gpt-5.5 > Signed-off-by: Zhang Cen > --- > v2: > - Drop the transfer_buffer_length check; urb->actual_length is bounded > by the URB transfer buffer length. > - Add the KASAN validation report. > - Add Assisted-by tag. Applied, thanks. Johan