From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8140E202997 for ; Wed, 20 May 2026 18:57:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779303468; cv=none; b=PHjXK6AYTxaSXXDPUBj150TUYwXmpl6Rzwra18InVfS9rBSxf/J3vYSqGYfbxXZimZWRuy21SzN01bq8/R+44s9HUsPeG0/TzI1RA9Lyk/4+I+g0ixyE3b/oGZaH13a5IH+VCZ9o8qqh9qMzF4pvs9bhMOslMxrkifub8ZDi0yc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779303468; c=relaxed/simple; bh=Kc2OJR4IiLheL3KZ+40TQBX37I/EytENBHyOBnuvaCg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Quqd8VVi7SCYDDHd58P/BpSjaYEDk+nEdAC7QPBKr4WZwAG/xLNGl5f2hAwFmJqNK9w2dSShq6e7iBR0KL+SsKajedQx0KiJ3cTKZseq4cUsO1MNCJ4KsEt3nTZkUCHQjubwyw76FzM2bru+ORlXRMKbFE0z8JnMFYLv1BN/9c8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Rjudv8Se; arc=none smtp.client-ip=209.85.208.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Rjudv8Se" Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-395317d8852so46957841fa.2 for ; Wed, 20 May 2026 11:57:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779303465; x=1779908265; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=irt082pHwLjscL2WvgdVT5VGnKkuoPkasUHRPoDekQs=; b=Rjudv8SeBq4DYfyjxmZhgaAMeBB0ZbXnWE0npub5rWEd20XbFEMwUYYqgDJvjo7RYM h0ilDOaOkxGXtqk1Lf65qFMkUnwzlRJK0BxjwTrW+PBCYpGiyk26EUK52CogFR3R4k0K KYmq9XebgaRp1/VKAVDm7dgGrxGyLUlM90AZQblqsavr8eSYKUkdpBU/hS+8OV07vfAY fcyT9/J/LyLlZR/H32iWUs8/jUgQ8RDsHULDqgX/ANTug2XAKcAkPqvoSHnmWVgBggE7 7M78rv2aUBcaGFnG3oEs905NLwSD/Xg1QQUnJq9sTOw82wuapvPQhQ5h93xs5nWp4AgX mBlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779303465; x=1779908265; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=irt082pHwLjscL2WvgdVT5VGnKkuoPkasUHRPoDekQs=; b=R/ezEZQShz+Xkt6aK4nDGdYiv8PLcAykLhlG+HRk9KXt/BMvioEM8a4tuXnBkBXOTg mNgTRXiZ4cG/AQ2IYvdcH1BgZirX3U+2EznzF4W1jjTpDylSK7PMK92GzvfYptellO2j kTKq/mSuUMTUhF9kuy9ZlmOcpCcyAKcFQBxIfx581WomAon4clr63APCHcmDMGA9MJ0h tbmP/8I7ciiQR7gqzvUkBfgKS3yMUmULbukojejFRyXKDRU5YhnR9fvymnFCI/q2SAEt JchwuVkW1WLIHbk+9QTZnOVXVd+bJ5X17ty10FtoqRG1Ok77z/Ggjd4sNoWfGaKGPjQE tktA== X-Forwarded-Encrypted: i=1; AFNElJ+brwoYIgEo8JU+JIoNKa08H3qqyiHUBFR9uJS809NzFTS3OKaUK2+gdd+14jEi+cf4vR77e3T3NgYpWs4=@vger.kernel.org X-Gm-Message-State: AOJu0YzQ/T7WayekXupvsmr+Ho8Y4CJWcav/v8hkdWQZt+FVBycAeJsM n0ClaiSDFaXk9daJc66IUgoBwuy8lb+Wheyj1AbC+Y7g9u4HoyEK8/0lNT28Dg== X-Gm-Gg: Acq92OFEcs3eZhhi0Sn5aav309GGjMlXYCQuk03z8TKiGXwaqmK/06FYL6dzFZ3kjUg N56EVEoyXjqVZ9/kSxl2Ry2aYe77E3CLjXYJOyDZWXHkDVA8kVUDcWBj7ct9K/sNTjEGRtZD3YL TS8XhlOnd6R+MzTw3wHLtHPHNYTfyAYqFHVqltJdw6AVTg5TG7HAgKbvqJjmjlNl9p8hDW0cR/s b5M/vEdY9W8YMTRVa9XAXhG/DKsZM/i0P7hyT8PeTdidWy2/NXpc9FKSoVMfE2R30+GEBApsqWI YW3wKPalTOqwmEtQkaSnrwBEWV1f2pQkCoTNWQgZa6mqK0CHeitbKrEIkS2p5nveVz22ZRr+ts9 kf9zAF2JEjO8O3TlJLwmmMx/pJuXdPugCrOjVd5EjI7ylbaud6ZpT6mT/uSbLbalCBrFLRX1tVM F8sbEjhUh/UvOoQSaQZOk7PxPrY0FOxLaTgkQ= X-Received: by 2002:a05:651c:1ca:b0:38f:e9fa:266 with SMTP id 38308e7fff4ca-39561fcff2bmr79553381fa.31.1779303464450; Wed, 20 May 2026 11:57:44 -0700 (PDT) Received: from grain.localdomain ([5.18.255.97]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-395887b408bsm30839601fa.35.2026.05.20.11.57.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 11:57:44 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 5471D5A005B; Wed, 20 May 2026 21:57:43 +0300 (MSK) Date: Wed, 20 May 2026 21:57:43 +0300 From: Cyrill Gorcunov To: Simon Horman Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com Subject: Re: [PATCH v2] ice: Fix wrong dsn read in ice_adapter_put Message-ID: References: <20260517125307.287246-1-horms@kernel.org> <20260520180324.GC988238@horms.kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260520180324.GC988238@horms.kernel.org> User-Agent: Mutt/2.3.1 (2026-03-20) On Wed, May 20, 2026 at 07:03:24PM +0100, Simon Horman wrote: ... > > Thanks Cyrill, > > I agree that this is a good approach. > > I might suggest splitting the patch in two:s > 1. introduce and use ICE_FW_RECOVERY_MODE > 2. Address dns nread in ice_adapter_put Thanks for review, Simon! I'll make so.