From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B01836AB57 for ; Wed, 20 May 2026 20:26:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779308777; cv=none; b=oy3tLyz08cvEf2ZWoRUigM9Q9rzt7d6YM+JfNC0EbasjliTpBz+0qWdXBSB8iRrCCCD3A5dDGw1D0YAzbxFy5xj3NCN9v5zzXrcetIuhBQv9RDCgDmhcnPSvBd1jFOt090l+FeEt9xfBO7Issu0PWgwvs3DwFcBzuX0P0A8qKdU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779308777; c=relaxed/simple; bh=uWiNE+kJVn/0bICCqchDKbTrkdLr64i9iOBdrDc6vls=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rX4Oxk6EFKG69LHuPUlRBLsMvfD109z6yMZJCTioGjQByGAbsG4LmpbVuBxzAfk8DrmMR+bC5P7FMpgZT5Eau9mb8+cc/5hLKA5T5ouvhn/TnwBO3j2696GXcleAHVZYS5bohWgcsoeoMtRo/0gnSpoVTNsYqiE9Pfokt2qK1S0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=O2Vvs0+U; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="O2Vvs0+U" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02D3E1F00A39; Wed, 20 May 2026 20:26:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779308775; bh=SKUHEGmFld29+rVgmHT4hiu8JBAXU45/uSi6kAd11uc=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=O2Vvs0+USgI82kc+yDnUl28xx41SMb9gWDhOXPWlfHbKhqOxS49tVxQF2Tmo9POT4 aTffPacRNG8mMwBWqsx1Ab7392u9SqZ8d97dVzTqAivR5YGMfOe9WkcEk2wbb3A76L YtLGKPJdU6Ip2NQrLfLDFQC40rSuhgTOTUdGJOHvTGQCILgEwgyerRglfSYmh5bdiJ aBdFIcJafPhIclr97uIPusPi/K2FUdjAsFYQp4XNOBNMjYLANdno7Ch0VSJcam9j6R pzrd6DGFIl3w19tUiX+o0yTNpCpEdKCIhhAu8K7t3FqByLNH7sHEI7qhFwrnLkYCqS qJO1VH5C8LmqA== Date: Wed, 20 May 2026 14:26:13 -0600 From: Keith Busch To: Chao Shi Cc: linux-nvme@lists.infradead.org, Christoph Hellwig , Sagi Grimberg , Jens Axboe , Tatsuya Sasaki , Maurizio Lombardi , linux-kernel@vger.kernel.org, Sungwoo Kim , Dave Tian , Weidong Zhu Subject: Re: [PATCH v2] nvme: reserve a keep-alive admin tag for all transports Message-ID: References: <20260515071248.2689513-1-coshi036@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260515071248.2689513-1-coshi036@gmail.com> On Fri, May 15, 2026 at 03:12:48AM -0400, Chao Shi wrote: > Per NVMe 2.0a section 5.27.1.12 and the transport binding wording, > PCIe MAY support KATO. Reserve one admin tag on all transports so > the host is ready when a controller accepts the feature. Fabrics > keeps two, the second being for the connect command. > > A quirk-based approach was considered but no PCIe controller > documented to declare KAS != 0 was found (two enterprise SSDs tested > locally report KAS=0), so an allowlist has no entries today. I totally get it's optional for PCIe, but that also means it's the host's option on whether it wants to use it, and there's no requirement we have to. We just need the driver react correctly when someone tries to do it. I am skeptical anyone would produce a PCIe device that supports it, but let's say someone does: what is the use case motivating enabling this optional feature in this driver? If it's just because the option is there, then I think we can just reject the user command submitting the feature for PCIe transports, like I earlier suggested. Requiring an active command will just harm idle power states.