From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 334E8328B4B for ; Thu, 21 May 2026 09:51:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779357075; cv=none; b=O7mBibvNW8H8rV2//W9getlpCEcoe+U++GO/KA7PIjH1uQ/LD44Gjpre84V2Qia+QJtuI0YPtrRfyTFxp9KlRRrfds8zy9qeT33izZ6lFMeiZqgvMJtysnb1WU7FKAVievhf9If5kCqEuEilwXPDH+BXiTMpBALuw9MSDyAtcXo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779357075; c=relaxed/simple; bh=QNdpxs+CW01o16hJtmFiko8Tepjg45cGL7dTfaJfkTs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NTKJ5Q8NMXLLQWBUjVYZNg8/NsiGFmI/4jUau3E3o5Df8zgUexUqelx3k0kQ62o27jbBipknpUsjUyo3DGsqREjpM10j1WeGjc0xG/rA7IONHiduhyxYtrz0EmEd5oFAS6yxInNVKIKBwPukJH8JUe19AXmdzjqjIIa1hq2nAyQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch; spf=none smtp.mailfrom=ffwll.ch; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b=CPMs8GTY; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ffwll.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="CPMs8GTY" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4903cbfad68so1693265e9.0 for ; Thu, 21 May 2026 02:51:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; t=1779357071; x=1779961871; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=v4gQkUqn8G/2ZssvYAdUOdDkCHargD2hgrC4y5JhqUg=; b=CPMs8GTYXvdq+FvNk12HmLJ/J4h6hi3eioR3KTyGgoqykxLGDyokfb6Whso1j6mRIY jKQ5OyaSlCfy44qhwxLOyVcwmQGC72HVRIcphmP7uxHQCy0wcbbFvu/qkaQPy9MNP+gv r+eYmrWvnpq4SwLkywcmUjHiEv1FeRaM7mFDc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779357071; x=1779961871; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v4gQkUqn8G/2ZssvYAdUOdDkCHargD2hgrC4y5JhqUg=; b=AyWEkT4Yna7lMW76bFHRvjNyzCFOpcItj5CdmvZ9F52/51k7cLJRbgzxdavsdFJr1I KiRsQYG7WtM8rllJPX3RDPeZkpRdcrGP4NR5HxJv3M7zEbsrk6dSfIg+yV2ObqOpZJdq w0/XzKZVrLmVq4ysbIiwWcRtj653TqeJD1fEM4593z02rSk6n+YM/0qTJD5radd1iWLs INUsPxJUdFU5o24Ru3TpqEsSAml4dLhddFD71j3OLg/oAzm5HcUV6jVdMLUgcL5qgClq /PV0pW1pQY3L/yCTQSlNWwRDHF5eeOIcBq2mC1nTei2yy7fZrtZJ4hD9bVha+PoloHGH UwIA== X-Forwarded-Encrypted: i=1; AFNElJ8LjHitGfFU2MEx/MGSfN9cE08mP+U/ow6wFVAauXX7CgGFveUlaJzFhjuDPBlzwrmXcY39IKjD3DnIjpo=@vger.kernel.org X-Gm-Message-State: AOJu0YwfSdjavQ7VsAzBva0G40+OrbDM+X0LgAsyig1Kfb7NWAF7VPik WWl3hxqOVmbAIRBSrkHVayT337iiCr6xscGa5EFgoBWxmC15sMqG/UIsO88vIfdMS6g= X-Gm-Gg: Acq92OF/9+xsTPiPJ2asfqnEIEbeolmn3CxvpEgGnJ0Am5cgqp3LgQNvzxghhhTnQPL TsD9azPEjTm3yNAR0j6jEbStvySViEt1MdIhpAuQ0bYAZH21XR8MwsB7VV4nsL/TXhLeZfrN0wX RzOiHueNVE6JvIwL4HdlhMvVxDyEpLG75hE/ZoMkJH0g08vQTWtdSbwHLrWou/1Zg696SQ7uGRd WOfHYPvighdwDdy6KCguPfZ7yNCFQpZV4yxZ8YaOBQZ/mLHoE+q7gP7GkqlCoTR8UN5FJTF8t09 z475PP0NCXKRuK3kkwNk/T0fQd0P3q8uThsC4sew+AtXZJ1DoVPmMk259xqq5ckuRmcPUzUYgxy yUgvGOeH4J9/CwHbpKqVN/+79XLykYGBMxZYy3RknvSs1yyRBIBh38zBtfrAlUbXG4RRDzJ5btC XhbKL5u66JpPVY3tBzkEnAKgBuHM9PSBzlc9nFD+x5UXzueg== X-Received: by 2002:a05:600c:621a:b0:48d:50a:6ef4 with SMTP id 5b1f17b1804b1-490360ae7e3mr22354105e9.11.1779357071435; Thu, 21 May 2026 02:51:11 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:5485:d4b2:c087:b497]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49033d8e24bsm51584595e9.10.2026.05.21.02.51.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 02:51:10 -0700 (PDT) Date: Thu, 21 May 2026 11:51:08 +0200 From: Simona Vetter To: Maxime Ripard Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Jyri Sarha , Tomi Valkeinen , Devarsh Thakkar , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 01/28] drm/atomic: Fix unused but set warning in state iterator macros Message-ID: Mail-Followup-To: Maxime Ripard , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Jyri Sarha , Tomi Valkeinen , Devarsh Thakkar , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260423-drm-state-readout-v2-0-8549f87cb978@kernel.org> <20260423-drm-state-readout-v2-1-8549f87cb978@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260423-drm-state-readout-v2-1-8549f87cb978@kernel.org> X-Operating-System: Linux phenom 6.19.10+deb14-amd64 On Thu, Apr 23, 2026 at 12:18:14PM +0200, Maxime Ripard wrote: > A number of state iterator macros trigger a compiler warning if an > iterator parameter isn't used in the code block. > > Add a similar workaround than in most other macros. I'm not on top of macro-fu, so not leaning out the window and dropping an r-b here. But sounds reasonable. Acked-by: Simona Vetter > > Signed-off-by: Maxime Ripard > --- > include/drm/drm_atomic.h | 64 +++++++++++++++++++++++++++++++----------------- > 1 file changed, 42 insertions(+), 22 deletions(-) > > diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h > index f03cd199aee7..b9e7281cfc97 100644 > --- a/include/drm/drm_atomic.h > +++ b/include/drm/drm_atomic.h > @@ -946,13 +946,15 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); > for ((__i) = 0; \ > (__i) < (__state)->num_connector; \ > (__i)++) \ > for_each_if ((__state)->connectors[__i].ptr && \ > ((connector) = (__state)->connectors[__i].ptr, \ > - (void)(connector) /* Only to avoid unused-but-set-variable warning */, \ > - (old_connector_state) = (__state)->connectors[__i].old_state, \ > - (new_connector_state) = (__state)->connectors[__i].new_state, 1)) > + (void)(connector) /* Only to avoid unused-but-set-variable warning */, \ > + (old_connector_state) = (__state)->connectors[__i].old_state, \ > + (void)(old_connector_state) /* Only to avoid unused-but-set-variable warning */, \ > + (new_connector_state) = (__state)->connectors[__i].new_state, \ > + (void)(new_connector_state) /* Only to avoid unused-but-set-variable warning */, 1)) > > /** > * for_each_old_connector_in_state - iterate over all connectors in an atomic update > * @__state: &struct drm_atomic_state pointer > * @connector: &struct drm_connector iteration cursor > @@ -968,12 +970,13 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); > for ((__i) = 0; \ > (__i) < (__state)->num_connector; \ > (__i)++) \ > for_each_if ((__state)->connectors[__i].ptr && \ > ((connector) = (__state)->connectors[__i].ptr, \ > - (void)(connector) /* Only to avoid unused-but-set-variable warning */, \ > - (old_connector_state) = (__state)->connectors[__i].old_state, 1)) > + (void)(connector) /* Only to avoid unused-but-set-variable warning */, \ > + (old_connector_state) = (__state)->connectors[__i].old_state, \ > + (void)(old_connector_state) /* Only to avoid unused-but-set-variable warning */, 1)) > > /** > * for_each_new_connector_in_state - iterate over all connectors in an atomic update > * @__state: &struct drm_atomic_state pointer > * @connector: &struct drm_connector iteration cursor > @@ -989,13 +992,13 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); > for ((__i) = 0; \ > (__i) < (__state)->num_connector; \ > (__i)++) \ > for_each_if ((__state)->connectors[__i].ptr && \ > ((connector) = (__state)->connectors[__i].ptr, \ > - (void)(connector) /* Only to avoid unused-but-set-variable warning */, \ > - (new_connector_state) = (__state)->connectors[__i].new_state, \ > - (void)(new_connector_state) /* Only to avoid unused-but-set-variable warning */, 1)) > + (void)(connector) /* Only to avoid unused-but-set-variable warning */, \ > + (new_connector_state) = (__state)->connectors[__i].new_state, \ > + (void)(new_connector_state) /* Only to avoid unused-but-set-variable warning */, 1)) > > /** > * for_each_oldnew_crtc_in_state - iterate over all CRTCs in an atomic update > * @__state: &struct drm_atomic_state pointer > * @crtc: &struct drm_crtc iteration cursor > @@ -1012,14 +1015,14 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); > (__i) < (__state)->dev->mode_config.num_crtc; \ > (__i)++) \ > for_each_if ((__state)->crtcs[__i].ptr && \ > ((crtc) = (__state)->crtcs[__i].ptr, \ > (void)(crtc) /* Only to avoid unused-but-set-variable warning */, \ > - (old_crtc_state) = (__state)->crtcs[__i].old_state, \ > - (void)(old_crtc_state) /* Only to avoid unused-but-set-variable warning */, \ > - (new_crtc_state) = (__state)->crtcs[__i].new_state, \ > - (void)(new_crtc_state) /* Only to avoid unused-but-set-variable warning */, 1)) > + (old_crtc_state) = (__state)->crtcs[__i].old_state, \ > + (void)(old_crtc_state) /* Only to avoid unused-but-set-variable warning */, \ > + (new_crtc_state) = (__state)->crtcs[__i].new_state, \ > + (void)(new_crtc_state) /* Only to avoid unused-but-set-variable warning */, 1)) > > /** > * for_each_old_crtc_in_state - iterate over all CRTCs in an atomic update > * @__state: &struct drm_atomic_state pointer > * @crtc: &struct drm_crtc iteration cursor > @@ -1035,11 +1038,12 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); > (__i) < (__state)->dev->mode_config.num_crtc; \ > (__i)++) \ > for_each_if ((__state)->crtcs[__i].ptr && \ > ((crtc) = (__state)->crtcs[__i].ptr, \ > (void)(crtc) /* Only to avoid unused-but-set-variable warning */, \ > - (old_crtc_state) = (__state)->crtcs[__i].old_state, 1)) > + (old_crtc_state) = (__state)->crtcs[__i].old_state, \ > + (void)(old_crtc_state) /* Only to avoid unused-but-set-variable warning */, 1)) > > /** > * for_each_new_crtc_in_state - iterate over all CRTCs in an atomic update > * @__state: &struct drm_atomic_state pointer > * @crtc: &struct drm_crtc iteration cursor > @@ -1120,12 +1124,14 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); > (__i) < (__state)->dev->mode_config.num_total_plane; \ > (__i)++) \ > for_each_if ((__state)->planes[__i].ptr && \ > ((plane) = (__state)->planes[__i].ptr, \ > (void)(plane) /* Only to avoid unused-but-set-variable warning */, \ > - (old_plane_state) = (__state)->planes[__i].old_state,\ > - (new_plane_state) = (__state)->planes[__i].new_state, 1)) > + (old_plane_state) = (__state)->planes[__i].old_state, \ > + (void)(old_plane_state) /* Only to avoid unused-but-set-variable warning */, \ > + (new_plane_state) = (__state)->planes[__i].new_state, \ > + (void)(new_plane_state) /* Only to avoid unused-but-set-variable warning */, 1)) > > /** > * for_each_oldnew_plane_in_state_reverse - iterate over all planes in an atomic > * update in reverse order > * @__state: &struct drm_atomic_state pointer > @@ -1142,12 +1148,15 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); > for ((__i) = ((__state)->dev->mode_config.num_total_plane - 1); \ > (__i) >= 0; \ > (__i)--) \ > for_each_if ((__state)->planes[__i].ptr && \ > ((plane) = (__state)->planes[__i].ptr, \ > - (old_plane_state) = (__state)->planes[__i].old_state,\ > - (new_plane_state) = (__state)->planes[__i].new_state, 1)) > + (void)(plane) /* Only to avoid unused-but-set-variable warning */, \ > + (old_plane_state) = (__state)->planes[__i].old_state, \ > + (void)(old_plane_state) /* Only to avoid unused-but-set-variable warning */, \ > + (new_plane_state) = (__state)->planes[__i].new_state, \ > + (void)(new_plane_state) /* Only to avoid unused-but-set-variable warning */, 1)) > > /** > * for_each_new_plane_in_state_reverse - other than only tracking new state, > * it's the same as for_each_oldnew_plane_in_state_reverse > * @__state: &struct drm_atomic_state pointer > @@ -1159,11 +1168,13 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); > for ((__i) = ((__state)->dev->mode_config.num_total_plane - 1); \ > (__i) >= 0; \ > (__i)--) \ > for_each_if ((__state)->planes[__i].ptr && \ > ((plane) = (__state)->planes[__i].ptr, \ > - (new_plane_state) = (__state)->planes[__i].new_state, 1)) > + (void)(plane) /* Only to avoid unused-but-set-variable warning */, \ > + (new_plane_state) = (__state)->planes[__i].new_state, \ > + (void)(new_plane_state) /* Only to avoid unused-but-set-variable warning */, 1)) > > /** > * for_each_old_plane_in_state - iterate over all planes in an atomic update > * @__state: &struct drm_atomic_state pointer > * @plane: &struct drm_plane iteration cursor > @@ -1178,11 +1189,14 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); > for ((__i) = 0; \ > (__i) < (__state)->dev->mode_config.num_total_plane; \ > (__i)++) \ > for_each_if ((__state)->planes[__i].ptr && \ > ((plane) = (__state)->planes[__i].ptr, \ > - (old_plane_state) = (__state)->planes[__i].old_state, 1)) > + (void)(plane) /* Only to avoid unused-but-set-variable warning */, \ > + (old_plane_state) = (__state)->planes[__i].old_state, \ > + (void)(old_plane_state) /* Only to avoid unused-but-set-variable warning */, 1)) > + > /** > * for_each_new_plane_in_state - iterate over all planes in an atomic update > * @__state: &struct drm_atomic_state pointer > * @plane: &struct drm_plane iteration cursor > * @new_plane_state: &struct drm_plane_state iteration cursor for the new state > @@ -1216,12 +1230,15 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); > */ > #define for_each_oldnew_private_obj_in_state(__state, obj, old_obj_state, new_obj_state, __i) \ > for ((__i) = 0; \ > (__i) < (__state)->num_private_objs && \ > ((obj) = (__state)->private_objs[__i].ptr, \ > + (void)(obj) /* Only to avoid unused-but-set-variable warning */, \ > (old_obj_state) = (__state)->private_objs[__i].old_state, \ > - (new_obj_state) = (__state)->private_objs[__i].new_state, 1); \ > + (void)(old_obj_state) /* Only to avoid unused-but-set-variable warning */, \ > + (new_obj_state) = (__state)->private_objs[__i].new_state, \ > + (void)(new_obj_state) /* Only to avoid unused-but-set-variable warning */, 1); \ > (__i)++) > > /** > * for_each_old_private_obj_in_state - iterate over all private objects in an atomic update > * @__state: &struct drm_atomic_state pointer > @@ -1235,11 +1252,13 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); > */ > #define for_each_old_private_obj_in_state(__state, obj, old_obj_state, __i) \ > for ((__i) = 0; \ > (__i) < (__state)->num_private_objs && \ > ((obj) = (__state)->private_objs[__i].ptr, \ > - (old_obj_state) = (__state)->private_objs[__i].old_state, 1); \ > + (void)(obj) /* Only to avoid unused-but-set-variable warning */, \ > + (old_obj_state) = (__state)->private_objs[__i].old_state, \ > + (void)(old_obj_state) /* Only to avoid unused-but-set-variable warning */, 1); \ > (__i)++) > > /** > * for_each_new_private_obj_in_state - iterate over all private objects in an atomic update > * @__state: &struct drm_atomic_state pointer > @@ -1254,11 +1273,12 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); > #define for_each_new_private_obj_in_state(__state, obj, new_obj_state, __i) \ > for ((__i) = 0; \ > (__i) < (__state)->num_private_objs && \ > ((obj) = (__state)->private_objs[__i].ptr, \ > (void)(obj) /* Only to avoid unused-but-set-variable warning */, \ > - (new_obj_state) = (__state)->private_objs[__i].new_state, 1); \ > + (new_obj_state) = (__state)->private_objs[__i].new_state, \ > + (void)(new_obj_state) /* Only to avoid unused-but-set-variable warning */, 1); \ > (__i)++) > > /** > * drm_atomic_crtc_needs_modeset - compute combined modeset need > * @state: &drm_crtc_state for the CRTC > > -- > 2.53.0 > -- Simona Vetter Software Engineer http://blog.ffwll.ch