From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: Clemens Ladisch <clemens@ladisch.de>,
Takashi Sakamoto <o-takashi@sakamocchi.jp>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
"Christian A. Ehrhardt" <lk@c--e.de>,
linux1394-devel@lists.sourceforge.net,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
"Christian A. Ehrhardt" <christian.ehrhardt@codasip.com>
Subject: Re: [PATCH v2 2/2] ALSA: firewire: Make use of ieee1394's .driver_data_ptr
Date: Mon, 11 May 2026 13:54:36 +0300 [thread overview]
Message-ID: <agG1bE_1RfrUR7zm@ashevche-desk.local> (raw)
In-Reply-To: <6b7b7b3b8b54465ad5e7463412a202350fccbb62.1778494204.git.u.kleine-koenig@baylibre.com>
On Mon, May 11, 2026 at 12:45:03PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> Recently struct ieee1394_device_id gained a new member to store a pointer
> to driver data. Make use of that to get rid of a bunch of casts.
...
> - if (!entry->driver_data)
> + if (!entry->driver_data_ptr)
> detect_formats = snd_dice_stream_detect_current_formats;
> else
> - detect_formats = (snd_dice_detect_formats_t)entry->driver_data;
> + detect_formats = entry->driver_data_ptr;
While at it, it can be swapped for better readability
if (entry->driver_data_ptr)
detect_formats = entry->driver_data_ptr;
else
detect_formats = snd_dice_stream_detect_current_formats;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-11 10:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 10:45 [PATCH v2 0/2] firewire: Simplify storing pointers in device id struct Uwe Kleine-König (The Capable Hub)
2026-05-11 10:45 ` [PATCH v2 1/2] " Uwe Kleine-König (The Capable Hub)
2026-05-11 10:45 ` [PATCH v2 2/2] ALSA: firewire: Make use of ieee1394's .driver_data_ptr Uwe Kleine-König (The Capable Hub)
2026-05-11 10:54 ` Andy Shevchenko [this message]
2026-05-17 13:41 ` [PATCH v2 0/2] firewire: Simplify storing pointers in device id struct Takashi Sakamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agG1bE_1RfrUR7zm@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=christian.ehrhardt@codasip.com \
--cc=clemens@ladisch.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=lk@c--e.de \
--cc=o-takashi@sakamocchi.jp \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®