From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Stepan Ionichev <sozdayvek@gmail.com>
Cc: Michael.Hennerich@analog.com, nuno.sa@analog.com,
lars@metafoo.de, jic23@kernel.org, dlechner@baylibre.com,
andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: ad7768-1: GPIO reset path delays do not match the datasheet
Date: Wed, 13 May 2026 23:37:14 +0300 [thread overview]
Message-ID: <agTg-nZyXIJCjW6k@ashevche-desk.local> (raw)
In-Reply-To: <20260513150042.10939-1-sozdayvek@gmail.com>
On Wed, May 13, 2026 at 08:00:42PM +0500, Stepan Ionichev wrote:
> Reading drivers/iio/adc/ad7768-1.c I noticed the GPIO reset path
> uses two bare fsleep() calls that seem to disagree with the AD7768-1
> datasheet (Rev. B). I do not have AD7768-1 hardware to test this,
> so I am reporting it rather than sending a patch -- maybe someone
> with a board can verify and fix.
...
> I am happy to send the patch myself if someone with hardware
> confirms it does not regress -- I would rather not submit an
> untested timing change blind.
This is ADI chip, right? We have a few senior developers from there in this ML,
let's ask them!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-05-13 20:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 15:00 Stepan Ionichev
2026-05-13 20:37 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agTg-nZyXIJCjW6k@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=sozdayvek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®