From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andrew Jones <andrew.jones@linux.dev>
Cc: linux-kernel@vger.kernel.org, apw@canonical.com, joe@perches.com,
dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com
Subject: Re: [PATCH] checkpatch: warn on uppercase N/Y/M as Kconfig tristate literals
Date: Thu, 14 May 2026 00:03:28 +0300 [thread overview]
Message-ID: <agTnIOAhw-zu9-9A@ashevche-desk.local> (raw)
In-Reply-To: <20260513205745.636737-1-andrew.jones@linux.dev>
On Wed, May 13, 2026 at 03:57:45PM -0500, Andrew Jones wrote:
> Kconfig tristate literals are always lowercase ('n', 'y', 'm') and
> uppercase N/Y/M are not Kconfig reserved words. Since undefined
> symbols evaluate to 'n', writing 'default Y' or 'default M' silently
> produces 'n' instead of 'y'/'m'. 'default N' happens to produce the
> right value but is still invalid syntax.
>
> Add a warning for N/Y/M in Kconfig expressions found by following
> the same preprocessing logic used by the Kconfig parser itself.
>
> This new warning was inspired by work done for [1].
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-05-13 21:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 20:57 Andrew Jones
2026-05-13 21:03 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agTnIOAhw-zu9-9A@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=andrew.jones@linux.dev \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®