From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012060.outbound.protection.outlook.com [52.101.43.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52D213563C7 for ; Fri, 22 May 2026 05:09:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.60 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779426550; cv=fail; b=kijoYFZz2gqHP7oC5LGKr87pvhvYog6LIG6ot/pK5Hy34fSSj6FvNV7J8RPwI72dD5yTrTxs5dyIsor/iUJWnTsbeLHpL5JWzTuAWM6SzNFKnF+LyUlQ6kZ5Dpy1PlMpU3GndPqWbBx98v0yeaROhhfqqRUL9sibRjoX1/tT3U8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779426550; c=relaxed/simple; bh=vNL5ia2F52Q/DcR3+M4GSYjU6KbJTYwQp0YzoAu3ne4=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=UE5pz06arZG7BHaOIUBe+k/HiCAv327VZ449pNMRtkUbQd7EBzsx/NZ1R9ZX3d60HcSQveRnDXZFb55603F1Q5D/y4aIfPP0I9pYjB7D31ZJloZdm8dlcRATUJB+K2G/UmLo/rI2/4rPNEbFB2V0Aiotnf0oMUJH9msE82deuLk= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=af3QusYr; arc=fail smtp.client-ip=52.101.43.60 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="af3QusYr" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RU2J05eJUpTwZgzfW841KkyOG3IXCTc79+ifXFRW+38KlDVvQwQKVvhXJ8CLiuqaPT6jWQyBbsInxvpk0vfXfAtq0qSHt7mgxWeuc+W5RtbFSBtBf/lZ2jReSrDCHjOxvqPn0rMZ1aOZeB5QYNk79O38yyICFX/onjbYxW+oEV2PcXAMUjOQu0+1oolMiWTYRW29glIw0vKtYEqT0n/66YDZeSauRjx9cP6Dq+Jd1ijiusdiJ4GkzFtv8oo8+wtjV/y1vPjknyUiVoZSxmoTthQqc9PZKZZO/HrrmLi3wlE1n163FtC2jz50P41bCljw/804TnqdRHEBajquj/NkNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I/vI+nhGkG9hx/HCUQZ8dbKkOiexswykI0MLlHtpX5Q=; b=EV/at0QSqFRoUFKQhTLUwvTHhs47SMZAyPZr6vIngGfs1KWDjTh6s41dmhh0y8MZfrozNq2HQJwULHk8AIJ2iAG89Cembp0SBOzl9B+q8CGTIyaazcs4Gy7LX1Q/Qb+ob0zV8EU0V8qrVGKWEFXNPaKBbT3vjajF9Hm+no1fiLVjyTUqMEegjdgw5FaINyAO2ud1HB7dBtN2IZblALv33t2COQCa3pbzzgEu04X05mQUo6/mlXSyhTqctYp7em29co1nUQ98AxCPxZBFPCyqkBvKJRqAdhSKr0HEeVX8woD+3zHzABA9OrzFnkzaxzvYuPT5b77pF0jGjl08bG/gBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I/vI+nhGkG9hx/HCUQZ8dbKkOiexswykI0MLlHtpX5Q=; b=af3QusYrK0r5Tv/J/+RJTZEY/QiYqPps/q6MCIBLNI8sh0+K6h6vDPBESFG0YqDGZY7ibnkNtgCGnnXbkf0iL2W5/AHkH16YI211kMXH4K5LYwYN883Pyfr/hjndvfSaBbmST6lKWVjcmFTFqryi0nN/O/Ztn3NCHVqHVWym17ZXelvVBc7fQk0WqgwZrG78zY6b59a/hA3mhnY0i1XQR+5AgORgHYYmCgThtD+oLnZRSARSkqFAAsUhVHFinoSDbe+cWzeKgCrpEoXG+tiPEgqtpfLXSx7WDgnrQgwNCA1uzZxypOtJ9u3u9j7XyZhUm/0C9bpzBTpdCjX4vrdPDw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB4827.namprd12.prod.outlook.com (2603:10b6:5:1d6::14) by IA0PR12MB8352.namprd12.prod.outlook.com (2603:10b6:208:3dd::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.48.17; Fri, 22 May 2026 05:09:01 +0000 Received: from DM6PR12MB4827.namprd12.prod.outlook.com ([fe80::6261:3040:864b:159c]) by DM6PR12MB4827.namprd12.prod.outlook.com ([fe80::6261:3040:864b:159c%4]) with mapi id 15.21.0048.016; Fri, 22 May 2026 05:09:00 +0000 Date: Fri, 22 May 2026 07:08:51 +0200 From: Andrea Righi To: K Prateek Nayak Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Marek Szyprowski , linux-kernel@vger.kernel.org Subject: Re: [PATCH] sched/fair: Restore RCU read lock in set_cpu_sd_state_{busy,idle}() Message-ID: References: <20260521205115.1689545-1-arighi@nvidia.com> <375744de-2587-477c-ad4a-9eff22a5b4b9@amd.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <375744de-2587-477c-ad4a-9eff22a5b4b9@amd.com> X-ClientProxiedBy: MI2PEPF00000B83.ITAP293.PROD.OUTLOOK.COM (2603:10a6:298:1::419) To DM6PR12MB4827.namprd12.prod.outlook.com (2603:10b6:5:1d6::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4827:EE_|IA0PR12MB8352:EE_ X-MS-Office365-Filtering-Correlation-Id: e7ac956a-2475-476d-6b5d-08deb7c03bd1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|366016|1800799024|11063799006|4143699003|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: X6BpnhTjUkYYUjxfGLxqeQYYnuhO1mlVvkpVTh9JPmZ9ylbT8gcnDj5QX5AM6Skp/wGv6s27B7zXA9M9QJSk8Wxp8GfcE6u59/jW2vOd8t9vKNZsH308G2Th0YWY74oREiq+jQNT4/wu30uHi8Sdopnf3QXcQTZEFT5NeyNxv+X2GzPwAbUpvNaJjaub/mi2qyuj5loYLZux9jpCq8QA5HDKN/O53ah/IduSTMSCgjRReWXhqI8vPG7XaxiRbE3NkmuAEbszXLg+sIjjCgU/kVTWBUvsJipZCvOwkDSh0b5j1wlpUEUYIqTYluoTp1oQwJ6lWDer3ObFzjLdvXoH0OrN/dSgT3A+W7xi4BEUrbpDe1CXUoF4sxrgTNWFhrAzm2wQzjtzzKTvumLbFZcA4SaqdNYVDTkAjfoushRp/eqNvtTYOkPIwlsvCdr23I1/uo+9MeJU61FMX64YPT6ypt0IpYkkYEqrxU2EZjNDEIOsIHJ6gUbJ4Ks+1Dd+y/ki0urlsQPzYcp6pioCzVv3Nld2HzTqS0DAeDNTPXDVNvk3HNKo5FQ/7HfmFQXhEwhKCp9SemYXf88CZpeSR23vZVfx5KrDgXgqy60orWI3zgEOgjIKXqSApNH6h9og46Um0ljW/AaYdZkhSWdSBVGw/kS2aXiPZNEkTA2EqKMVB7Pa2Kq5U8NYV8tStLX69RNR X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4827.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(366016)(1800799024)(11063799006)(4143699003)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wJrVMWCiMSl6Mk+mgIpMKQCyECY7MSe/YmWZ2IVoUnZeKaAWiqDXbmmTw0Vj?= =?us-ascii?Q?V+40HoFA2Genuo9MJpxdjKcXv8iCG9G5x5PSQDSfxd0zwSGeygiS0pmVmfe+?= =?us-ascii?Q?FfxFtznBioCHqW4MWZEtciuAmFkenHBQmUWwHi/+ImAJ+vawTng6LrVYK6Hl?= =?us-ascii?Q?Q4sM/YZYskjV01LzXcf1dn485IR9bTIrbtuQSjuYxPRBj+HeI8IVt66EeRAF?= =?us-ascii?Q?0vs0JZOLakRftXDwZvfU5ltSKtWXCwQRZDMCiGaRg/3Dp/04TpJmFy6HkgAG?= =?us-ascii?Q?ePTjQGjNf5rySekixyqBVdI/PHRX+b2G8P2ii+y/0ekqG4vzANSgpE3hX2Fx?= =?us-ascii?Q?RFU0ghogk5mIkai5HyFvp0/xbkbNcUecHgUGc4HaN0BGxpcW8qvsKjeIbscv?= =?us-ascii?Q?Z1mh8oEBhlvPZBR7RhyglUZiGdZpqHss14XrubT6SPQyAfi7YUDEXWiaaj+J?= =?us-ascii?Q?rs1pg4R/xZtbz2WirmeK92LN2T7h2qhtAuyOeK7uS2T3clzeNT5fFHTIH9qF?= =?us-ascii?Q?LJyMdM3g1mI+TR8E7lhyskGEq5gb1AqvVRO60eq4o2ahVvPYHkjERWzGYa7U?= =?us-ascii?Q?dfimJiDdLFUCZwJlWleKkgpuwlHsqynxMfzMtLmdP+kfTow9hI0sYn7+jwJj?= =?us-ascii?Q?R6FfHiu7XEpZ3M8npPoLSq+8U5ULRrxp4r2HUqOdYbLwTO35vPUYtZkSLRPv?= =?us-ascii?Q?JtouKx83sYzijhEbdhkAmhnmvgzaL6r92cIf+CXgoXLYKScTbc8EY2wOayeg?= =?us-ascii?Q?LKnB8vO4R6yFB/VbzvIYmsXW28Mtew7ayZ3P3bVrbKgCBQuk+nOzpr6vyPui?= =?us-ascii?Q?gNpn0zVhSxvWfucDTXkaGVaLhsHsLxvG2VZKfQAkAVTJTa3j3n+Sknol5/m+?= =?us-ascii?Q?XYcU8wX1KL4pfx3q4fLBdu0grIDbYNjJ5BNAXCRVnyzsmxTOLjtWavNEDTGR?= =?us-ascii?Q?4vIgtzbJuL9qzwXwNXqtW37Y0stvSOuQttImTJImucZeftDPOllVOFrtkl4u?= =?us-ascii?Q?trRzC4xX8P5+UzeVEO7q2lknQ/kmUdHksq7OdqDD7XFWVczaf1wYVUWQ23bF?= =?us-ascii?Q?FTHJ7d190orkldLMslLVu2k2iBzpZsLID0NOt3w1hrpgZ5pTbI8Gjb1sT07r?= =?us-ascii?Q?+Dz6LG+vBZX7jamw7mhkwDmYYoitM6sUk3wXLBt7srUcj6nN5YRwKJ9wRh+k?= =?us-ascii?Q?eed2bKknSkMDz5CBl6ONLyMif0puEd4lW8qqk6/8JiD4QNpAH7B1krXEpGj8?= =?us-ascii?Q?xae9HDCxaRwUHcttjIBH6BXHr0J1SCaarB3GlmAV+cYvAzwHkpnnxoWtxw6b?= =?us-ascii?Q?QvWQV6LDUCW9YYUesLg+PEliwW3NQH6/BmVAM8v/r2yY6xknJZqQyqwVSzT9?= =?us-ascii?Q?F7gnjeqlN08il0lL4Rb/oimOLfxK29j475YDT5pn/m00unonVskFlvmLjXwR?= =?us-ascii?Q?8LA4aONs+lPE1jTr/KdVRUGrSWJJZ/DMB0D/MArrQtC8IxXekHAVMjr0+z4Y?= =?us-ascii?Q?giFLGDg3Jxo7ppAacI9OVj6d6mPOR1uPTTfnsT65K8ZIDZbtoyP4gzemZ3Ho?= =?us-ascii?Q?OlYhXLkZWja94cPjJfv+gwdU7UkdJO1C0XhtB6f7LR7IsHj5GOuhzVuXjbO8?= =?us-ascii?Q?fzuI4lydEHRVTxI67UxhI/ZYolYb6jnjUtHUHlUehyNxB55ayKOFAICo90zM?= =?us-ascii?Q?7E0Zbl+1TMIdjDFEXakJNn3Q4EnJrdOITq4zXH0jDjigFFlv7Hb+RVlfSku3?= =?us-ascii?Q?Snj814CcuA=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: e7ac956a-2475-476d-6b5d-08deb7c03bd1 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4827.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2026 05:09:00.5367 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LZ9T8XpDpoxwiHtTdSdOlT6nxB4k0e2j3VxkGoSv5Yn8IgWN82KFvNpy8yR+1zX6buex+CYH9uTmfpDqVTSz1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8352 On Fri, May 22, 2026 at 09:44:15AM +0530, K Prateek Nayak wrote: > Hello Andrea, > > On 5/22/2026 2:21 AM, Andrea Righi wrote: > > @@ -14070,6 +14070,8 @@ static void nohz_balancer_kick(struct rq *rq) > > static void set_cpu_sd_state_busy(int cpu) > > { > > struct sched_domain *sd; > > + > > + rcu_read_lock(); > > guard(rcu)() saves on the need for an unlock label but this works fine > too. Feel free to include: > > Reviewed-by: K Prateek Nayak Ah yes, could be a good opportunity to switch to guard(rcu)(), I'll send a v2. Thanks, -Andrea > > > sd = rcu_dereference_all(per_cpu(sd_llc, cpu)); > > > > /* > -- > Thanks and Regards, > Prateek >