From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CC243A0B39 for ; Fri, 22 May 2026 05:35:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779428156; cv=none; b=lMku+ZVyasU13tFqTVO9oJFRJ6Vmvg9UZpH/exYFhCnRFv2BO3Q3JvLwKVKndIKIxzyXuO1VEGGf34MLJ0OhDXVuV4+JH33wIlAej/+13hH9tAfii/JRfeR5YAKJv9WsMK5272XzevY72ybkpKnZ7qMphMwOO17VPPcxo4Oq1og= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779428156; c=relaxed/simple; bh=tcec3sDKMqBqgAYrgEhHY06LBuZ2HogGmYwlwz9vjsM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Y++2C5Aqo/eSSLtxFhniiPEYsy02LzlQX+zt5WvXXdaS4pT81TAWQ6thPmhR6OoRvalGSy33cKp8CYEe44jCOjjyD0mdipSzMVNN4PusQnjnbm02JPZ4fvU0l0ZIaVZmLqNLO58QTxuVo95FJStHbs+kbQxBO+av4p1HVv8jB6g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qcadXFER; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qcadXFER" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-48ff4f8ef0dso73935905e9.3 for ; Thu, 21 May 2026 22:35:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779428151; x=1780032951; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=X6P8i4+hxrVSvyhHSAfNJJWz98Pd2QFGALJK0/zV9FM=; b=qcadXFERpfzSHfsF+sV+svfZmpg0e4wDu5FZHS15JD04lBltEm9eQ4YzvcGs7rnt9X 0Px0lKttX7YEukysNtrAscvmi4dyc2y0QoZtmSmTiR3zALWofaUwJoadBUsz0ftyQnnu pw2xq5gmp9TY46r48Ofa2sn4GUEn0t2CGbRgmIkMx3nw1dpbXUCO/gNEga6fE/5fl1Vh qzbshhXVp7x7mQXF1DT6m8rZ44jrcJ9QB+kHhfpFzYsBbhCKQiKXdVJApkPOggl5Thf1 E6gkGdp2IkDWZfGCilS/NfjQ5rW45PI/jw48BylO6YQAy9SRglRvt0j/yzheUvtD1FpW G7yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779428151; x=1780032951; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=X6P8i4+hxrVSvyhHSAfNJJWz98Pd2QFGALJK0/zV9FM=; b=pIESU5CQn+nOr/G55K+bGosKASxdsV58Kb+AvFPHXz1MtFO2Zs9bhAnPLQ9IV3BU/v NX8vePMPy3/yjQkPSJIfAtDJtzKRZCuk776BAJuTOl8K74scyMD2Ko2K8XacLh9HxTq/ eGNXF0HpbfVM0HK9pZp9/vwMZ5rIt2MGXHtVfwoBwgncZASAsX2aqn691shFdQD+Mj02 pXWUeAoSCAngVOjkQ7MncbOBx1JVciEAFtmy7d2H7yf2450INF1WctOTEf0rhHgQ0Wqx PjIcL9sgEm9CsbXri6g/4u+TFAcg+yYSZjXudpTVNoIGLXbtUj7s8r7CVfXNRrb/nfsQ 09Eg== X-Forwarded-Encrypted: i=1; AFNElJ+9aZXb9scZVIOAtHZu3UTiU86ayDOeg0KQsKaK2R4mN3UZk50NeYm7bg5qSRH/nVtJ+kVM1HSLNulEJEU=@vger.kernel.org X-Gm-Message-State: AOJu0YyhiVIBp2MCO2hjdbAAmGvLj+HPwFGovCYf9RGy/fEANJDunhO7 POeTfzeuhrpi0HXWgXkDcyNQcBaSGQpNRBTHEtz/6PB84S5CtHV52dCP X-Gm-Gg: Acq92OHgV0sIHKscrHGKq1ZlVEyn4OgwYGl1T6CztjvleKYoBKWF5DJiH5oRH/aOr/Y krn9imKVLBE05FpO1BgqXiqexTTSiu6EcHtHwstY9GDwSjNAkT1DQXa4WloHQ7x5G2MEiPhiaHp CC7oUusoFRkFdKpgIRCQW7ePbiz51bH6tk/BswxlkbS6zJQoBR1OH2mH2tLjxqfffMhS763119+ O5/hyt+E+Ba5Ty9Wodfg+OZ99zY+NQvWqTsDidF8s9aZnHV7YvHOc4xX2IGVpQ+gzHExTi5yr1G u/GoOIgvYzq4hB6lqrTRKvnVcxhwyGgd9YOxH0smQVkXR8yXCU1l3/S1sYOMc7nr9CgcQHOBOtu FIgE+mdLc/aNPCuznpOv3j9vuC90Q2wE/ZE0mX97c1/jcgihjzLIew28NKT6S5kUlVCQPDWyBUE 3lW983gVXrVAiL2DBPLh60KfYcdxI7g7Zjeg== X-Received: by 2002:a05:600c:3542:b0:48f:d1b8:9a9c with SMTP id 5b1f17b1804b1-49042482812mr25713405e9.7.1779428150667; Thu, 21 May 2026 22:35:50 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eb6d5cb76sm1148504f8f.25.2026.05.21.22.35.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 22:35:50 -0700 (PDT) Date: Fri, 22 May 2026 08:35:46 +0300 From: Dan Carpenter To: Diego Fernando Mancera =?iso-8859-1?Q?G=F3mez?= Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, m.steinmoetzger@gmail.com, guojy.bj@gmail.com, straube.linux@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rtl8723bs: clean up if-else logic in odm_HWConfig.c Message-ID: References: <20260522050429.161273-1-diegomancera.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260522050429.161273-1-diegomancera.dev@gmail.com> On Thu, May 21, 2026 at 11:04:29PM -0600, Diego Fernando Mancera Gómez wrote: > Refactored redundant if-else blocks to a cleaner else-if structure in > odm_HWConfig.c and fixed indentation to use tabs as required by the > kernel coding style. > > Signed-off-by: Diego Fernando Mancera Gómez > --- https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ Please wait a day between resends. > drivers/staging/rtl8723bs/hal/odm_HWConfig.c | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c > index c88d669cb086..2e47734a0ae9 100644 > --- a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c > +++ b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c > @@ -228,18 +228,11 @@ static void odm_rx_phy_status_parsing(struct dm_odm_t *dm_odm, > odm_parsing_cfo(dm_odm, pkt_info, phy_sta_rpt->path_cfotail); > } > > - /* > - * UI BSS List signal strength(in percentage), make it good > - * looking, from 0~100. > - * It is assigned to the BSS List in GetValueFromBeaconOrProbeRsp(). > - */ > - if (is_cck_rate) { > + if (is_cck_rate) > phy_info->signal_strength = (u8)(odm_signal_scale_mapping(dm_odm, pwdb_all)); > - } else { > - if (rf_rx_num != 0) { > - phy_info->signal_strength = (u8)(odm_signal_scale_mapping(dm_odm, total_rssi /= rf_rx_num)); > - } > - } > + else if (rf_rx_num != 0) > + phy_info->signal_strength = (u8)(odm_signal_scale_mapping(dm_odm, total_rssi /= rf_rx_num)); > + No need for this extra blank line. > } regards, dan carpenter > > static void odm_Process_RSSIForDM( > @@ -437,4 +430,3 @@ enum hal_status ODM_ConfigBBWithHeaderFile( > > return HAL_STATUS_SUCCESS; > } > - > -- > 2.43.0 >