From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17FE53A543F for ; Fri, 22 May 2026 05:46:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779428806; cv=none; b=RXjpXm10u/jRPmR3Y0ac4Z+EfXPwJDBIIgQnmjrqFITKJmPiJBag4S2h72CuJo/JQWajSaSR/tNvhU49FtMNGxuvIwKXSahcgpruH0uuKNn/qEVZlCbOxhlxqgktlQakDXDgZcS4AmBAHWMiuSDbFMN9h1LtjB7IejaTAGk8SA8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779428806; c=relaxed/simple; bh=Xmv8mBKPsyMDrUEDHu80zKbnU3gJGwWlB1MFkTuVAdo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K93+nRYNT8/bljmNPe9W/ipeeNV8TqjvStdFsBJZX1xLZr3my09tPOWewph3baYtID6iSmx9F/E2wak6OV0+mBGWSMigQCG6s5NYCGgDq56B/7iWdpswDafA630pwlR6x6ImADOKj2IZxSC49Mb9YWHorgL+51gqsgzDubYmaUo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f2AiNy+z; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f2AiNy+z" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-48ff4f8ef0dso74019045e9.3 for ; Thu, 21 May 2026 22:46:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779428803; x=1780033603; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=31ue1Zh9pFxr8D8zxe79RAZgaCD+VgqlmuwvC7B7MSE=; b=f2AiNy+z7vyDB8pWsW81gkbKqpKiyHpOK3oXOHoo8YnO17Cw5tay73RIfQZnuQ6r2x C5y0cnbOmuR/UnxaQT2vfHgexXeP5MDIYXZ52/2kr5hhh7Ut/uyJ6Y9f7DJwAomauZQi tdf4PVIMfjs+NSC0/3dn+E6N6XtQb5rCt54ZOACTrQmC8BCQtI75Vlnt1Pui+4HZq6qK VkiyDj+J3/JqnfRMmPG8v2nsh3Al3vRmfOA81OWHlsy/RxZxhLS93QQLpacEUVSIUZBY GEzfWLnxYw4CHNwTiqPSqp+SE7wKBsQk/H0cMJkTLooZoKTEnTJaH3KLmwmOhlqttwtb hxoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779428803; x=1780033603; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=31ue1Zh9pFxr8D8zxe79RAZgaCD+VgqlmuwvC7B7MSE=; b=VglG/tUDceL1c2zOfo1tJq7r0Ug+NVqKVZpDyOLUQGQQOeYp0KDqwKtl0JCM+4wMtX 2uWFFWyj+56IP4QhoavVcHtvUmV/IHLS0FM7+K7eta8Sbus1oBQc/EeS18jASCD+FMYd 3TgQa/prl3OXHvP3bgIvTrNoOm342SL8u8Sq3SDQouYz7isM88K2akke5vSKvn1UP30i S5yX0VSqhkK5fcTCfnUfPEvUSH3M1HQzM6tQPWtI4nfsAfL0xcCRvdj9lKWlJyvDP4dF djjIW8HKaJMjIRJTJarQWdfikcAu/xBqzuYCwCXIoWzLqEt957+YIaAZQuvoBvLO4hQ1 qrAg== X-Forwarded-Encrypted: i=1; AFNElJ+KAdRh9XW7Gqa2F2SdMFxkw+6bPetRXq1+8srDoNtahIGvqqXgATzHNHAXEGMxSm+EQ29MO51ueolJsXg=@vger.kernel.org X-Gm-Message-State: AOJu0YyP1bf6oC7MhBThSHQl0+5bMJNrgjumb5hECOM6EfEl8ghwRvkJ RxvrD4u1dZAOpv+zHNAFJnVCjvvBAy5PIbmaB27SYdmmGZaDsMmNHj/i X-Gm-Gg: Acq92OEoUF59V1kCsI1nEJNHOmPnsklyyw3EfYyzzfXnHcjQkTUmoXVxa0VmmtmW2wI 45fJq27hY4xovP5TBAzEnWWLKvXhk9w6EISQZ+vH7Xf/tZutA3G7qmY46zxKLeV/8Pwg61LnlVu U522m2HuEdjSohNCXTYUlY/wh2Ebm3GiPCYGuy2QwxzmJg3zp4H4oOksxQnXbS7EQWGeAZAbR5+ 9ySh5qzug4Vh1x7g789u35EtzqmPPiN48EYHlFqUegjVTo86+qxzd8jGHF7VdkhqxP6nSMHVOrX opXEf2abhIH/zhYf70bUnV56ANM8XPBB2o25sSqnz0n+kDepnwi1DFhip+Tv5KyPQOw/Zmn4gfy SFAVnRwG7swIelvrMPQfX7q/T71rcP5Gw+3iKRe1XtQJkgzW1fLFCYXWTHCLbjM3jRq0xcJa/nY 1wZPmDI1/ZHEUWzHTgFPbPxIVu0hFM8RJJHw== X-Received: by 2002:a05:600c:4510:b0:48f:d5d7:df63 with SMTP id 5b1f17b1804b1-490428dfd36mr22647375e9.27.1779428803527; Thu, 21 May 2026 22:46:43 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490417a2814sm10130675e9.6.2026.05.21.22.46.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 22:46:43 -0700 (PDT) Date: Fri, 22 May 2026 08:46:40 +0300 From: Dan Carpenter To: omkarbhor4011@gmail.com Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: fix operator spacing Message-ID: References: <20260522053854.188893-1-omkarbhor4011@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260522053854.188893-1-omkarbhor4011@gmail.com> On Fri, May 22, 2026 at 11:08:54AM +0530, omkarbhor4011@gmail.com wrote: > @@ -1888,7 +1888,7 @@ void rtl8723b_fill_fake_txdesc( > if (IsPsPoll) { > SET_TX_DESC_NAV_USE_HDR_8723B(pDesc, 1); > } else { > - SET_TX_DESC_HWSEQ_EN_8723B(pDesc, 1); /* Hw set sequence number */ > + SET_TX_DESC_HWSEQ_EN_8723B(pDesc, 1); Why delete the comment? regards, dan carpenter > SET_TX_DESC_HWSEQ_SEL_8723B(pDesc, 0); > }