From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D2AB3A543F for ; Fri, 22 May 2026 05:54:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779429285; cv=none; b=jmMUz0pV/zgmj4rDMHUh6npAvwzUIjamuOwaDr1N9GxpLAS9UzbutS/uS5wDtya4mGnKszXwGIkxaYJCQ6bTzBg+tJ8nP16IsodcIN61hiULEcXAr1bkn5VFO2FZnkKLzkgjVQ0QU52LeQu1hSjV8BQJTNEEOGhOhCk6CxwBrsI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779429285; c=relaxed/simple; bh=MLQYd1TUEGsy+swWeSk2UksjEW87jp4XumqdcQEBfz4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JSYOm7YgbXAnRXQpDg+I3nkkEP5JDK8e32H1y/2WD/l1jI5ig/sVCElBep6cQ5IX+JknEEsbVuNLEIdhPjf5uC9jug+0vdQ+5nTGBqKIdrji6gVSbGRzHWRHrE0rKQWU6zyVL/MXEBHHqtCqmvo4ZjMxd6kg3XaEcrtrmQXAnME= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZZih5rDw; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZZih5rDw" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-488a8ca4aadso67490005e9.3 for ; Thu, 21 May 2026 22:54:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779429282; x=1780034082; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rmwOasrsN6EcgHg6fWX9JfwqT/CPvGQqU71BhvD3KlA=; b=ZZih5rDwOUTEOJ9as+KoJMX4Nd99IKISEVhXcmvTzsBhMrsaxMtD+WhSHnywqS07ee pAffeH98KpkzynKrbecQjmgQsLD006BesxBhDwr1Wrs4nNe9f+FAYqFzT6HUeBhQpi8C K/211M8qTt2tV000RiAPOM7Ti+JxZ73RkFTuRUPH9ihvRgj/AVUURLg5g6IXEk5qxYZ4 I5S7W7to/5uK1kG2BTeDdyC5Sxs3H28VYDquHWO8VllJUSZXiB8n5j1vxnO0YEnoT6mn CPmVqhFqsuq5h9m5OqtjG+seoHS8WlC6Dh4nln5AWbHKwozbhQJR4fcx1tj4shJdhIRF Hz/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779429282; x=1780034082; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rmwOasrsN6EcgHg6fWX9JfwqT/CPvGQqU71BhvD3KlA=; b=RD7ZNa8y9TCXleuI1ygply5wB20y+cpk/46CS1flJ32OqicwB8YreuuzTKD9lHguaY lQBmEZyI8eyJQEgCkBonveaSbEbIIZNlDf6BFZOmPHBSKbNZdGFWwaD/VskWaBdtMFnz IoKQn7ljAmxBEH/F26QBQh50PHhTTX6WnrL7NqBFOg3U6J3p2deJKQSqxa4mjeJJxOwX GcxwndEh3j/KVB1+laQidB/MBoFfNHwtCREqh1hg4FdO6s7q/HCgTAtqc48uO2r/mk0L f540WFrTEkZ2IrUCJhBx2lX+0PJ7Sq26aia/WseJSS4X3Z3vYcWAxAB48NDgGN7CYyPQ h/LA== X-Forwarded-Encrypted: i=1; AFNElJ/ukwjH1bkGYU0jxT7NbmJk36KWe1Etb3ixwvoyERUY6Qren+MFw+gNKmNkgz1FFjI4b4Pek1j4TEwdvkw=@vger.kernel.org X-Gm-Message-State: AOJu0YxLZDnvyIXGd3xpkw6vHoNFhEUS34LPfL5bbUXm8xa/SLN5ZQld b83pIILYSQ/5BSpMYwz44FWHKngxwP9+v6Dlk+leEZZML7Er8nYjLtqM X-Gm-Gg: Acq92OGwnOvFu4LVUlhMGj32KPlwbgmi55qoNoWpWKCFNfExm9DeNOScKA2CiAoWqch aPKQKskysb9cNR9JlyBI6XrEnWi1xII4V+rHMYXhZ6sxcKt4rvPOOlI+e0hp2dq2tKyqc0zTJ+c /UUBB316c3LwYNfgt6WxmR2ff5QCMCwQ1j8zhggsjf+n1eYg2ctlvGDVI83YVqPZr9tg6wcDgSF uRFNbSgOvlAtGoWxLogfO13iTOS4ItOsxYon9kq6ivPCdMns+hEGb3102UjdRzLSGdUm21SpTtH yakbqd0IAnv7llp670reXwfK3blUaE03e79OcstOKyZNndYlTHh7Je0widKXOCO37tYGYxfWbGQ 7obNlHMpCBI56tBB+EtqOCrYDxx55912K0UBZnoW2c7Rstzs2CNuyRanKbWo1R8s17GOl0KdpBT 89bTKLpOK56AmFRbAVqE4NtZU= X-Received: by 2002:a05:600c:4f0b:b0:485:46fd:7887 with SMTP id 5b1f17b1804b1-490426a699cmr22262945e9.13.1779429281797; Thu, 21 May 2026 22:54:41 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4904527f7f7sm34162465e9.7.2026.05.21.22.54.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 22:54:41 -0700 (PDT) Date: Fri, 22 May 2026 08:54:38 +0300 From: Dan Carpenter To: Pang-Chun Liu Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: remove unused rtl8192c function declarations Message-ID: References: <20260521144113.28869-1-kevin95120@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260521144113.28869-1-kevin95120@gmail.com> On Thu, May 21, 2026 at 10:41:12PM +0800, Pang-Chun Liu wrote: > rtl8192c_translate_rx_signal_stuff() and rtl8192c_query_rx_desc_status() > are declared in rtl8192c_recv.h but neither has a definition anywhere > in the driver, and there are no callers. Remove the dead declarations. > > Signed-off-by: Pang-Chun Liu > --- This kind of commit doesn't get a Fixes tag since it's not a bug, but I'm always interested to see how mistakes happen. It's better if the commit message can say which commit added it. In this case the dead code was added when we initially merged the driver so it's fine. Reviewed-by: Dan Carpenter regards, dan carpenter