From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8247A3033FC for ; Fri, 15 May 2026 05:23:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778822621; cv=none; b=MGi4qUZjnvcjsZ43wVC1CKUbveqnfq12qj6JQ9zoQkw05zHK+xLhwgI0kzmX+qru/Cujl2HKDGutcBpyCAe9Evf+v+c0Xdh2sN0abAV2olG3u/fpmCoQ+TI6KfvOhofUIbC1cwYp/BfAaqpACVff3k0NGyHj+ph2IqMv296v/yk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778822621; c=relaxed/simple; bh=ixr6UTkPaqIoywLFWnbYraaAvOuKOaos+d5WnYABLqg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gmg//RIOQeV1iIOBtATydskOqNsFJ70YK4H85YFk99Eo+0wP03n7Pxr+PY4ZbhvaBedGsf0q5wd7JE5/rX5WCwIB2v4eQyIhyWNP8LqbypjLCWbUkDCYFko49/8fScLaoxKW8eyu2SdqiyR0U4hLEy8DTdkYdncgqk1zYLYRo9s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YXS/9HyI; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YXS/9HyI" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-c801b30188dso3925292a12.3 for ; Thu, 14 May 2026 22:23:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778822620; x=1779427420; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GpC4Sy2ohSEgf27E/5DP9PBOmyJ/jHfS/ZObuxuM5HM=; b=YXS/9HyII+gjNAw7nos9AiSFiNG/l83Aq/THq5ma6LQjB33zPfZfPVLZT1CwaLTT78 vNg+93x8CIAiQ0+hndlVgdTgnRY+2H8SUnfqh/Hna0bPe+aBzDY4baPFDW6DYrBwvJvd JT0QFjAEFLchJ3bHGUHdTfaBRKZdtBSBpZsSUMGi0k5EMhfXk1601zulPaaduWrEyffZ 5n1/C6vH9NBPuWMbexIbKR7jU/Z7b9xgSugJVTvG3xrza3oY4g21yLzFlXuNlRWrIaDE MhKeUQhkBg9Dvh4hk5S/FP/oLymazQb8ipDlE5rgpdeGASqpPATlMG7ctfnhgDpAlBCy tGPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778822620; x=1779427420; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GpC4Sy2ohSEgf27E/5DP9PBOmyJ/jHfS/ZObuxuM5HM=; b=LzHiBQN1d+KXIIHWyioq0xwGkDXNTwUBvMIJA4Y7WQ97KkFE0NIbXJ7B5iYxD7yDpD k0IW007+8zHc68WHYPBSNOHxiA4qZdS4osp1Ui4UvJ1NVdzuNOZVoHwioGuz4zIo+6Lv i9JBGxoqXrEc/wCp2djkWpMbnPXPVrPTuKOMuYD8W+4ow3Ot+aJDaxEsF5G0lDj59t9t aqzfvAHIWilCEyvtEEgcnXN0yCHh2E5OmvzW8fg4sCxX+Tanr4lcyIKmoBxRDjDTouXG lwF/zXhrvhZ8qYOxCXbzgPMS74ESb1Iu7ojPqdt1WQSeEliIFrroznRcF4mjmVtlzg5Q ZLHw== X-Forwarded-Encrypted: i=1; AFNElJ+83TPp4MxB2aaTdvMsIkIEX2f1XP/1qWTFrKyoC4NLLKROOi0PEpqN7gzzGxnpUaky8SidMxtm2OnJig4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3ppWbjAuFvpVqQ/9cDI3LoKHU4QMdzj0FWoBBBIoP6RFQc+B7 5xKfzo02WewED9K0p6KRaZcr2rYP9Gb0HneHEaY/0MU/GcxCiZ++XZsT X-Gm-Gg: Acq92OG8LHir8jIDgsl4A4Gjo9A8zu7KV/NI09F0BUbl7oyTsfapBQ/aDItaTfNOm6m QAVlaVOVBoolmNqDCkV4HSFoAyBqxqjd5P55QDk0cZhnbEpTPngAs8Utao9Fm+X7E05xR45Ju/0 6mlyDNnMTMjth4F250Y9diyIo3uhD7K6Wjg+aKuaOgZaNtwBfYFkq3RF2SNmugNCgx6vYuC6uf5 u4uhgqCAUZWbzfjZmBSKWoQ53dyfr+NfXQY5h6IJdvSuyLPnoqknUFOEFZfvRDnOV27SWPSs2rh hhoX/EBFzRXCXoWaguy1GrV/IYTX90c/YifTFdMneaQEnEsnweCdhzQXItRcJ1mKhgfvMhBmome oXy+adlfOKpimuPsOuietIbMk+OWaKc3K2lFZukAiJD/MRy+S1WsnCq5Kmwl1AcBkqshQsBbLxf pJb9PHe/+YyJbKRXvN4ftUjNx/e5U= X-Received: by 2002:a05:6a00:2a08:b0:82f:72e6:ed4 with SMTP id d2e1a72fcca58-83f33a18fcdmr2722540b3a.0.1778822619721; Thu, 14 May 2026 22:23:39 -0700 (PDT) Received: from soyboi ([2402:8780:1073:dc10:22f6:2ac0:a51b:5d77]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f1942a83fsm4766005b3a.0.2026.05.14.22.23.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 22:23:39 -0700 (PDT) Date: Fri, 15 May 2026 12:23:34 +0700 From: Robertus Diawan Chris To: Amirreza Zarrabi Cc: jens.wiklander@linaro.org, sumit.garg@kernel.org, linux-arm-msm@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, me@brighamcampbell.com Subject: Re: [PATCH] tee: qcomtee: add missing va_end in early return qcomtee_object_user_init() Message-ID: References: <20260513091031.145826-1-robertusdchris@gmail.com> <8182784b-b6c2-4136-af8d-3aea4f5a4662@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8182784b-b6c2-4136-af8d-3aea4f5a4662@oss.qualcomm.com> Hello Amir, On Fri, May 15, 2026 at 11:31:50AM +1000, Amirreza Zarrabi wrote: > On 5/13/2026 7:10 PM, Robertus Diawan Chris wrote: > > qcomtee_object_user_init() is a variadic function and when the function > > return because there's no dispatch callback in QCOMTEE_OBJECT_TYPE_CB > > case, there's no va_end to cleanup "ap" object initialized by va_start > > and that can cause undefined behavior. So make sure to use va_end before > > returning the error code when there's no dispatch callback. > > > > This is reported by Coverity Scan as "Missing varargs init or cleanup". > > > > Fixes: d6e290837e50 ("tee: add Qualcomm TEE driver") > > Signed-off-by: Robertus Diawan Chris > > --- > > I don't have the device, so I am not sure how to test this change. > > Thank you. > > > > drivers/tee/qcomtee/core.c | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/tee/qcomtee/core.c b/drivers/tee/qcomtee/core.c > > index b1cb50e434f0..901a31e8201f 100644 > > --- a/drivers/tee/qcomtee/core.c > > +++ b/drivers/tee/qcomtee/core.c > > @@ -306,8 +306,10 @@ int qcomtee_object_user_init(struct qcomtee_object *object, > > break; > > case QCOMTEE_OBJECT_TYPE_CB: > > object->ops = ops; > > - if (!object->ops->dispatch) > > - return -EINVAL; > > + if (!object->ops->dispatch) { > > + ret = -EINVAL; > > + goto out; > > + } > > > > /* If failed, "no-name". */ > > object->name = kvasprintf_const(GFP_KERNEL, fmt, ap); > > @@ -320,6 +322,8 @@ int qcomtee_object_user_init(struct qcomtee_object *object, > > default: > > ret = -EINVAL; > > } > > + > > +out: > > va_end(ap); > > > > return ret; > > > > base-commit: 5d6919055dec134de3c40167a490f33c74c12581 > > Hi, > > Forgot to mention: how about using a break instead of a goto. Oh right. In this case, using "break" statement is enough. I will send the v2 of the patch. Maybe something like this: if (!object->ops->dispatch) { ret = -EINVAL; break; } and then remove the "out" label. > Then feel free to add Reviewed-by. I want to confirm first, if I changed the patch using "break" statement, do I need to add "Reviewed-by" tag in the v2 of the patch or not? I am still not sure when to add "Reviewed-by" tag, like can we add "Reviewed-by" tag when we changed the patch? Thank you. Best regards, Robertus Diawan Chris