From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42BD33EFFD0 for ; Fri, 15 May 2026 15:41:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778859692; cv=none; b=XjKGXtTxeeUItZnpzzcR3riD+J6VC+hfi4hA4JcBGalzFZB0y1uxSE66xZQ/CEbA22NlxWquqK8Oq0LHSLHba6PwvxFTXf1ghANIC1IHZrxRqiFv633nbrxSgoelpWAjBX3G2cSGplmdvW6lKu0L/zslIPnk+Zw1Cr94saOARP4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778859692; c=relaxed/simple; bh=Pc3MpCtVK8p6OudMDqnhjwapWxM0T8CO+YFnhbV1T6I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cAgr74Sy4IqSr3COO/s7gYSPJCMLTOW+SaK8Jg+UhkoHqqqo7GUKFCIN1jqKHIeJEQ2TVmPigy67zzw0Duqmplp7RF5TdNMaMfgSF3d8Nh2Akjnt/OoTPuNrmt3NkQyOtwtPdB0EqXFugNOYK1PhKxnEa+frUW645+5ukJN28u8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VIadg89s; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XI/ZNVF8; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VIadg89s"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XI/ZNVF8" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64FBOE3R4020774 for ; Fri, 15 May 2026 15:41:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=48QgJCSDGrxZEEMu60fAJNCo YBZQJr3kDDsz/0EEYCc=; b=VIadg89sDaZvWClueo52v1sDS1B/qTeTPu3I8+xq +s/bqhRXAb5w1C4wkhNEn34mfKed25guHcntxkeO0pduG/MoaWA9I9x/7l8jDC0k vU5XBfJI9CZPjB1EuDsWhcNxP/XQI7IYGiKe/QaqhVmcFBJ7aqtWAhrfmoPV0Hl3 5HDE9Z8kdazyRMV11Ifumjyr9HYYY90gm9y/jdFI97gDG8QA8HW2x04tityde85h CYqSpRrNz8qWSf4aV7MO2MXW+mQrKQwW/Pt9/0xU5DNzh3MZFKm25+2atgUNyev/ HnQB3ojb0tOelxpO5NgTLLoksTYR42yIGmqxkFK3CcZnyw== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e5m1ruv26-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 15 May 2026 15:41:28 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-82f9429f49cso11929300b3a.3 for ; Fri, 15 May 2026 08:41:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778859688; x=1779464488; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=48QgJCSDGrxZEEMu60fAJNCoYBZQJr3kDDsz/0EEYCc=; b=XI/ZNVF84nrZAKcRgX8L0pw/ZhBrb9nZQW2EQJb9/YeXNbu1asTxQ+W0m/ZWOow+tX hj1bCTApP7OWJ8iAEmUNs+4sPeFug9/98ORqW9d56sK8FM0Nmm8GeccSHhIW+LpzsCM5 EjTlLG/HwLGFUQCpQ/8/gcFGdYLzPNVQm3QkBzpWgtBI7C0QTah6DJoCFiQ6/+yRb/p6 OK2qfIMvYk414Gb6sUwVKOAsKrQ8d6GpjORw/qofvkL5m7k0c7WzFoc1IWbdYnlHxsTv S5xpjtnW8Kzhe/DBTni+8MWwtkOQ/9F405Ob8jpniZIVs80ywcij9mKTkmzirDWWyjY9 jUyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778859688; x=1779464488; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=48QgJCSDGrxZEEMu60fAJNCoYBZQJr3kDDsz/0EEYCc=; b=UZ8ylFVoZ3jb31+drg41C/lFU6vc1qdLIFlvuHJd3Hs+c2ANP15M1QLbDuWpKJuZA0 OJDQqn1s3INK6zwHbm2/I9bkXgBMFi/JlgKWWAyYo9+sTRA84BTvt8Q2rfqTeL1hkydl kEXih3maBLajVADdLWt/022UoCHWWfYCWTX75XcR/MR+ZR7W+WDTukAljGCqaOgmW8G3 vobgbqUIt5HUVD5WnvjpYN7/5TFjIhxoNL5fEEoL1NnW0B52rS8Tr9P/x9qPzCDXhW2U xI7jDNPYsMmCUoJi/KQbEgUqF1z58/DeG9QaVhDRaI7wS235fAbUC8cC96JYQTa6YgzS rekg== X-Forwarded-Encrypted: i=1; AFNElJ+MBCLZBjwGxZnODQrq+9r6lhs/Idjcl5bwhSvle3VjO4+5ySQWJCKTgZd4LyxlibAZwB2PWcCtaW4LJHg=@vger.kernel.org X-Gm-Message-State: AOJu0YxST8WKVpk2xVXBnvftPoiBvNz2gcmhKgcrVZ1VJ0z6agxZ22hE JRK/CEs8JgVIPBLXB+Aewh52phEMnnzagk3f0MQrCUzfnb6ssu1hu+n7920YKuZVZwzhOS+LU3/ I/AzNSAYoP2EMviNvtOu1uw3GK1nnxb1CX6oogWjZ1pgpy99tMO33YWbzfiXPNttT3H4= X-Gm-Gg: Acq92OHtRHPs4FRB7OqT+w1qnrYbl20mv23qAYtESVQ9MFVNTAOLiYql5Ck5wdITEyC FPjOGTm1Zf+qSnHHJh+464HTLVH/B1p9XNmfdvZ3aRFOLf1jxm6kr0OFezVNclMRrdbkl/n9kB0 2iiLIoAELWgLm7R3sRWbuVnvlfyCH3qsEaEfpTAHAP6zLjxVDzEVEQZeNlN4yp2RJJyk1V3u8yq 2XTDKSU2HjCozAH5Co7oK/nAMgGMQwyJ53A4/bls1w6pEBJh1OvJEkyOuwIYKNDqTs0tzl7MiY2 k86zmDThynFzinbJpdFUQHsno+pYqLTILoOe6/6ZsjLipxmF3C9U5iXPtBt2MDmPtj6QsiS6BUB G3+4h7PyYwoRtKiM/78dZ8HwSLAK9YuvHF96+ex7zLVqI0wbUGGGxn3WXd8nRiK2lDESRkTTPjD zi1N/NIJWwELP9p3dFH48H+9esHm3hhO2+SrKqseF4rLH5wVYK7Ew= X-Received: by 2002:a05:6a00:3e22:b0:839:dd77:3501 with SMTP id d2e1a72fcca58-83f33c33546mr4982588b3a.1.1778859687688; Fri, 15 May 2026 08:41:27 -0700 (PDT) X-Received: by 2002:a05:6a00:3e22:b0:839:dd77:3501 with SMTP id d2e1a72fcca58-83f33c33546mr4982557b3a.1.1778859687257; Fri, 15 May 2026 08:41:27 -0700 (PDT) Received: from hu-varada-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19c5c39esm7532977b3a.36.2026.05.15.08.41.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 08:41:26 -0700 (PDT) Date: Fri, 15 May 2026 21:11:19 +0530 From: Varadarajan Narayanan To: Dmitry Baryshkov Cc: Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Michael Turquette , Stephen Boyd , Brian Masney , Konrad Dybcio , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 2/3] clk: qcom: ipq5210: Use icc-clk for enabling NoC related clocks Message-ID: References: <20260514-icc-ipq5210-v1-0-b5070dfbe460@oss.qualcomm.com> <20260514-icc-ipq5210-v1-2-b5070dfbe460@oss.qualcomm.com> <5zdmbj56ndi7nrvdqadinrf3sneywft3uaplnoxugp5zetsfbj@5hazmuzyfz7u> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5zdmbj56ndi7nrvdqadinrf3sneywft3uaplnoxugp5zetsfbj@5hazmuzyfz7u> X-Proofpoint-GUID: kM7EPgYvPqZhRmarJZyVmWBIVIC8CPG_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE1MDE2MCBTYWx0ZWRfX5SzksYB76Z2y q/6JexD+R3oA5TQI4SXXITcbx1/sdxMJ06HCIdqEJxDiskvskD2XlWx9WayxG6DmDDHstNQQ7u4 DTDGNiyksaw9CIVpO8m0C6AbS+HvntSgQ5Dsd6zZ/PhIMosrewavzUljnJIrNlnsn0eak7918P7 Cu/TFfs5TEC3KwiVOMiTvxgYOTF/fO85CU64UrSoMMrPXm5jM2ajos91CHlvRFByZQ7Vac/Udv+ sUDjPk1MeH0PFkY3gPRxi5mRDwyJg7tFS3j9+S5o1+Zyip1Op+gLtzd8TfU/EV+OzU4RzDNoxD2 brJKcOTnLMpJItIpqvAqCT9Hj+kaFzLh2roA1DMLEhjkbPJ38r8JxJoCV7jDt8tR+b7i+XrveH8 z/+uA75wraZNw+T5Vn6T6AAwCHn6uhMw2A99bnlWNbsax5yU9KQPq0kxVzxnbLykI561E6/1lXN X0kw2F2522T7Z7apqXQ== X-Proofpoint-ORIG-GUID: kM7EPgYvPqZhRmarJZyVmWBIVIC8CPG_ X-Authority-Analysis: v=2.4 cv=JPELdcKb c=1 sm=1 tr=0 ts=6a073ea8 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=kj9zAlcOel0A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=jBAFZfc0v9Tf_D0DgaEA:9 a=CjuIK1q_8ugA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-15_03,2026-05-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 phishscore=0 priorityscore=1501 spamscore=0 malwarescore=0 suspectscore=0 impostorscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605150160 On Fri, May 15, 2026 at 04:31:42PM +0300, Dmitry Baryshkov wrote: > On Thu, May 14, 2026 at 09:35:36AM +0530, Varadarajan Narayanan wrote: > > Use the icc-clk framework to enable few clocks to be able to > > create paths and use the peripherals connected on those NoCs. > > > > Signed-off-by: Varadarajan Narayanan > > --- > > drivers/clk/qcom/gcc-ipq5210.c | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > @@ -2642,6 +2657,7 @@ static struct platform_driver gcc_ipq5210_driver = { > > .driver = { > > .name = "qcom,gcc-ipq5210", > > .of_match_table = gcc_ipq5210_match_table, > > + .sync_state = icc_sync_state, > > in Kconfig: > > select INTERCONNECT > > OR > > depends on INTERCONNECT In drivers/clk/qcom/Kconfig, IPQ_GCC_5210 can be selected only if COMMON_CLK_QCOM is enabled. COMMON_CLK_QCOM selects both INTERCONNECT and INTERCONNECT_CLK. Is select (or) depends INTERCONNECT still needed for IPQ_GCC_5210. Please let me know. Thanks Varada