From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Maxwell Doose" <m32285159@gmail.com>,
"Tomasz Duszynski" <tduszyns@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] iio: chemical: sps30: Replace manual locking with RAII locking
Date: Sun, 17 May 2026 11:05:35 +0300 [thread overview]
Message-ID: <agl2z1XM69s8bz89@ashevche-desk.local> (raw)
In-Reply-To: <20260515155721.0097be34@jic23-huawei>
On Fri, May 15, 2026 at 03:57:21PM +0100, Jonathan Cameron wrote:
> On Fri, 15 May 2026 09:35:03 -0500
> Maxwell Doose <m32285159@gmail.com> wrote:
> > On Fri, May 15, 2026 at 9:18 AM Jonathan Cameron <jic23@kernel.org> wrote:
...
> > TBH I'm fairly confused on what Andy wanted in terms of "what do I
> > wrap". If he wants me to put the guard()() into the function call
> > itself I can do that but see the (ps) in my other email.
>
> I guess you mean:
> Andy:
> "Ah, I was under impression that this is (unlocked version) is used somewhere
> else. Since it's not the case, the wrapper is not needed, just use guard()()
> in the original code."
>
> Could be read either way but I think he'll be fine with it in sps30_do_meas()
> even if the other direction was what he was thinking of.
Sorry for the confusion. Either just put a guard()() into the original function
(whatever its name is) or into a wrapper. I.o.w. as Jonathan said I'm fine with
both approaches.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-05-17 8:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 3:13 Maxwell Doose
2026-05-15 14:18 ` Jonathan Cameron
2026-05-15 14:35 ` Maxwell Doose
2026-05-15 14:57 ` Jonathan Cameron
2026-05-17 8:05 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agl2z1XM69s8bz89@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m32285159@gmail.com \
--cc=nuno.sa@analog.com \
--cc=tduszyns@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox