From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 069E02E7162 for ; Sun, 17 May 2026 05:51:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778997108; cv=none; b=nZLk28+xURgZo+R50/H3FkrNJJoQvoDbVcRRlG98wr9c/3TCApIZdRTeHr38vM5ebiSZEDI7YZ1KpWnO2J43CalehiF3IILuEUCMyn91l4G6mmhYmH/qBK+mvFCVrfpaCV2rU+GslqYjX1yMENtKNIiP3zD23DVjRN44VZyX0hI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778997108; c=relaxed/simple; bh=aixuvkrs2BsiYljN9atBNQCUjxdFPnZIZsMqZlq21Go=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Vsgk71Y8NLrv8DSqEmQ9vfJED8Z3UrWuz2+E52cHk9bk3OgpH1JEwYMW7AtC8xa8E5rka2fcEGBpUqFLmOUOzlkirKiYI4L0ZExBCyHIJky0Sp22x2N3ubJ4tgb+aNy17xGApGx5U+ZK7u9SWmtfKlrs/q5QvEkp+MjcRu0D/JU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=doYyAFmk; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="doYyAFmk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778997107; x=1810533107; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=aixuvkrs2BsiYljN9atBNQCUjxdFPnZIZsMqZlq21Go=; b=doYyAFmkyz0qSAHTvWy06+bj2i81VWAxknt95kH4U/Sg78kwFlP7bGI0 Sy31w871vLDS2GcA0iPRQsuiBTyLvN52xQ00NdgqVaFe3Z/3f/56c942J gpG3veXxQkEjRtMixIqZJbU9AyX7jSbazLdbV8f9e4EX1nBbsjrpvtDC3 by8aIATwLA0/xsNSfJ0CLAlV8ysLSsYRyEC67KPNFFei2/Sp1zWWd+wmW v/9Tn0aRK6B80ILAwmUPPN3Ylak99uyL+RgbN0sRfjjKzO9c10Em9w29D tC35v4ZaNrG1vKiQqIXxauUVZn974qBPdFkIRGzh063fiXPxUdGEuiN8z Q==; X-CSE-ConnectionGUID: sQ6U1yrUQ3uDBySJ48CVYg== X-CSE-MsgGUID: XWUOIlBeTMC8yMW1SfC59A== X-IronPort-AV: E=McAfee;i="6800,10657,11788"; a="80010805" X-IronPort-AV: E=Sophos;i="6.23,239,1770624000"; d="scan'208";a="80010805" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2026 22:51:46 -0700 X-CSE-ConnectionGUID: dV2cBYD8Rn257s07pJrbhw== X-CSE-MsgGUID: ZcOM2BZnSuattwTZmOZTXA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,239,1770624000"; d="scan'208";a="234647684" Received: from slindbla-desk.ger.corp.intel.com (HELO localhost) ([10.245.245.182]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2026 22:51:45 -0700 Date: Sun, 17 May 2026 08:51:42 +0300 From: Andy Shevchenko To: Stepan Ionichev Cc: andy@kernel.org, geert@linux-m68k.org, gregkh@linuxfoundation.org, hcazarim@yahoo.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] auxdisplay: Kconfig: drop unneeded quotes in PANEL_BOOT_MESSAGE dep Message-ID: References: <20260515133005.32305-1-sozdayvek@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260515133005.32305-1-sozdayvek@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Fri, May 15, 2026 at 06:30:04PM +0500, Stepan Ionichev wrote: > The PANEL_BOOT_MESSAGE dependency uses a quoted-string comparison > against the PANEL_CHANGE_MESSAGE bool symbol: > > depends on PANEL_CHANGE_MESSAGE="y" > > This is the only such pattern under drivers/auxdisplay/ (grep shows > no other Kconfig file in the tree uses depends on FOO="y" with > quotes for a plain bool symbol). The quoted form is parsed by > Kconfig but is not idiomatic; the common form for the same intent > is the unquoted tristate-style dependency: > > depends on PANEL_CHANGE_MESSAGE Strictly speaking we need to have =y in case if PANEL_CHANGE_MESSAGE becomes a tristate. But I don't believe it will ever happen IRL. > which evaluates true when PANEL_CHANGE_MESSAGE is y or m. Since > PANEL_CHANGE_MESSAGE is declared as bool (not tristate), there is > no behaviour change in practice: y is the only enabled value > either form can match. > > Drop the quoted comparison so the dependency matches the prevailing > kernel Kconfig style and so it is obvious to readers that the > comparison works. Thanks, I'm going to apply this. -- With Best Regards, Andy Shevchenko