From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4F9F2E414 for ; Sun, 17 May 2026 05:58:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778997488; cv=none; b=kDzzmZQDhlSFnWTY7GfRgQ6zLDLhhMuMibbqxOxxwZ+ZrJIRIPEwxGTIFdIBKWgt9sNHsMYDPz2XyO95u6U0P4Iw61j8EC5DlXyGlNMjwtrwouS4SFWvCtE3DQStpnX/lKNH7R1DD5qhs9e1tKyKGv7NaSndEzXefehqnAP3iww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778997488; c=relaxed/simple; bh=hggCNjdjgG1IwRGf4DiIK3WHTWz5BXUFng4E0Z1RjmA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=a/FifB8OFkUEwcHks3ZEtU44DxVetPN6wALThn39KMbA4xa0SPKEMQTtiX7Haa0aAhizWGTylzGRP1p7yQt9fxLPGzLUtYtUWHzW+FJI80HlwVq7zVAeCSAHK2+O9hUdjA+VnPqkvSU/hbUnRtymvIM5eIw8arVNMqspapXmGmM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=WE/100G/; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="WE/100G/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778997486; x=1810533486; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=hggCNjdjgG1IwRGf4DiIK3WHTWz5BXUFng4E0Z1RjmA=; b=WE/100G/dqBC/nSz21yFdHrvGF6bkOujfxaewrqoLVSPwfqqJsRQNiv9 n+zqEU+fd/KJIlaMAPRbjD4O0OLEP7wtXO2va28h/qDE1y/YVsqbGfXtb GJ/TfmMtcT5cFql645wX3tx2lz9lxZsIOK1Do8+W4+5pOUWHaEe1IlAhD P85xHeGz9UB7QPWeDpK3DgTqxob4RDII53VqzdrYU3V4slHnwjAK3CI3M m+KTxVLT0ZHvb8L6tBxjJdEYoIuQnnm2QlZnberrtod3b18xzwn6wybwN QyIUw0/2etqIlm/YxaEDTBqjZzRBSaDu6pZxLVu5r4sPoDMCoMaZT5p/z Q==; X-CSE-ConnectionGUID: P32DfSFtRWq+74iqORqapA== X-CSE-MsgGUID: rmtUm2gJSGSidI7P0zXNNw== X-IronPort-AV: E=McAfee;i="6800,10657,11788"; a="90467682" X-IronPort-AV: E=Sophos;i="6.23,239,1770624000"; d="scan'208";a="90467682" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2026 22:58:06 -0700 X-CSE-ConnectionGUID: 5hYIjRBJS0apxxbP3usuBQ== X-CSE-MsgGUID: X+8v1VYBSnqFSfkCjM+9Qw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,239,1770624000"; d="scan'208";a="238226676" Received: from slindbla-desk.ger.corp.intel.com (HELO localhost) ([10.245.245.182]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2026 22:58:04 -0700 Date: Sun, 17 May 2026 08:58:01 +0300 From: Andy Shevchenko To: Stepan Ionichev Cc: andy@kernel.org, geert@linux-m68k.org, gregkh@linuxfoundation.org, hcazarim@yahoo.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] auxdisplay: Kconfig: drop unneeded quotes in PANEL_BOOT_MESSAGE dep Message-ID: References: <20260515133005.32305-1-sozdayvek@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260515133005.32305-1-sozdayvek@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Fri, May 15, 2026 at 06:30:04PM +0500, Stepan Ionichev wrote: > The PANEL_BOOT_MESSAGE dependency uses a quoted-string comparison > against the PANEL_CHANGE_MESSAGE bool symbol: > > depends on PANEL_CHANGE_MESSAGE="y" > > This is the only such pattern under drivers/auxdisplay/ (grep shows > no other Kconfig file in the tree uses depends on FOO="y" with > quotes for a plain bool symbol). The quoted form is parsed by > Kconfig but is not idiomatic; the common form for the same intent > is the unquoted tristate-style dependency: > > depends on PANEL_CHANGE_MESSAGE > > which evaluates true when PANEL_CHANGE_MESSAGE is y or m. Since > PANEL_CHANGE_MESSAGE is declared as bool (not tristate), there is > no behaviour change in practice: y is the only enabled value > either form can match. > > Drop the quoted comparison so the dependency matches the prevailing > kernel Kconfig style and so it is obvious to readers that the > comparison works. Pushed to my review and testing queue, thanks! -- With Best Regards, Andy Shevchenko