From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Stepan Ionichev <sozdayvek@gmail.com>
Cc: andy@kernel.org, mika.westerberg@linux.intel.com,
linusw@kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: intel: zero-initialize capability_offset[] in probe
Date: Sun, 17 May 2026 10:31:50 +0300 [thread overview]
Message-ID: <aglu5jy5SbW9Wjwj@ashevche-desk.local> (raw)
In-Reply-To: <20260515150049.33761-1-sozdayvek@gmail.com>
On Fri, May 15, 2026 at 08:00:49PM +0500, Stepan Ionichev wrote:
> intel_pinctrl_probe() declares a per-community capability_offset[]
> array on the stack and only writes the slots whose CAPLIST entries
> the device actually advertises:
Thanks, this is very long, but unfortunately bogus report.
So, here basically the summary is "Check if the HW is broken".
If the answer to that "yes", we have much bigger issues than
some parameter being precalculated. Besides that, have you checked
the code generation? Does compiler is stupid enough to calculate
base before any checks? It's quite clear that the first use of base
is the devm_pwm_lpss_probe(). Instead of this patch I can accept
one that splits definition and assignment and be like
void __iomem *base;
...
base = community->regs + capability_offset + 4;
chip = devm_pwm_lpss_probe(pctrl->dev, base, &info);
(without any Fixes tag).
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-05-17 7:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 15:00 Stepan Ionichev
2026-05-17 7:31 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aglu5jy5SbW9Wjwj@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=sozdayvek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®