From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 539792FFDD6 for ; Sun, 17 May 2026 20:19:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779049200; cv=none; b=V3Ym+lfPH3BXh6YgL3xis4ZCRFNN9WhRFxJTwlsnO66AaK3wtLnUcIJVFwhGUH1J+MLOASE6rcWfKj8Ova1tV+5Lmtwxq7tWZar64oJk5A/WcSB3zv0rvZDYc0LO++q1LOYIaZLlyW02XtmxmNBsc6a8Y/lypEVIyWnI4qfWz6g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779049200; c=relaxed/simple; bh=KN0a6nuhX5nWRhu85gb98t77AbTfd7ZdFz27bWhNg/I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VAA7FJjY0w7PbuL6VOlSLD1E80N2ihTdy3NO7az0C/gzyLbWn+VtNQWR09lAQ209K82MIPu27/M0L8Hm+YZ2+4JOgx839kJvXqR6ytnHLTKJvvkb+Ug6rLv2MuXejFm3jx5a5P+IccY67/xCj1nW3VMsJchPYg7sIqjpLhXc1nU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VZLvY6I1; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VZLvY6I1" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-c7980c060cfso567601a12.2 for ; Sun, 17 May 2026 13:19:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779049199; x=1779653999; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xAdsDoDnh5G8WxjQFs9oyIfSvq1lXarEEXfQD3J2Ugc=; b=VZLvY6I1G9SbV1i3iG89Nzu3oK1y1Du9xussEaRhwXHphG7NZUcWpOQIl/IWJDIzOO OIR+L7F6NH3QWoZbBO9TrciWjyY1vVqybw9h9v8s+B7njnfLX95us0cE7rFgJ7FrZ4Hh oU9fQYv0T1dZQVpNVV7mxDgbE9lmT7WmVw4i3knTTqrNl6r7wJE0BXv954f8lvfC0lXG N6BqmptWAAZJaUWYnRbKHwCB+u2IqT8X37Bz/PyACdqnElvUzay+c/2ZQKe/QBJkqdGj Urc0y12GRX7v69IzmLI0D1C045LiGRhLFHfWrK+qe05zrwpLVQ/N5AJRv9KjAvBaO3DP FjTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779049199; x=1779653999; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xAdsDoDnh5G8WxjQFs9oyIfSvq1lXarEEXfQD3J2Ugc=; b=kD0ugEw/U4lHh8u5aUWi6Mbm6CjL+16gUgDznNV+T8hXl11Yb4kueL5KC54MfDd1FY /cTPnJISRnos771dgfP2BNCTH8PdXdW28PMteBsw3MgMxPxUO9nmCSnPIRJuMaPRNrYu nQ8RfOttjK603XXUI5sgAcQ5N/6WyP3Ulfxh+yhAW3kjZtxktF73/2d1C16XBGBAuebw VH1DFXcHO9KMy32j3bXdV/hMPWLuU+3U6adW58aE/2HNoOAtP/C9cpnNINZ+k9KGJgeF A91yNYDj2Y96gz8F2G2Rl/TSh5/p6zjcbAZ2MhhW6PfO/ONwPyiYM05MAjWRt/625XNQ dpkg== X-Forwarded-Encrypted: i=1; AFNElJ8jPynG03Xe66GZdNfqlLV0jxajnd9oHjZd7SNuFgwOQpKwvgu4TROJj9Sxr/wsg0xBV27qePw2DzMt7As=@vger.kernel.org X-Gm-Message-State: AOJu0YxdZYh5HPOF0YAYSzlIo6T1JE7XdoHvjQJg8s81JOBEDCiqOXVW uIXB7awno0VO/7dLManwJjvEG/GrV3r7o/9as2D3PY2qgnLwKSlbTbct X-Gm-Gg: Acq92OFS1RSiwBQoJgWh3ojDFZfaGXzKrTZTAoKHOflMXOxiCS6XFozFSJIfRFS8ymF OUvzpjzsLJIMwT4m08/ofWOhCobFFW/ly4kS/bkEpMus09vRLFVxv1mJj419MaN3A6ar327/xBr 2hKHw2e0KoyVSa+3vi4C5RodCAcD4b/oMcuFZH57HblKj6Odpiw/z7lmuITR988qQz26N0EOzTK DPh0FsGzxp7/X02sUH6XmacSZ2z+3+y5qv0eJczPjXZkqN8JzO8qKW6wbjr3sqXL1cK0YtwWGC/ lB/q5woZ2gTfsRyjXUpEOa4bx1uy2SuW6W9iQOPaXMOKBxCzYq5D3jzeEnBLX/4xfX28EOEo10R /DBX/V9eWpo2Y3PDh3k7ZEOFNvsBoZj8dnpYDkSovqYEX02RsikJdWP914vrk5xZDBt1ORU/Tk0 nOs/gjFHutb8lpxI6VwmXQtCkF2qhTHGMmiY99t+H/XlRptka+Ql4= X-Received: by 2002:a05:6a00:2eaa:b0:837:e9cc:d460 with SMTP id d2e1a72fcca58-83f33c2a4b0mr11497444b3a.18.1779049198596; Sun, 17 May 2026 13:19:58 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19f7cca8sm12374941b3a.56.2026.05.17.13.19.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 13:19:57 -0700 (PDT) Date: Mon, 18 May 2026 01:49:51 +0530 From: Sanjay Chitroda To: "Zhang, Lixu" Cc: "jikos@kernel.org" , "jic23@kernel.org" , "srinivas.pandruvada@linux.intel.com" , "Lechner, David" , "nuno.sa@analog.com" , "andy@kernel.org" , "sakari.ailus@linux.intel.com" , "linux-input@vger.kernel.org" , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 0/9] iio: introduce devm_ API for hid sensro setup and cleanup Message-ID: References: <20260509101040.791404-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, May 14, 2026 at 02:47:52AM +0000, Zhang, Lixu wrote: > Tested-by: Zhang Lixu Hi Zhang, Thanks for the testing and validaiton. I hope you validated the complete series, including the unbind flow for the drivers using devm API. Hi Jonathan, How should we take this series forward? should I extend the series to cover remaining HID IIO drivers for this devm API, or this series can applied to IIO tree first and sent followup patches on top of that? Thanks, Sanjay > > >-----Original Message----- > >From: Sanjay Chitroda > >Sent: Saturday, May 9, 2026 6:11 PM > >To: jikos@kernel.org; jic23@kernel.org; srinivas.pandruvada@linux.intel.com > >Cc: Lechner, David ; nuno.sa@analog.com; > >andy@kernel.org; sanjayembeddedse@gmail.com; > >sakari.ailus@linux.intel.com; linux-input@vger.kernel.org; linux- > >iio@vger.kernel.org; linux-kernel@vger.kernel.org > >Subject: [PATCH v3 0/9] iio: introduce devm_ API for hid sensro setup and > >cleanup > > > >From: Sanjay Chitroda > > > >Key highlights: > >- Prepare change as pre-requisite for devm conversion for HID IIO > > drivers by removing redundant argument > >- Add devm API to setup trigger and clenaup resource using > > devm_add_action_or_reset() > >- few cleanup and prepratory changes before updating driver for devm_ > >- few sample driver update using devm conversion to auto release resource > > > >changes in v3: > >- Added cleanup and prepratory changes before adding devm_ API > > conversion based on self review: 0002, 0004, 0006, 0007 and 0008 > >- Address andy's review comment on commit message and coding style > >- v2 series -> https://lore.kernel.org/all/20260429175918.2541914-1- > >sanjayembedded@gmail.com/ > >changes in v2: > >- Following input from Jonathan and Andy, squash initial patch v1 > > series in single change as individual change should not break anything > >- Add devm API support and two driver using the same > >- v1 series -> https://lore.kernel.org/all/20260428071613.1134053-1- > >sanjayembedded@gmail.com/ > > > >Testing: > > - Compiled with W=1 > > - Build-tested on QEMU x86_64 > > > >Based on further feedback and reviews, I would extend this series to convert all > >HID IIO driver to use devm_* API. > > > >Thanks, > >Sanjay Chitroda > > > > > >Sanjay Chitroda (9): > > iio: hid-sensors: drop redundant iio_dev argument > > iio: hid-sensors: cleanup codestyle warning > > iio: hid-sensors: introduce device managed API > > iio: gyro: hid-sensor-gyro-3d: cleanup codestyle warning > > iio: gyro: hid-sensor-gyro-3d: drop hid_sensor_remove_trigger() using > > devm API > > iio: humidity: hid-sensor-humidity: cleanup codestyle check > > iio: humidity: hid-sensor-humidity: use common device for devres > > iio: humidity: hid-sensor-humidity: use local struct device > > iio: humidity: hid-sensor-humidity: drop hid_sensor_remove_trigger() > > using devm API > > > > drivers/iio/accel/hid-sensor-accel-3d.c | 4 +- > > .../common/hid-sensors/hid-sensor-trigger.c | 24 +++++++- > > .../common/hid-sensors/hid-sensor-trigger.h | 5 +- > > drivers/iio/gyro/hid-sensor-gyro-3d.c | 16 ++--- > > drivers/iio/humidity/hid-sensor-humidity.c | 61 +++++++++---------- > > drivers/iio/light/hid-sensor-als.c | 4 +- > > drivers/iio/light/hid-sensor-prox.c | 4 +- > > drivers/iio/magnetometer/hid-sensor-magn-3d.c | 4 +- > >drivers/iio/orientation/hid-sensor-incl-3d.c | 4 +- drivers/iio/orientation/hid- > >sensor-rotation.c | 4 +- .../position/hid-sensor-custom-intel-hinge.c | 4 +- > > drivers/iio/pressure/hid-sensor-press.c | 4 +- > > .../iio/temperature/hid-sensor-temperature.c | 4 +- > > 13 files changed, 78 insertions(+), 64 deletions(-) > > > > > >base-commit: 39b80c5c9830d12d2d6531059001301c4265322a > >-- > >2.34.1 > > >