From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F32E1A3160 for ; Mon, 18 May 2026 01:18:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779067129; cv=none; b=rGtWSgwvzjG0luMObvScHH7dn3uK2busVEng8FKxwWH/RB2rZCfpNYwYKQghumTj+Rdv3o2DpbsjHwoU8qOeSxFCyutuf9CQ0UhsxFOB+8sS8WTzkzAuba5G6ddXQCHIt6g7aeD3dJhrzKolJwOE9al7ct8cg1H/WBwV60QVnMM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779067129; c=relaxed/simple; bh=xv0S31PtwdmpQPHw0Fc3vOyQu5vNsfiZECnu7ZDWm6w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LvW8GL+fg7t3R3TiEQl3eaFdQvSkdqODu9qsVDajgUNm/ly+7mVe75L3Y3CyKn+D6mFvDNznjuALG3zCIq6fjVYKtIMwUrKV0EtwUXNeWkNzFOunOO+BvBQocIpPptFwtp5pdP+vKJu/t9Nbfox9obhVcnkJTb6xtdcrlqT6jYs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XkTbae6V; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XkTbae6V" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-83ef1d17904so1646019b3a.1 for ; Sun, 17 May 2026 18:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779067128; x=1779671928; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vrkXl/tb+VJX1ZNHX4vVsA7L7lm6KoE09cNj85XuTpU=; b=XkTbae6VmnbOyE7v7IRER4USm4lIo2IJiqmFgRaWmgSa1u5LZo7Cz5yahseIlzfJFO hfppM8pqkHJyT2YPKrchPw0AdZmOIKlaIe8zmiJj0gupVfrBkqG8LBmEIySIzNI26hP3 ZHj/BsWe+F7W5FPw7MBiu+8JfOV9bVh7uNY/z/mDx492caVZEW/Ke3xKDVB24GxXaqMe mR51lSVU6xSGLKsg9ZLiWjpJduQHI25KdXtv1QEP9q9cqUjBg3JOergT7tsCF4ATXj+X EpthtdDocffUGAa8yxxlAQmm6PbpNzJIv5XdAHM1f4SiJhlL0gj1PeQ4DFF7kw6NlkIP 8JsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779067128; x=1779671928; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vrkXl/tb+VJX1ZNHX4vVsA7L7lm6KoE09cNj85XuTpU=; b=AKbQ5p1tk/JxtJjKJn33aAXYkCd3KoXx2Ur00DyaLY1Gm7GL3rVWn3QZtOjTD8fMU7 PYOMv+ZtRoVoF1/ynBii5aHuADh4LJr2KGb/LMS+fmhB/hJwTmUbtdsHEVRUnRZRrY/6 P6J68q2CGmM9A3oys9r8PBKLoGEia7acDFfm7xXQTmaVt/qJ/kp9kyPrwAthqtvvz/jg prFvqVdv2TuZnuKYFYNzRRYAuIWm1mWCyphKPVDMXqGniHdskloyVv+hWqAIPVk3VRtd wrQvSvpUpdJo+p/GPG+oZHSRwBpdNiQqP9z5plRBSJvjllQt96mcm61SwVeiAT65KfMz UxvA== X-Forwarded-Encrypted: i=1; AFNElJ+OIb6YtRWp9vqzoheQ2vgFzTdUfbyA17J9XSNXxUN/lcq839CS8C0cy8TQ7KiVPf6P0W7Tybf9EclbUhU=@vger.kernel.org X-Gm-Message-State: AOJu0YyvQbxEW+fmrn/9e6HZsfTkDNaNkA4jhI0yzHLKUSbzEh0hOZ1/ u9YbVGUCnwPExeJ+iuyP36sO+a8Umb8+2/ZMZw6DrxTejKScC3zlgriR X-Gm-Gg: Acq92OEF2NvBjq/7v9ljcRWEIVOKllRufvAfRztXZ+XFKIPOQOAQ3M+6cYicboW//yn RxwBokF5AdP2e5B/tB4Y7wh8+l6WyzfYuIxYZkAUKKpkJqlNy/AALfm6HpkOoPmnNxPawAiOK3f acrWTSlTDbABOMPf4KQpTLL56GjDRTlGjZkqbsWUUsN4Zh95DEu1wFxgmSQmsOSEMGgpkPrnXqy u//MbXxi+mGbuZnEd8fmZ3lvti/NVsj8uVWkN9keHXuYBw7twgR1HaCbD3KqV54vZGUy2d4p4QW BKU5GebBXbnvdW4mIy2Z1LVCnoMXFMbvGAkNEi/EmmRW2oHCz18Rr904Q5t/o3nJ9ZpLoI7v+wP xGUSHU8EiJCOqwGPVKwUPiAF6vofSTvdTAwLYQS9VDD4LhnJM3axshQJyB/AJRf3k1me13IiulX icqiZTFRQWrt8VQvOGAigm5zM= X-Received: by 2002:a05:6a00:2908:b0:82a:6461:6d15 with SMTP id d2e1a72fcca58-83f33f166f9mr13591304b3a.46.1779067127790; Sun, 17 May 2026 18:18:47 -0700 (PDT) Received: from localhost ([2001:19f0:8001:1b2d:5400:5ff:fefa:a95d]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19778c87sm11922977b3a.19.2026.05.17.18.18.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 18:18:47 -0700 (PDT) Date: Mon, 18 May 2026 09:18:13 +0800 From: Inochi Amaoto To: Andy Shevchenko , Inochi Amaoto Cc: Jingoo Han , Manivannan Sadhasivam , Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Christian Bruel , Vincent Guittot , Senchuan Zhang , Alex Elder , Nam Cao , Siddharth Vadapalli , Randolph Lin , Vidya Sagar , Neil Armstrong , Gustavo Pimentel , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, Yixun Lan , Longbin Li Subject: Re: [PATCH v2 2/5] PCI: spacemit-k1: Add multiple PHY handles support Message-ID: References: <20260517014841.254085-1-inochiama@gmail.com> <20260517014841.254085-3-inochiama@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sun, May 17, 2026 at 11:07:40AM +0300, Andy Shevchenko wrote: > On Sun, May 17, 2026 at 09:48:37AM +0800, Inochi Amaoto wrote: > > The PCIe controller on Spacemit K3 may use multiple PHYs at the > > same time. The feature is not support by the current driver. > > So extend the PHY definition to support multiple PHY handles. > > ... > > > + k1->phy = devm_kmalloc_array(dev, 1, sizeof(*k1->phy), GFP_KERNEL); > > Hmm... What's the point in having _array(1) ? devm_kmalloc() should suffice. > Yes, you are right, I forgot it is "struct phy *", so the devm_kmalloc() is enough, will fix in the next version. Regards, Inochi > > + if (!k1->phy) > > + return -ENOMEM; > > -- > With Best Regards, > Andy Shevchenko > >