From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 333503C4B77 for ; Mon, 18 May 2026 05:54:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779083652; cv=none; b=HujS7NsZcMlLlBtGAmthPiJUBk2z95dFZZzCTEGfOWMQCbsbMhMlATnN9WopaeIozki3jAW7KD3K+PpnOUGlae8B0cAjqChIp7SQswew5s3q9oWyFhHK/TEnQWnhmN0ZW7XnPWPY7tI2cOcVvvWNy+tOu2LFomBWplQX9MU/sFA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779083652; c=relaxed/simple; bh=YtpqEH73oXHK47yZ5ixFx1FBt2jaIIXqgdKd4AtJuXk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=j9RpYt8zoMayG6YvZmUsBqYzZZyezW8JgNcYIqwjNSTRoWj3e/or8BiD1GqQAijmSiEuKnGukeZDnBgpbZ7XQgZebyYNxoF35IAZtPq35dpXGU88S09t48GzAUpyk5CjuOaRjXbHBkgpZGEAAlIKkj6wy5YtY4VsbL2NodJC6GA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VqzhjJoB; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VqzhjJoB" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-48e6db3ff7eso8098995e9.0 for ; Sun, 17 May 2026 22:54:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779083645; x=1779688445; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XE828kGQfB1YOLYw6olNLyuMatDEpOksBfYxDmp9B4s=; b=VqzhjJoBwc5Q7b7Htd3ohZQPcyb+NMw309Ttc2BOxVlAfzYIsAALbjF0pQjtenQiYJ x5FCZfIih78xb4g1QkzHAc44DwiU77w00b00OYdEyVSAAWof4M4YqGonDV4J92ZD5/Rm bqhg9bjyoCDrX0HU+vHaMYsDz2KR2O2MVVf6a3CYeBAyUKmsL39eoE1qPBWSL9F2Kk4M 212Bpp6Ld3WD0fWbrOR7cau5t0NoILNEaEru5ZKB2DxGMEh0VWDC4CeveBovFWArshik alzJ1VISqyu+eGafwpgvams0PlahzXyFAvOJAoveOujYDhboOMMs3g8nbF9TAd+fDFEN Aogg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779083645; x=1779688445; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XE828kGQfB1YOLYw6olNLyuMatDEpOksBfYxDmp9B4s=; b=Ezl/L1cVQr8LgSht+WT9J24KlSUZxT1C6x9hTqOBZTcMiAZyzTZMVRNFW8ZXe1Wv7m iZAfeYXiIE4FSAoFkbN3BEEvcFJ2Bl1aKERrogOa1ECSiSKWUkoOHJPpcjj3PnyEN2rs /crZxAteaAgDVbI7hrShqwO8ciIhP4mUhKQFCSHFFXC5nd0kQ9JkDbnE7JQi+NBY/Jz0 JtpZeTiDffViSmrCmLFOb1ji6/Jb6CUJWOEP1cvmY6cxcgVjUUeUAjwB6Ip397AZdV00 nD6MHi2tjTE8a2xAwC/lhaOXOO01ygzSrl+ERl45Sz8zGuSGT4wdxn6UK4rQ6i1B9XWm TzOA== X-Forwarded-Encrypted: i=1; AFNElJ95wtqomoP6K68TfPaRIGhA8Hl4qiB4pLVQiXSDPmIwyCwX172r2CippDsyCkQ1nPVSEGJr+tV8a2GMkLQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwtTer9kVb6Lcdg71PVxno1el2X5HMmLwPnXSrOY2ciznVa1e3v nx9ROsEW557KD+3EqRKKEOM8I8sk9lF1gdWOS8fj5RE/H7zIXPhxMjq2O429KA== X-Gm-Gg: Acq92OFWC1mGYBH6inGBXqOjZ5PaDqzYcXmML01jUm2uhkWVCqChnHX5d2gDwQDC3iK /yT59DnHUfxmOpbD1uzpkMMqArgVo621nViST51gfqcbytMiIYlxiWUCkza1tqtQnIapTfjalAz pH+PTbAr4KK6khRhQ7sUBRZx5JDvteiQ1Ob+OeXgtmzJAH9V8yzhAVR7OmznjiV8Kz9cE39FYqB rKki5e4Ybnm8INh7tAOCGmbYWNAjgLvU2g/DA/kXVYhiza5LkEnfXPVQ0UQGjdKVZ2hUTBfPCgf VX+fBd4rLpjk96RP8wxSZtIBwrXdcHBD9zyKtIAD9Ic4xqikrfEh+oelKf/Fc0exhqGUQb01J5o hNm/I9xdNqKwJmmeLGWhBg84EsFVzOZ/bS9B/idsm1WdCVavDjtFKRUmbPfLeXxD9aP7RvHxxmy SsFlL0v2rZXNgfqpH0+2k= X-Received: by 2002:a05:600c:470e:b0:48e:8741:fd3d with SMTP id 5b1f17b1804b1-48fe60ea21dmr185074965e9.14.1779083644768; Sun, 17 May 2026 22:54:04 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da15a5653sm35275603f8f.35.2026.05.17.22.54.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 22:54:04 -0700 (PDT) Date: Mon, 18 May 2026 08:54:01 +0300 From: Dan Carpenter To: shayderrr Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: octeon: fix carrier state, null guard, and modernize phy ioctl Message-ID: References: <20260517141955.79666-1-darknessshayder@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260517141955.79666-1-darknessshayder@gmail.com> On Sun, May 17, 2026 at 09:19:55AM -0500, shayderrr wrote: > From: Pranav Bajjuri > > Add netif_carrier_off() to cvm_oct_common_stop(), Why? Shouldn't this be in it's own patch? Do we need a Fixes tag? > guard > cvm_oct_adjust_link() against null phydev, Can this really happen or is this AI advice? Shouldn't this be in it's own patch? Do we need a Fixes tag? You have added a WARN_ON() which basically means reboot the kernel on most systems so it's discouraged as much as possible. > replace open-coded > ioctl checks with phy_do_ioctl_running(), Put this in its own patch. > and zero priv->link_info > on stop alongside last_link. Why? Shouldn't this be in it's own patch? Do we need a Fixes tag? regards, dan carpenter