mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Stepan Ionichev <sozdayvek@gmail.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
	andy@kernel.org, hcazarim@yahoo.com, gregkh@linuxfoundation.org,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: light: tsl2591: return actual error from probe IRQ failure
Date: Mon, 18 May 2026 10:37:45 +0300	[thread overview]
Message-ID: <agrBycM8s0Uy9LJQ@ashevche-desk.local> (raw)
In-Reply-To: <20260517181042.668-1-sozdayvek@gmail.com>

On Sun, May 17, 2026 at 11:10:42PM +0500, Stepan Ionichev wrote:
> When devm_request_threaded_irq() fails, probe calls dev_err_probe()
> but then returns -EINVAL, dropping the real error code and breaking
> the deferred-probe flow that dev_err_probe() handles for -EPROBE_DEFER.
> 
> Return the value from dev_err_probe() instead.

...

> -		if (ret) {
> -			dev_err_probe(&client->dev, ret, "IRQ request error\n");
> -			return -EINVAL;
> -		}
> +		if (ret)
> +			return dev_err_probe(&client->dev, ret, "IRQ request error\n");

Also remove dup message, at the end it should be

		if (ret)
			return ret;

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2026-05-18  7:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-17 18:10 Stepan Ionichev
2026-05-17 18:25 ` Joshua Crofts
2026-05-18  7:37 ` Andy Shevchenko [this message]
2026-05-18  9:43 ` [PATCH v2] " Stepan Ionichev
2026-05-18 15:40   ` Jonathan Cameron
2026-05-18 15:43     ` Jonathan Cameron
2026-06-03 17:23       ` Jonathan Cameron
2026-06-04  7:25         ` Andy Shevchenko
2026-06-04  7:26           ` Andy Shevchenko
2026-07-03 19:10             ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=agrBycM8s0Uy9LJQ@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hcazarim@yahoo.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=sozdayvek@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®