From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 028E731B830 for ; Mon, 18 May 2026 10:02:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779098537; cv=none; b=BK4WSaFPdnU+PgN893xZXLGQV/ryn3rkI9gg9GSQDp9O2PF8MFxoPBWtptW8Fz3Anglq5rZrGrB0asp+ewV4ICXT32U6Yvs6Xk8aM0ko6jZZ5IytIbAAisUS/NoDbewcg0of5ra+8KOGKq+5ck2gWIUfmRKSzYcHx5vCHRhcD+c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779098537; c=relaxed/simple; bh=245OjriimBApEADiIG9W2/9D46Eaq2BiEAto6PMcNmw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GfQ/ZdzItR7Ld/gd+1o2jK10H1B+CQrzuelXbfBpmqnJB3NXFf/4jQoEeXkb9eXYz6arYO+sC8CWsbAN1JIKXmVlgo/cUWOQpACM1vxSP7FqCjebmZn7Q9MRCHZ7r7uLGDmvJsnloWH7SvLxfLdodtOnFc5Es3dCFRoQ9MSUzUE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p15rCHeh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p15rCHeh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B3D1C2BCB7; Mon, 18 May 2026 10:02:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779098536; bh=245OjriimBApEADiIG9W2/9D46Eaq2BiEAto6PMcNmw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p15rCHehr95vaYiLupeX7YWH3GyKR55jTIISY6xUvjoiX1iaPu18zOGeAi9KY6vyq xupW8s/cAMawEJOH/pGX+3KaYckC6KPiMuvCGwSgoP3j1infTztKgNtvihrm4GThP+ ZPYGLNeDo1F9piLXcD5Hs7uLMX7YvsIH6BoByYwv1ZBT/1mF/tRJrkTjWdTL2Q+GES 010sajgQ7x+ugf1/8/bQ2kkAvX8+7103C3xemAZQA4UTBJJ7DBwzWSdgtRzyNx9O9Y e72A4qn6DEmuO/39oSBJdMdqdEzashtu2m69gzn6lEafTv8VghB1SWfq/k1ginhJ1j JTAzRiMiK7K5g== Date: Mon, 18 May 2026 11:02:10 +0100 From: Lorenzo Stoakes To: Thorsten Blum Cc: Andrew Morton , David Hildenbrand , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Yury Norov , Rasmus Villemoes , Andy Shevchenko , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/3] mm: move offset_in_page() to page_helpers.h Message-ID: References: <20260517123428.1181981-4-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260517123428.1181981-4-thorsten.blum@linux.dev> Seriously, please resend this. This is 3 patches with 2 in-reply-to 1/3, that's not how we do series in mm, take a look around :) Write a cover letter, and have all the patches in-reply-to that. Was there not previous versions of this? I _seem_ to remember that, but might be misremembering :) Also I'm really questioning the value of this, you've not sold why we should take this whatsoever. 'Add a random new header file we have to maintain because it's smaller' is not really hugely compelling. Also a _lot_ of stuff in the kernel ultimately pulls in mm.h. So what exactly has the specific requirement of both needing this define and (somehow) doesn't use mm? On Sun, May 17, 2026 at 02:34:29PM +0200, Thorsten Blum wrote: > Move offset_in_page() out of linux/mm.h so users that only need page > offset calculations can include this lightweight header instead of > pulling in all of linux/mm.h. What's the motivation? What caused you to want to do this? Why should we have a new tiny header with only this define? What makes that important? Why is pulling in a 'big' header file such an issue? This commit message is pretty useless right now, you're just saying what you're doing, yeah I can see that from the diff. You should use the commit message to explain why and what for etc. > > Signed-off-by: Thorsten Blum > --- > include/linux/mm.h | 2 +- > include/linux/page_helpers.h | 10 ++++++++++ You've added a new file and not updated MAINTAINERS, nor indicated that it will be caught by a glob? Also super super restrictive to have 'page helpers', that's likely to be tiny forever, why not just move this macro to mm_types.h and import that instead? It's highly likely it's already imported wherever you need it, anyway. > 2 files changed, 11 insertions(+), 1 deletion(-) > create mode 100644 include/linux/page_helpers.h > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index af23453e9dbd..bf49e52f749a 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -3033,7 +3034,6 @@ static inline void clear_page_pfmemalloc(struct page *page) > */ > extern void pagefault_out_of_memory(void); > > -#define offset_in_page(p) ((unsigned long)(p) & ~PAGE_MASK) > #define offset_in_folio(folio, p) ((unsigned long)(p) & (folio_size(folio) - 1)) > > /* > diff --git a/include/linux/page_helpers.h b/include/linux/page_helpers.h > new file mode 100644 > index 000000000000..102a4f3c3868 > --- /dev/null > +++ b/include/linux/page_helpers.h > @@ -0,0 +1,10 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ No description of what this is for? > + > +#ifndef _LINUX_PAGE_HELPERS_H > +#define _LINUX_PAGE_HELPERS_H > + > +#include > + > +#define offset_in_page(p) ((unsigned long)(p) & ~PAGE_MASK) Why are you only porting the page version when ostensibly folios are more likely to be the unit-of-operation in future? > + > +#endif /* _LINUX_PAGE_HELPERS_H */ Thanks, Lorenzo