From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B7BC3EF0D0 for ; Mon, 18 May 2026 10:56:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779101803; cv=none; b=IwjCAh60J0Okmsj/0Et0/Kuv/EzZh9PYY+COImvmPnZ9DheQ3eo/zkYVC9L86upOyhAiPY/aiHaflAEw+/+8W3TrjaHzRc5HlYbNdy/UEJzMJ/5K/4GCuHNF0BdDWSKo75QU0bdPwOIsiM8UGLkLJ3sBmLP2mAcAlq9SMTGzbws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779101803; c=relaxed/simple; bh=ujvNH1NzEG9dplaO8GJJIWoCtgg/VBz7AFBV930rdac=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dAjZRGaIIeTVhLl9+dUyVUcNNbaWlCnCYvBz7FJvlwlFI4XBoEveTj5P9y9C2C7y+GO4x1GtBUlnDXTxfBSgyrmo3fOAAruuCGevgZDBz/Gcz1WfiVpaxtvD0yWT87PovNfhsjM6C7jPOobvf1QbCi087Ug4gvfNvZuLZV7vLNg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IUEZ051W; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IUEZ051W" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12BF5C2BCB7; Mon, 18 May 2026 10:56:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779101803; bh=ujvNH1NzEG9dplaO8GJJIWoCtgg/VBz7AFBV930rdac=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IUEZ051WFCx4RVvKWLDQLiHMCw5eAKuWoUBrkjlOUves24cazWDG5MnTbwjNGWaq7 os4tDcwppDehsLIx+uvjQy8mWO75H1YJcoGW6R5Dc5IvgecL3wXT9oBd/NmlOJAhM8 mQoa5WPCkBJ/ygyAYX3sYCR4lwM5+e14bc6cnjBw5tp50nHN2bchi82rrXbeYyVtz6 OPhupt6UqF+FPHji1u6KqXc94b8vrUcZUOOfnX8j8oUBTPMvT2rWI0gvzG+vw/WFHp +PdfHzBJfmR4eu72zTMDi5E+giZIIouVF4pol68gpG/3NvNeIfPOmqWXTuxBAEkKfo OUwm7LaEZHkjQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wOveK-000000017iX-3AiR; Mon, 18 May 2026 12:56:40 +0200 Date: Mon, 18 May 2026 12:56:40 +0200 From: Johan Hovold To: sunliming@web.codeaurora.org Cc: dpenkler@gmail.com, gregkh@linuxfoundation.org, harshit.m.mogalapalli@oracle.com, kees@kernel.org, linux-kernel@vger.kernel.org, sunliming Subject: Re: [PATCH] gpib: lpvo_usb: rewrite DLE/STX sequence validation using !(A && B) for clarity Message-ID: References: <6a07e0f7.e59d1661.1cd5fe.6c90SMTPIN_ADDED_BROKEN@mx.google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a07e0f7.e59d1661.1cd5fe.6c90SMTPIN_ADDED_BROKEN@mx.google.com> On Sat, May 16, 2026 at 11:12:27AM +0800, sunliming@web.codeaurora.org wrote: > From: sunliming > > Fix below smatch warnings: > drivers/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c:808 usb_gpib_read() warn: was > && intended here instead of ||? This warning doesn't apply here where the two calls to one_char() return different values. It's meant to catch cases where the wrong operator is used so that a condition is always true: (x != a || x != b) <=> !(x == a && x == b) <=> true (a != b) > Signed-off-by: sunliming > --- > drivers/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c > index e6ea9422d6f2..3e09f8226a56 100644 > --- a/drivers/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c > +++ b/drivers/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c > @@ -802,7 +802,7 @@ static int usb_gpib_read(struct gpib_board *board, > if (retval < 0) > goto read_return; > > - if (one_char(board, &b) != DLE || one_char(board, &b) != STX) { > + if (!(one_char(board, &b) == DLE && one_char(board, &b) == STX)) { Whether one prefer one over the other here is just a matter of taste. > dev_err(board->gpib_dev, "wrong sequence\n"); > retval = -EIO; > goto read_return; Johan