From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A47C15B998 for ; Mon, 18 May 2026 13:18:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779110317; cv=none; b=uEgkRG7moyMRDpGBIjbONn5n03ZV3sPWw3R9lx5YLotDCSMMdf2LSoSInDqmjfsXKuHzah/FOIxXy2DsZqlu+UZY9cF+IJZ1+SU8hDIYYXYe+7tH7HRHPCb30HIhIyRpks8xu/NLrk2MFMokDly4ofDCGIkYniSNQhGMbe+6kVE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779110317; c=relaxed/simple; bh=6vO8+VBobvibKewzmOFr49cVP9se+saj+PjDO5DpDsQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LqZcbz3t/DiDhyR12hoKwLd7Kj7pUow1BK+dC2tKUJO4KBfkeFh/hyziEz5UbrbCjkG2uCg0x0raeriOICVYFeVsYW+RIetOIOUhDVAxd2TD4SUJOoLfaB9VsPWBj9My1kUVVO8UQTmY5zBSTe93AFEday7qR/A7+u8fhVXrkuM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=Moupty03; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="Moupty03" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-90caad2e944so248790585a.2 for ; Mon, 18 May 2026 06:18:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1779110313; x=1779715113; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Opuk146ebV3ErmSpRH0XudSNgvGZ5KUHoYlsDReltQI=; b=Moupty03BkYsXQQE5tCBWb5oY5OoLRx5qQO8CeGdKih34hW6aRm0WID+nRomlhRcro S6ooFyebqC0l0nk0OOQHJcNDjI6HjaQ4RGdjAOdvtzycVl9jPKlMKeDiZj3motJtixnV ZDcqpX4NomqmEuFM8+NBOB2e7WtbzdokpPo7qPUgv1WBbbsyBSxq7yvf2s5jIyuoVdVc WSXMn3B0ufOBQT6pwNtWYU7uH7x+Rdb9DYjIobC/ZIklgwSqXqFZ66MrPqTxPDSTqCP0 kmrHmrDFUZFjEDDL7IOGnOutwwjGUqXjiWukV46wMLUwy+zp9WKS5y5oKWI8b2Mfr4bc i6vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779110313; x=1779715113; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Opuk146ebV3ErmSpRH0XudSNgvGZ5KUHoYlsDReltQI=; b=aebwcMP9PM527lU3XJG6q/MPSHmEMdf8fQYjRQdR7SUqRCvZnzC+XoU/ft48OBXlFC 0JHiNGxSvvxwwoo7qXrTg9IzuqXrnd+RVG0ZL/Q0AFO5eU7zZOICw6jmsjPOqo+ttvYP 9PjhVC1MOncpiLf9u1S11NFmTjNXgXG6yah3u1eruNfNfJ3Ya9lLqC3nG+rjgBa6HGBr JWEo2oQAVQ5aOPgypov0gXn19vxIanfxfdYEqom5SytZawN3a+9j8allwxlHy7zV/yYI zuncIcdZXUlRsrzrRq+75j2I1ETtTxQy1Ntg5DqwIfK/ya0wgbYt4ZEiUbhxcYN6thCq CtDg== X-Forwarded-Encrypted: i=1; AFNElJ9Fh8y05NdofqVw4pW+g+7PtsvFpMyCaVDEDF3umLJhFd5Sor5XbTPpp/+Oj1xVxGHOlpfCUxw4uA1h1ds=@vger.kernel.org X-Gm-Message-State: AOJu0YxwkSOWTqgHEBSjIA2ktNIt1CmBqWA5dl3k5A0Zp5QGyaGYFgZm RvdXkqQuhnS1yaXyfAqmIKeOiNQ2mGvMq1bjawjfEo9TTRhn/TMbwq3eoS+nSB4/RWUVkBLVq7u YFBCV X-Gm-Gg: Acq92OE2p15gMS6DRUHd9rvOjWGTaLtEIm21V86leus9L9GBhTD+kUkKn5RYS3OumUF IHjSdHXHb8ZFnX1hMXtI21w2WCRXMMBB2C+WDntUMS2lO/es8/LHKvnlvOiEec5JpsCMjzgaOSx 1QAG6uMyn1YbQfkDol5t7FNygg9Y1DnfPBZIodB2dQuYkOpfLD7UP1R+tWWQwq1Msm5WlYb67dM HmRgPozA6o8XwDV3b8evHAuddbItjblJ3YcXt+Dy7ONXxf7OD1C9G9rAWmPkPvDzitPkWm9Z0Xg EFRIb4p/TPwx76wH7BIlWB7vyykBDylJctP9aVbzyjpvnygjpNQNodP0IvwUGP6VwlwrlBUSUW9 8mnX+VtqgLKqSVjRmucWIA7h1x2ZGdG0ltpaUUqEgUlX21O+mcGsMVYkA2L6qqgYpOU58NUk7j4 OJQKevLZ9Lagykv0Ut2u+kAAAjdCzPwBHL X-Received: by 2002:a05:620a:3188:b0:8cf:c272:9721 with SMTP id af79cd13be357-911ccd8b9d3mr2201624185a.6.1779110313301; Mon, 18 May 2026 06:18:33 -0700 (PDT) Received: from localhost ([2603:7001:f100:500:365a:60ff:fe62:ff29]) by smtp.gmail.com with ESMTPSA id af79cd13be357-910bc936407sm1491822085a.22.2026.05.18.06.18.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 06:18:32 -0700 (PDT) Date: Mon, 18 May 2026 09:18:28 -0400 From: Johannes Weiner To: Brendan Jackman Cc: Andrew Morton , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/page_alloc: drop a misleading __always_inline Message-ID: References: <20260517-b4-drop-always-inline-v1-1-97b90930e8b8@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260517-b4-drop-always-inline-v1-1-97b90930e8b8@google.com> On Sun, May 17, 2026 at 11:37:05PM +0000, Brendan Jackman wrote: > get_pfnblock_migratetype() is called from outside page_alloc.c, so it > cannot always be inlined. Remove the annotation to avoid misleading > readers. > > At least in my minimal config, with GCC, this doesn't change > mm/page_alloc.o at all. > > Suggested-by: Vlastimil Babka > Link: https://lore.kernel.org/all/016c8bef-57ef-44ef-bf60-86dbfd368dcd@kernel.org/ > Signed-off-by: Brendan Jackman Acked-by: Johannes Weiner