From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B8AB365A03 for ; Mon, 18 May 2026 13:39:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779111542; cv=none; b=FXywDbkOvsuKrfwKg5F5sONtbn/DMzMBWg5SrYA4G3CbhHWnMT7wK9g5FAr51sZdEhcHmxzleJN7TzoFCvWtktETylI7UxWnGG9adwWyL53IUZeM7yjyzL7EIjI27x2UNpGiqOyQEAsbCfl98palOb/KBV8e56QLubJCKrQxE0Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779111542; c=relaxed/simple; bh=KR75rhzDzIi44+U6XBx11BST96TBrOyXtReI4Gj0awA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KokaOL5Buqr5AtxcYOmDipOxCvVBa+HyLb683mufOdamWUZiRat6/f/6AqnHHBhLumDKkQMRVxBNOKZiddJlvhxlxI5ZsmlXMIoN+MzZWsj+hVAgE66jQrjzVx0qeqKLOv72Hhr9l1xMYO8Bp5UP3xrOl6O37yyjitAGOtjBpio= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Z3Lf03UJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Z3Lf03UJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 649FCC2BCB7; Mon, 18 May 2026 13:38:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779111541; bh=KR75rhzDzIi44+U6XBx11BST96TBrOyXtReI4Gj0awA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z3Lf03UJYrvfoeY/TuvbbBiS6rUSiUr/6GugZ20hknKwdaI8rC9AtlQKieakC1KgV QjSpe9Y6ZIuGepDazRYgWxf3YKmzO4G21wGzdVbSzAq1XROTQU6C2d+B8DV69x7UUX mBKwRxh02UQ2rNwQpKPYfAyWtgdoT8RRSjwM2P286LCnkVB+V5HPqoDYfygWQdb27Y v4Ct8p7Ocis1rPPwhl1Fcr3IxNvuED1oXdjBpswY78CFkC/BU4lMNWrqY4jDOWV8iz N9GBxj8D8wAui4Eg+tqFjfV2lbBfYda5/wP5/RBlXuutdrcHikEugUvV4/hcDmoNe6 FtxHSXachc6Sw== Date: Mon, 18 May 2026 14:38:55 +0100 From: Lorenzo Stoakes To: "David Hildenbrand (Arm)" Cc: David Laight , Yury Norov , Thorsten Blum , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Yury Norov , Rasmus Villemoes , Andy Shevchenko , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/3] mm: add bytes_to_page_end() helper Message-ID: References: <20260517123428.1181981-4-thorsten.blum@linux.dev> <20260517123428.1181981-5-thorsten.blum@linux.dev> <20260518100933.6bfe5b8f@pumpkin> <8d7dc7e2-d52b-4903-ad1b-3185b393ba24@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, May 18, 2026 at 03:24:15PM +0200, David Hildenbrand (Arm) wrote: > On 5/18/26 15:15, Lorenzo Stoakes wrote: > > On Mon, May 18, 2026 at 03:06:16PM +0200, David Hildenbrand (Arm) wrote: > >> On 5/18/26 12:24, Lorenzo Stoakes wrote: > >>> > >>> Yeah please don't, that's already a weird situation I don't really love the idea > >>> of extending that. > >>> > >>> mm_types.h seems the more appropriate place. > >> > >> I think I'd prefer vdso/page.h for something as basic as that. > >> > >> But definitely no new header unless really unavoidable :) > > > > I just find vdso/page.h an extremely weird beast. what does the VDSO have to do > > with it and why are we smuggling some basic definitions there... > > Yeah, I don't know the history of all that, but I know that BIT(), ALIGN() etc > are also in vdso/ ... and confused me in the past. > > So as long as PAGE_MASK etc is in there, I guess adding simple helpers in there > as well is the right thing to do. (I don't know if the defines could be > reasonably moved at this point) OK then begrudgingly I guess that's fine :) (don't get me started on linux/sched/mm.h btw, in the same vein as this file :) Thorsten - this might be the easiest solution here. Then the series becomes move the helper macro there (I don't love the new one so would rather you didn't add that) as 1 patch, and updating the bitmap code as a 2nd patch (with a cover letter obviously :) > > -- > Cheers, > > David Thanks, Lorenzo