From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9818A3AB284 for ; Mon, 18 May 2026 22:24:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779143098; cv=none; b=YLgLHLyhpCaFyS3PLvHsMbcywLzj7B6HWWaQex0KLBmuKSRFCStfEtRHfY+zzVrhPpqpodDxmHUxKgxJFxhloMqLNNi+pMq5vAfv+dPoiBodKSpOmWqKVJkh+iX5qHLbZTJYx0flCVrHT59ftSAyzdnbC2e0WIZMgyE7Ic0n+Ns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779143098; c=relaxed/simple; bh=cPFqibzt05U7+9OKSx2BqYF0uQt/jBSuHJMI1cCiTy8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dVky9RThgdnHp2xwBlFWGROiu3vlXKyP9NFFMx6zV4ky5w/mc8YH19FiTsGOUAnm0GOypklO9HWNOcKQxdL1QfHa0OK5IwZMUB4pFQnfGASQb4No60NT9KcayGYhZCA8iZuVt31hjpHqn8UpyMUcLlmclCvxWS/ZZsV9/cz1vjs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J7niZGEm; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J7niZGEm" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-8353c9f24d2so1371188b3a.3 for ; Mon, 18 May 2026 15:24:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779143095; x=1779747895; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Q7/YzMatW7mhE2BJtzNdI6oIt+QsL1Oe6mroM0UQHvQ=; b=J7niZGEmCg03fsxKJeg48nCrrvZUfvpswtv6fQz/Wec9bh8a0xRMR94ZaUZo8R3lLR MADpJBcORi9TNnN8Pupq6w3n5mgzN+qLh724J+S9YP5Y3E8cNTD4jx+GtnSoSv/26D/Q G886NvJx1bBPacZjq0wF3SPgyN/7ct1XHl7yijqCjXPOb9pds/XOi1s1pX7/0aN2rB0y oPG+vA+kDFsnhwnF0xTuVrfvlZ8QaspXBN15lj9AXewawdH2qFEJXEauSfhGZEkHsCDo muXAJGHfCiCausxqTXufrXfY9AqG/T58b4s0Z9E1EBaMP255pEitCVW0e4jHeeEOFLKz oVCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779143095; x=1779747895; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q7/YzMatW7mhE2BJtzNdI6oIt+QsL1Oe6mroM0UQHvQ=; b=JeHQCu4czfR2LwM4I1L74m6qiPj7KJSumeqyUZPS42EqAr6yxJrmS+Js00yh8eQksB kheLxxNjchscXEMCj3ln3F1zETaiQM0q9GXHaD9AQy3DjJ9+Wmi9762iVmyx6d0Bq+xT 2u2ZqriUpPc5F3MPYOyHApnvT0Q+fhhIUzNbudXvQj+9WeTBHOVyjZzKiSXU7gQp3cNC HTVREKxDNA/JPaCH3LX4JobGnqT10rh3HeWvqpjUdFlmJrCfBtBpQM6xcK1d129Ee7VM mjcaOsiz2+fxNL+AS/Qt2vZM/2OM87qEP0jBy8udR3I7kR/0sSW+n26917GfgF8oPK4A TtGA== X-Forwarded-Encrypted: i=1; AFNElJ8UpKTyr+9vCGdIsJmhI4wvp1X9NdxyW4G29iWWhXb7hhJatpnA20uwbKJSQqBDNO3EZUVnmV44rdsh2Zg=@vger.kernel.org X-Gm-Message-State: AOJu0YxFYufkebyh+rk9Qy7ev0GnIhNg5VbKBpKldzI/+4AsXpgii9Vj DpDlQADMcuSh5Ph/VM4eCPwjs+h6euCJT58HXMqbGdqTdKQC2QbjUy3y X-Gm-Gg: Acq92OFPQW+sWLN58dXd4h5HRgYyuvjW4IIVu1FhOy2Ts/jMWmvrFEVfd1me4vnO7LM zL39paZaMpMtPqOkr2dNH2oBxJSNfVwfTUTiPC0AAc2Bu3E81kTMyVnlgwAR2SeOUUheQrRiGyb TOh+RRheOcB0ue8T/owGZRXXezBkOHLfJMXpoafVoX43rgKvGHrxSld0d9IlRS4Bry2BDcm5CxJ /as/pK77a+AE2gRHG6vbG4JIF4ldqNZ5C7cMN7yBBRlXYYVhuV5TM6PWdJLgdwMfMQ9GKpFYr2k VKZrNNZ+yAtCye/qTDAgrowxjsvqOEOIN5sT1L5THFG9D+9i3q4mIGwOhUDBjQrhAWNEs1L+IAx oMbgKUDvwrb00E4TNiybm/h3Euu4iJHx6Ux1jhntJ9GWWsdSDEwm3VgB1HO8gXpv+FfquUWndG3 xu+GEdTIUVj/+TmAs9v8KXUXA= X-Received: by 2002:a05:6a20:a12b:b0:3aa:f9cb:d435 with SMTP id adf61e73a8af0-3b22e67fceemr18950707637.11.1779143094823; Mon, 18 May 2026 15:24:54 -0700 (PDT) Received: from localhost ([2001:19f0:8001:1b2d:5400:5ff:fefa:a95d]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c82da93df0dsm7926182a12.19.2026.05.18.15.24.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 15:24:54 -0700 (PDT) Date: Tue, 19 May 2026 06:24:19 +0800 From: Inochi Amaoto To: "Gabriel L. Somlo" , Inochi Amaoto Cc: Ulf Hansson , Karol Gugala , Mateusz Holenko , Joel Stanley , Kamil Rakoczy , Andy Shevchenko , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Yixun Lan , Longbin Li Subject: Re: [PATCH v4] mmc: litex_mmc: Set mandatory idle clocks before CMD0 Message-ID: References: <20260517015323.264179-1-inochiama@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, May 18, 2026 at 06:20:49PM -0400, Gabriel L. Somlo wrote: > with this patch on top of today's latest (4d3a2a466b8d), I get > (on 64-bit rocketchip with Litex): > > [ 6.475114] mmc0: invalid bus width > [ 6.477870] mmc0: error -22 whilst initialising SD card > > Thanks, > --Gabriel > Hi, Gabriel, Could you share the board link and build commands? I think I need to take a look for why this occurs. Regards, Inochi > On Sun, May 17, 2026 at 09:53:23AM +0800, Inochi Amaoto wrote: > > The litex_mmc driver assumes the card is already probed in the BIOS > > and skip the phy initialization. This will cause the command fail > > like the following when the old card is unplugged and then insert > > a new card: > > > > [ 62.923593] litex-mmc f0004000.mmc: Command (cmd 8) error, status -110 > > [ 62.949717] litex-mmc f0004000.mmc: Command (cmd 55) error, status -110 > > [ 62.976606] litex-mmc f0004000.mmc: Command (cmd 55) error, status -110 > > [ 63.002516] litex-mmc f0004000.mmc: Command (cmd 55) error, status -110 > > [ 63.028442] litex-mmc f0004000.mmc: Command (cmd 55) error, status -110 > > > > Add required clock settings and initialization for the CMD 0, so it can > > probe the new card. > > > > Fixes: 92e099104729 ("mmc: Add driver for LiteX's LiteSDCard interface") > > Signed-off-by: Inochi Amaoto > > --- > > Changed from v3: > > - https://lore.kernel.org/linux-mmc/20260426112016.1370929-1-inochiama@gmail.com/ > > 1. Remove patch 1: mmc: litex_mmc: Move litex_mmc_setclk() to bottom for reuse > > 2. Use set_ios() callback to apply the clock change. > > > > Changed from v2: > > - https://lore.kernel.org/linux-mmc/20260424013615.470325-1-inochiama@gmail.com/ > > 1. Remove the added function forward reference and add a new patch > > for moving litex_mmc_setclk() function > > > > Change from v1: > > - https://lore.kernel.org/linux-mmc/20260421025052.755471-1-inochiama@gmail.com/ > > 1. use fsleep to replace udelay > > > > Inochi Amaoto (2): > > mmc: litex_mmc: Move litex_mmc_setclk() to bottom for reuse > > mmc: litex_mmc: Set mandatory idle clocks before CMD0 > > > > drivers/mmc/host/litex_mmc.c | 37 ++++++++++++++++++++++-------------- > > 1 file changed, 23 insertions(+), 14 deletions(-) > > --- > > drivers/mmc/host/litex_mmc.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/drivers/mmc/host/litex_mmc.c b/drivers/mmc/host/litex_mmc.c > > index d2f19c2dc673..65d5c728f536 100644 > > --- a/drivers/mmc/host/litex_mmc.c > > +++ b/drivers/mmc/host/litex_mmc.c > > @@ -68,6 +68,9 @@ > > #define SD_SLEEP_US 5 > > #define SD_TIMEOUT_US 20000 > > > > +#define SD_INIT_DELAY_US 1000 > > +#define SD_INIT_CLK_HZ 400000 > > + > > #define SDIRQ_CARD_DETECT 1 > > #define SDIRQ_SD_TO_MEM_DONE 2 > > #define SDIRQ_MEM_TO_SD_DONE 4 > > @@ -449,6 +452,9 @@ static void litex_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) > > { > > struct litex_mmc_host *host = mmc_priv(mmc); > > > > + if (ios->chip_select == MMC_CS_HIGH) > > + ios->clock = SD_INIT_CLK_HZ; > > + > > /* > > * NOTE: Ignore any ios->bus_width updates; they occur right after > > * the mmc core sends its own acmd6 bus-width change notification, > > @@ -459,6 +465,11 @@ static void litex_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) > > /* Update sd_clk */ > > if (ios->clock != host->sd_clk) > > litex_mmc_setclk(host, ios->clock); > > + > > + if (ios->chip_select == MMC_CS_HIGH) { > > + litex_write8(host->sdphy + LITEX_PHY_INITIALIZE, 1); > > + fsleep(SD_INIT_DELAY_US); > > + } > > } > > > > static const struct mmc_host_ops litex_mmc_ops = { > > -- > > 2.54.0 > >