From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63327405C53 for ; Mon, 18 May 2026 22:45:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779144329; cv=none; b=ow0MoocQy2bl3g9YQyyIeJ8u3G2EzI2ng2PUjRROZ7p/T6Gx0h+JzQn6NMHubiXDIzv6QgvedgqWNhHaxlY73NzKT5+t/5hEwbEekk5JccmIJNh9erlau0I3bMvGg0TS2k5Pfza4ztBf+3NJU/YzEjSeCwy/JVjGYeOcrIFKKXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779144329; c=relaxed/simple; bh=cnniRsLFOk01Z/7XuKrCVPhZkmPa+e2hY1i3r8pNzPU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UvWQgfgdFJaxAIhAZA+HPXYnC4vUpjNnJma1z+l5u7e4YlMkVKNFT8lE4pXCi2fKM93OYNHyLogu2owSpLjTj8y3+Gy0zGLLrfoJ8C4inC1fJXElpBk/CEkrRpjPJpzd7+qzTb2alcYmuQzAsWtHkny0YvCa2XCsP6exmeTKLvI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b=Co1/V7Jp; arc=none smtp.client-ip=209.85.128.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b="Co1/V7Jp" Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-7b37d84a6b3so22107217b3.2 for ; Mon, 18 May 2026 15:45:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20251104.gappssmtp.com; s=20251104; t=1779144327; x=1779749127; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=Axp4LE2NtRnDsArtRdnWVVhQ0pn9hV1WCuEIepOZry8=; b=Co1/V7JpUa7SElvKk9OjVbyX4J+c4mZ18OjdvytZH0f2gmlhXqmANCeUarSBuVMVGB +zHNpXsVuke68q9/vasDyLZSI7z11/sHxgca+6N3+ertkxcKjaU11XsRZhHbvV6eSVcQ uQ3kaVxMJU7sNRg5T5GWurZsan6W/ssbU7n6pvfFBDKvlT/0J76LRWvbIcIB1dCvWs0g lMvR2mh9RIy4vdPO05LXp5ZQjM7gREJIpeXMpMg9sTWt3j8jD18YOVjofSyV6O7HHF3s mk+x7Ge9nQvcfpIkm89yAjef3HQ+3wgS4qECWmvWPtAgc2axsvwmGllbA81ojJTyRgfP TYmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779144327; x=1779749127; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Axp4LE2NtRnDsArtRdnWVVhQ0pn9hV1WCuEIepOZry8=; b=afiW05l9i3dgJfxSbCDuhTviwuGw3FsXAsdKKdVF6N6Y2fQoLb5No+CfieDkoyW4SA jm8sSu4Iftq3oxu3SnNvARxakfWZhvB+wZaukl3X+cR88Zk8d6uBMzzbuIHxSG07ntXX fXzPEF3ylgiED5fw57zJGBX6Q75BfOlCOGCvgy0eJfbSphJPp9RnXMMoqqPKpiD7LIOG ftYak9L0E7BTNz+a0452jB19HLbTb206Mh6XQmMSKVLtqniY4EevUgM66VgMOJd8DkFq WFkbgkKVOjx4YQB1tZZUaB2SstsSF0IF3J/tVun+htl+GIEBpTUrICXIDrp1RtXUSkT2 buTA== X-Forwarded-Encrypted: i=1; AFNElJ/9Rx6uUvckPlc/R/mTIiaDasMoJIalsEJYUi/AfKDrzdOLpTJ3ssc7Lze285ccfcD4F78tNpc7345czIc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0e0tUXGrBpd0UXHvj9I+iRSzKp14ER7NyFmMN+YzgisAAMCH9 QwCs+4hzG6pR8w6AOgyyN0rRLtRO3cgDwosSrx6GlZkzJiaMbnSFh5XeXuS97TX1Wk4= X-Gm-Gg: Acq92OHIP2rXoJ3gg6K3WoF++dSdGvLaFbMAlNi/s0fYYqiFa1xn9dD8GuzLxmWjggC 7s45eN4WabD297M60cuhkVcqv89FeTbldZoSRijjYQ/Lzp35/VsNjJ3J428fMltJY3mMwDIQdyY MBPV30Y30IO07RwBqjAjfXU6B3wtOp6pFcKpBecx143JcZ626j49p7FmXbiDMvTxAw+kvyU9jGT b/Rjsci5QWa3+2Adiw86CCPDlntiIF5H0XE2siTUQ/+WY84PPM51wtWBLMoqylwHBFR7Z7ctOc1 /qwl46vvn0OXe6L2ADG6bltHjSEZzsvdB7Ruk2q0/HbC4rBtPfzJiROe1dhDYKW/6DrV7NQyxL9 yG+I8y/R0ReXat+qZxFrLXfCKqZ36LxNLkh/JB0Xi12JlqHnDdljC4BCP3NFtewgqZOZ1X9fUPn SRR7Ru X-Received: by 2002:a05:690c:3386:b0:7c0:82ec:fe82 with SMTP id 00721157ae682-7c95ab60588mr187569937b3.11.1779144327197; Mon, 18 May 2026 15:45:27 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:71::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7cc9d18d8dasm28228067b3.48.2026.05.18.15.45.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 15:45:26 -0700 (PDT) Date: Mon, 18 May 2026 15:45:25 -0700 From: Joe Damato To: Martin Karsten Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Tariq Toukan , Gal Pressman , =?utf-8?B?Qmrvv71ybiBU77+9cGVs?= , Frederik Deweerdt , Dragos Tatulea , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3] net: napi: Skip last poll when arming gro timer in busy poll Message-ID: Mail-Followup-To: Joe Damato , Martin Karsten , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Tariq Toukan , Gal Pressman , =?utf-8?B?Qmrvv71ybiBU77+9cGVs?= , Frederik Deweerdt , Dragos Tatulea , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260518181337.886459-1-mkarsten@uwaterloo.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260518181337.886459-1-mkarsten@uwaterloo.ca> On Mon, May 18, 2026 at 02:13:32PM -0400, Martin Karsten wrote: > Skip the extra call to napi->poll(), if the gro timer is armed at the > end of busy polling. This removes the need for having a separate > __busy_poll_stop() routine and its code is moved directly into the > relevant places in busy_poll_stop(). Remove obsolete comment about > ndo_busy_poll_stop(). > > This is a follow-up to commit 58e2330bd455 ("net: napi: Avoid gro timer > misfiring at end of busypoll"), which has deferred arming the gro timer > to the end of __busy_poll_stop() to eliminate a race condition between > a short timer and long poll that could leave the queue stuck with > interrupts disabled and no timer armed. > > Co-developed-by: Dragos Tatulea > Signed-off-by: Dragos Tatulea > Signed-off-by: Martin Karsten > --- > Changes since v2 [1]: > - Fix patch formatting problems. > - Leave STATE_PREFER_BUSY_POLL bit set when timer is armed. > Don't want interrupts anyway until timer clears STATE_PREFER_BUSY_POLL. > > Changes since RFC [2]: > - Sending only the cleanup/improvement patch to net-next. > - Expand commit message to summarize original issue. > - Streamline control flow. > - Improve comments. > > [1] https://lore.kernel.org/all/f0ecdde3-de16-47ba-b795-fe0042114e96@uwaterloo.c/ > [2] https://lore.kernel.org/all/20260428175134.1197036-4-dtatulea@nvidia.com/ > --- > net/core/dev.c | 63 ++++++++++++++++++++++---------------------------- > 1 file changed, 28 insertions(+), 35 deletions(-) Reviewed-by: Joe Damato