From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D83DC3FB7DC for ; Tue, 19 May 2026 09:34:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779183294; cv=none; b=Zrcj985CPjYOfpibMFFQX8uAkuXtpf/U3bq7N31M8I1EgMjyMaSjvPuTrie624tLxEI23aqcwwt7FE/WL/S4RMb4RcvLdtMp+keJUmSs9hCxev7dFjAaqB0QuJ4q+9qkSRCUwNCrL2LHlkSJ0lSXgHAGz3iLUynr2l12bsWysng= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779183294; c=relaxed/simple; bh=5BRUkfJ8yWKLSlTeo99Bxx0jEUv61v6j26fDM1Lpuhc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Gu+Djys0GpJU8aPj1rfYQyZA3nmSYojypYqGTSl5YgwFCYov2KKhHBkWG5eeLxgZYHhTLCj7Gt8lBWFqrgqVHO4XFcNhPPYi32ywb23VGiEEi4vrJ3xKvFcdz4XPQd12YZgs5iqzqhiP/slGfIpSPa5xrSB//H4MaUwIJ0mDVeg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EjRCncJ+; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EjRCncJ+" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-488ff90d6c7so24366025e9.2 for ; Tue, 19 May 2026 02:34:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779183291; x=1779788091; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6lC/QkW3y7vcOvBVpiAsZwYueGMsLbUKcivFxoMy4Vs=; b=EjRCncJ+70huafNw1gD2QR7V1z4gdLrR1yhiZ90Yj77+wIGQU90nMBKIBzufz2g9U2 Y4S9vrqHM33OX9tQrtuBdOr2WMWYjpOSeI49fHYjQSvY9dmtQSoGjCKjBx8CdXtSAoBb 9zGDT8U0sRwIYjGF/nwv2uS56Y6pNb01YHBoDabanVyv/emKwt1mC/L913cH36F9GcFO RIWKbqF6hLWu6gwL9gCzpBWdHcMgasfF+A2OaBufuCGD8bL/++9WGFxryMfZiX4VtixG 0Y1rG1nWu91iZR2zw75Q3zy7jdafHXDtQ3+vJndzHfjc+kPsnQKUW5tP88PH1AxE3pPf iw+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779183291; x=1779788091; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6lC/QkW3y7vcOvBVpiAsZwYueGMsLbUKcivFxoMy4Vs=; b=hZrmj+XNM571n8WMYFntGwmkGc0Ok8jBnHuRr3HhHft9C8ZUZMGPT84311qRS50cAb 9MR4IZ9y6nIU4rRPBqMWG4o2hCqE/ps4XD4yFu+z0z8ilOIvG0ICWICogy0REF7eyozy 7vWPX79M19zILUwH+MaZvm1TLXNo2R8i1g2KPYx11VbgUALBlQCIyI17RqBtXw54GPA9 FE7g4bf7os/fgTruk01OsmjwIqTIuifxTo5JWDlA0Rh1TLvf1iJrMQOpysGY3CN4g/Z3 XQ7plfVtqr2IXUe8y/pt7/Ydx0/57WY439lzPggsu1RM5Wxb5cDpOtI1j/b6ZcBvPF+P atew== X-Forwarded-Encrypted: i=1; AFNElJ+y39E4+S4reysquHzJeFGfBXXdDkvY+X71rbbhpenogbfCMqYvel3r5TzrqXwXxx1U66GDeRhN0Xpeu8s=@vger.kernel.org X-Gm-Message-State: AOJu0YyTb15p32K4EmamWQABiZDm+GYNkKDVd4H06ZbMPxHBHTg4gVX+ 5PMJO+bwD/QlZf4IlLNEVXxC6mp53JIFkPQMEy9QjP6R7FsHieSX2NYW X-Gm-Gg: Acq92OGaylMxcp8ogzOIRSdLjsMMgLzGHAaLD7dmGxM7epE+qtMGBLKIwuD0+unBGOf lq9VGQPmdtrx246nQDBHoH5dSXMtgjgT7i+Z3+WwxtGjQdW98uM13GAFoX4weHxMgtu4ShUHvB5 F+e8b9NxfaBA5aDy7aiDkIytuHh13CQmyKSpbTDTk/q5JtDATpJZFrPbFJ3qZqO6PqmkU/B71QR H7euQ+coEcwN711cltD2gwsNKVLVjaawkzPGOAXIt+1Kr5ZSriMbvVSuh+67UFw6ZMeYfTQcJZ8 UMxo79S/DlqslQArpflKGUH0BxKVMwz5bZ7/4Ii1zA81XTZZx4RvgsAOVzOtIBDHVh3J3xWE382 s5MnyovCVMZZBZ8ZhW6D5f7GVKTN1HKoHD2NbUDzodwMYU/z9uViQr0HsvXjBTmkNQevb4fX2/f XdKLHrqXcUdccCxrCPp3yLRo8M+qmMZpBRNA== X-Received: by 2002:a05:600c:5296:b0:490:31e:d6f4 with SMTP id 5b1f17b1804b1-490031ed905mr175484765e9.18.1779183290935; Tue, 19 May 2026 02:34:50 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe57944c1sm344478195e9.7.2026.05.19.02.34.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 02:34:50 -0700 (PDT) Date: Tue, 19 May 2026 12:34:47 +0300 From: Dan Carpenter To: lixinyu Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: fix coding style issues in rtl8723b_hal_init.c Message-ID: References: <20260519090114.828918-1-xinyuili@126.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260519090114.828918-1-xinyuili@126.com> 1. Work against the correct tree (staging-next). 2. Fix your From header. On Tue, May 19, 2026 at 05:01:14PM +0800, lixinyu wrote: > Fix checkpatch coding style issues: > - Add spaces around binary operators (|, &, +, >>) per kernel style > - Replace C++ style comments (//) with kernel style comments (/* */) 3. Do this as two patches. 4. Run your patch through checkpatch.pl and see this issue: ERROR: Missing Signed-off-by: line(s) https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ regards, dan carpenter