From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A11533769F1 for ; Tue, 19 May 2026 14:52:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202324; cv=none; b=PhbozsJNmZ+h6ewy4y7qEr/tKi+ut1UD+wKx4RzfMneqOc+rYzzTg8IS4DVNBetSeD4fKHSGK2JZJo8peoTe5ek+eeVQlXUUtBRAqDYBlKqeBfNd9Dqm2x73sIYTVyk91uSsfNA93rENvyFqaGs4DKrkFmF5imUCPzFGWZTng9s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202324; c=relaxed/simple; bh=UevNXJHbNfmCuhxABKGKPMdec8G8PCjX4ba+hL8sNmI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YDzfytF+rC1pyjZ0m9HmeHS4FLYto8P4ehpwmy+WPjTGPN0y3tbVuTDrtB1G3phl4QJKI8I1u8DEunq6dK71s5/6PVYKE7WuUTCPr7odkuqVFluG4w/2ENruqg5g/U5WMlmWtyQIQsjNUtPbNd5d3CGNNmwcGWVmUWNaP7JnuVI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fA8UdK+A; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=CCUcRBW+; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fA8UdK+A"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="CCUcRBW+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779202322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V0uXNBPWEICurSaeD4MWEpMYBS3113b02AXnGrWCKxQ=; b=fA8UdK+AbUea2uv6EwT+PdjxNBKunnj4cAwujEqcfEdBuAyodLqqp1idfvm3NPURN5sPHF PGPPRDKkOu3jwfHHs2y9wF/OZ0UnemqLq2Gxbqibdw4hSCXoLC+/8rzfcAS4TM0P9a4gIc sewaTEeb+TZ0ah2qwJ8Y1eKCcCdV2fg= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-537-4t917zXZMkyvBDjmfDA-LA-1; Tue, 19 May 2026 10:52:01 -0400 X-MC-Unique: 4t917zXZMkyvBDjmfDA-LA-1 X-Mimecast-MFC-AGG-ID: 4t917zXZMkyvBDjmfDA-LA_1779202320 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-7cb345d0b29so72083077b3.2 for ; Tue, 19 May 2026 07:52:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779202320; x=1779807120; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=V0uXNBPWEICurSaeD4MWEpMYBS3113b02AXnGrWCKxQ=; b=CCUcRBW+bOtKP7NWYRd17bHX2ohTQCyMka8Beg8Fs6O9bVFkHbEA40o6izvlSjhR99 IGwxkMkeEHcAe6FuZdFEO+zgQvrsCUWvzrDOuHxyUTUsUzqzLOO9mNcl0BYUptFaKNIe v2mAghgHPiE0bJ8gcy+z0f2uno3TOkUwnaLyNO9M4pUppZaTNMPbmJjlQqkkTCeCiAOS lqS1aBpU5NiLDarXtM3/OJlPUd9TjG47z31gdsYPOpJ0ommmH8KLxOfwnENKJIvqww6O dqeLCcn2tZssNgbDyPszVfdI0NwgWT3Z7T4o7dqCQEWah77qbo0PYbZbWim5FK1rM3iJ NElQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779202320; x=1779807120; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=V0uXNBPWEICurSaeD4MWEpMYBS3113b02AXnGrWCKxQ=; b=An1Q3ZS1CSOI/vq4zgaNVVyOs0MuH0YHTmyozHiw+gqROtTJTOZ1SQ8Kt/dcPRYQpP VG+2ZFm3nrYpo5fn8uJdj5gX8viejqIExrtZ/3v+Mdjxw0DAWaHLfO5Ma55XHxG4+D9H SArtNe1m/d6DY4c8PZz/eXjVstY5MEwYXHdvN90DSzORRhLdeAKPW52K+8AB6RoamgIk /hBtPZEyrwPBsBUuJgPHjiScbznXqi0HBoD1Xm1GEFp3ORepP1gzg0IAnv75fdlvFgQ/ UypfrSpx/NtswuCg+0v+yHBUVdOyEe4tB75wAwsyHoBI9vO+cXFSWf4eA85VD7yARcn+ j4ZA== X-Forwarded-Encrypted: i=1; AFNElJ+DvWSOQOweXLadqcwwgYo3OCavvGR3d/p2wnGTuU8bxRupw5eWFF2fgJHSayEDGmHkQC50a0sQquIBDEY=@vger.kernel.org X-Gm-Message-State: AOJu0Yyzuc/CyMx9dixE5HAOsor+NtYRDzPQ3wcjoaZM1SozuMDcogBj eCJNv7x9ypKw4d9hyeu6GpXxRfKJDufxyjxv0lA66jw9UAaQ2YW/IM9lOEdHipn+f3WkgfcddWL 96wcq+Ix4mnenHf1d2eVpKa+w539av0EDUuevH1nfLU4M5YVkwgno2ef1s/lnGCMUEw== X-Gm-Gg: Acq92OHwFyiMqEtgPE7A49lA77WPMTN48wousY1GwKS2QVz6LZTmG+1z40antp199J3 MyStiFEjSbwnNuf7Ln9/m+0EcoIytYhVgAFF3Xz+LyspvwDn4uBOkNcnZ2nctZ3igdiijo0lTwe u+fLzphcWxsNK+3Dl+by+tlH2Eif9BkWrGoK6t7AySOBrL35UCZyQcdpNHmZexGJP8EC8RygRui Rb+R30T0L2CDqV7IBThpCTvFb7iXL16sSTm8c7Rblb4tRAcyfSywAs71L+6mjwOFPRU9bUHxHoG Oc6D+z5rgAB1mz4IiO2SpS8jX32GqkYqNl35/7E+OmPCk0Ee4nZujggEwfNjG/9ZlTGsrNrWANV kPlODVA07yPFw9lcPB45AbtiKB05qxCx2jUM88ae7FPFFVlLd10n+7A+Q X-Received: by 2002:a05:690c:4424:b0:7b3:852d:eed8 with SMTP id 00721157ae682-7c95a66e7damr198299387b3.20.1779202320599; Tue, 19 May 2026 07:52:00 -0700 (PDT) X-Received: by 2002:a05:690c:4424:b0:7b3:852d:eed8 with SMTP id 00721157ae682-7c95a66e7damr198299007b3.20.1779202320032; Tue, 19 May 2026 07:52:00 -0700 (PDT) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7cc991c97absm38128667b3.8.2026.05.19.07.51.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 07:51:59 -0700 (PDT) Date: Tue, 19 May 2026 10:51:57 -0400 From: Brian Masney To: Joey Lu Cc: mturquette@baylibre.com, sboyd@kernel.org, ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] clk: nuvoton: ma35d1: fix ignored div_u64 return values in PLL freq calculation Message-ID: References: <20260513055626.1070533-1-a0987203069@gmail.com> <20260513055626.1070533-2-a0987203069@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260513055626.1070533-2-a0987203069@gmail.com> User-Agent: Mutt/2.3.1 (2026-03-20) On Wed, May 13, 2026 at 01:56:24PM +0800, Joey Lu wrote: > div_u64() does not modify its argument in place; the return value must > be assigned. Both ma35d1_calc_smic_pll_freq() and ma35d1_calc_pll_freq() > called div_u64() and discarded the result, leaving pll_freq holding the > undivided product and thus returning a frequency orders of magnitude too > high. > > Fixes: 691521a367cf ("clk: nuvoton: Add clock driver for ma35d1 clock controller") > Signed-off-by: Joey Lu Reviewed-by: Brian Masney